From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 563F6C433E6 for ; Fri, 12 Mar 2021 15:59:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 125B464FDD for ; Fri, 12 Mar 2021 15:59:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 125B464FDD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.97215.184559 (Exim 4.92) (envelope-from ) id 1lKkBq-0002iA-Cn; Fri, 12 Mar 2021 15:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 97215.184559; Fri, 12 Mar 2021 15:59:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkBq-0002i3-9B; Fri, 12 Mar 2021 15:59:02 +0000 Received: by outflank-mailman (input) for mailman id 97215; Fri, 12 Mar 2021 15:59:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lKkBp-0002hy-5B for xen-devel@lists.xenproject.org; Fri, 12 Mar 2021 15:59:01 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c9a85205-d6d9-45fe-8c28-43b7ec5d9819; Fri, 12 Mar 2021 15:59:00 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 77C1BB126; Fri, 12 Mar 2021 15:58:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9a85205-d6d9-45fe-8c28-43b7ec5d9819 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615564739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1sysbFB17Or6V00qOcCRJOBVe83PeMncfFsr7otsfY=; b=JclNHvwAoTVVbEJ30F5fNVBzQS8RMxrGTEIiK149snnftKdqghSv1oFOX87IWCFKiwA6eM hLmyiB7rjlDOXKKdQXUwxoTwUaBKiS94O2l2zM/i+l4NMHKy3lTNy6zmzR2kjUMkY+Tr+X HSnYn8ELoNAyvnmmimwKPqK30Let780= Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning To: Ian Jackson Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall References: <6bd14438-7dec-2176-eab5-5898f190c4d8@suse.com> <24651.15544.142804.468744@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <46176065-8ae3-cb42-f031-aad12512d29e@suse.com> Date: Fri, 12 Mar 2021 16:59:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <24651.15544.142804.468744@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12.03.2021 11:04, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"): >> This is pretty much what we are already doing slowly by initializing >> values to shut up older compilers. I agree this is more limited, but we >> also waive off diagnostics from every single compiler in that code >> rather than just one version. >> >> Hence why I suggested dropping -Werror for older compiler. This is not >> ideal but it would give us the ability to keep support for dinausor >> compiler and not hamper our ability to take advantage of newer compiler >> diagnostics. > > I agree with Julien. I think we should avoid adding these redundant > initialisers for the reasons he gives. > >> The ideal solution is to drop support for older compiler (see my other >> thread). But this sounds like a daunting task so far on x86... >> >> Anyway, I will not Nack the patch but will also not Ack it. I will let >> another maintainer ack this patch. > > But this is outside my usual area so I won't nack it either. But would you be willing to release-ack v2? Jan