From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755510AbcGEVPl (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jul 2016 17:15:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41756 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751880AbcGEVPi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jul 2016 17:15:38 -0400
Subject: Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on
 release
To: Christian Borntraeger <borntraeger@de.ibm.com>,
        Joe Perches <joe@perches.com>, Steven Rostedt <rostedt@goodmis.org>,
        Borislav Petkov <bp@alien8.de>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>
References: <1467642292-15671-1-git-send-email-bp@alien8.de>
 <1467642292-15671-2-git-send-email-bp@alien8.de>
 <20160705142648.57456ef8@gandalf.local.home> <20160705184517.GF12027@pd.tnic>
 <20160705145732.4b6dbd55@gandalf.local.home> <20160705194244.GG12027@pd.tnic>
 <20160705154959.2705b658@gandalf.local.home>
 <1467749333.16342.5.camel@perches.com> <577C1E63.8060608@de.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>, Franck Bui <fbui@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Janosch Frank <frankja@linux.vnet.ibm.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <46183d11-5800-bb69-2da8-58fadc699cb8@redhat.com>
Date: Tue, 5 Jul 2016 23:14:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <577C1E63.8060608@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 05 Jul 2016 21:15:37 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 05/07/2016 22:53, Christian Borntraeger wrote:
> Yes, this is new in next. As far as I can see, the new message would only
> appear if we would call ratelimit_state_exit. Correct? We do not call this -
> I assume this is ok?
> 
> We really only want to reuse the rate limit base code (to avoid writing the same
> code twice) and being in lib indicated that this can indeed be used outside
> printk.
> Now: your patch 1 would allow me to get rid of the messages completely
> by setting the flag and by not calling ratelimit_state_exit. Which is probably
> what we should do in our code.

Can we delay fixing this after the code is merged in Linus's tree?

Paolo