Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, corentincj@iksaif.net,
	sziwan@users.sourceforge.net,
	acpi4asus-user@lists.sourceforge.net, len.brown@intel.com,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model
Date: Wed, 11 Apr 2007 22:32:14 +0200	[thread overview]
Message-ID: <461D45CE.3030309@gmail.com> (raw)
In-Reply-To: <20070411132053.899462b4.akpm@linux-foundation.org>

Andrew Morton napsal(a):
> On Wed, 11 Apr 2007 15:04:35 +0200 (CEST)
> Jiri Slaby <jirislaby@gmail.com> wrote:
> 
>> @@ -706,6 +718,8 @@ static int get_lcd_state(void)
>>  {
>>  	int lcd = 0;
>>  
>> +	BUG_ON(!hotk->methods->lcd_status);
> 
> mutter.  We could just warn-and-bale here.
> 
> Hopefully this is just an is-jiri-sane assertion and it should never happen,
> no matter how busted the BIOS tables are?

Exactly :). Only if somebody changes the code around, so that it is called
with the method unset, it triggers and in that case it's definitely a bug.

Side note, as Danny wrote, there is an asus-laptop driver sitting in -mm,
which supersedes this one -- if you plan to push it upstream in the near
future, don't bother with this patch.

thanks,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
 B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E