From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kirill Marinushkin <k.marinushkin@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>,
Pan Xiuli <xiuli.pan@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 0/2] ASoC: topology: Improve parsing hw_configs
Date: Mon, 2 Apr 2018 19:57:31 -0500 [thread overview]
Message-ID: <461bbabf-7c36-1361-8f66-5abbe3c7f4d8@linux.intel.com> (raw)
In-Reply-To: <17f0767a-2dea-92dd-a88e-a3f3e670d0d2@gmail.com>
On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
> Hello Pierre-Louis,
>
> I explicitly clarified with Takashi: to have this patch series merged, we need a
> tag "Reviewed-by" from you.
I am fine with the changes, but maybe while we are at it, we should
clarify what mclk_direction means?
__u8 mclk_direction; /* 0 for input, 1 for output */
This is really awful and might benefit for additional clarity using
codec-centric conventions.
We also had a discussion internally and can't figure out why the strings
are different from the fields in the structure, I feel it'd be simpler
to align config and code to avoid issues but keep existing notation for
backwards compatibility, e.g.
if (strcmp(id, "mclk_freq") == 0) || strcmp(id, "mclk_rate") == 0) {
if (snd_config_get_string(n, &val) < 0)
return -EINVAL;
hw_cfg->mclk_rate = atoi(val);
continue;
}
>
> Patches [2] and [5]:
> You already tested them. May I put a tag "Reviewed-by" with your name into them?
>
> Patches [3] and [6]:
> Those are new for you; I added them to this patch series, because they are
> logically similar to [2] and [5].
> Could you please review these patches?
>
> Best Regards,
> Kirill
>
> [1] [PATCH v3 0/2] ASoC: topology: Improve parsing hw_configs
> [2] [PATCH v3 1/2] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
> [3] [PATCH v3 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs
> [4] [PATCH, alsa-lib, v3 0/2] alsa-lib: ASoC: topology: Improve parsing hw_configs
> [5] [PATCH, alsa-lib, v3 1/2] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
> [6] [PATCH, alsa-lib, v3 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs
>
>
> On 03/27/18 22:56, Kirill Marinushkin wrote:
>> Hello Jaroslav, Takashi, Mark,
>>
>> This patch series is a resend of [1] and [2], rebased on top of the latest
>> head. It was logical to resend them together.
>>
>> It includes 2 patches for linux + 2 patches for alsa-lib.
>>
>> Please have a look.
>>
>> Best Regards,
>> Kirill
>>
>> [1] https://patchwork.kernel.org/patch/10250485/
>> [2] https://patchwork.kernel.org/patch/10230611/
>>
>> Kirill Marinushkin (2):
>> ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
>> ASoC: topology: Add missing clock gating parameter when parsing
>> hw_configs
>>
>> include/uapi/sound/asoc.h | 23 ++++++++++++++++++++---
>> sound/soc/soc-topology.c | 19 ++++++++++++++-----
>> 2 files changed, 34 insertions(+), 8 deletions(-)
>>
next prev parent reply other threads:[~2018-04-03 0:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 20:56 [PATCH v3 0/2] ASoC: topology: Improve parsing hw_configs Kirill Marinushkin
2018-03-27 20:56 ` [PATCH v3 1/2] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() Kirill Marinushkin
2018-03-27 20:56 ` [PATCH v3 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs Kirill Marinushkin
2018-04-16 17:15 ` Applied "ASoC: topology: Add missing clock gating parameter when parsing hw_configs" to the asoc tree Mark Brown
2018-04-16 17:15 ` Mark Brown
2018-03-27 21:00 ` [PATCH, alsa-lib, v3 0/2] alsa-lib: ASoC: topology: Improve parsing hw_configs Kirill Marinushkin
2018-03-27 21:00 ` [PATCH, alsa-lib, v3 1/2] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() Kirill Marinushkin
2018-03-27 21:00 ` Kirill Marinushkin
2018-03-27 21:00 ` [PATCH, alsa-lib, v3 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs Kirill Marinushkin
2018-04-02 21:17 ` [PATCH v3 0/2] ASoC: topology: Improve " Kirill Marinushkin
2018-04-03 0:57 ` Pierre-Louis Bossart [this message]
2018-04-03 5:15 ` Kirill Marinushkin
2018-04-03 5:15 ` Kirill Marinushkin
2018-04-03 17:21 ` [alsa-devel] " Pierre-Louis Bossart
2018-04-03 18:16 ` Kirill Marinushkin
2018-04-03 19:19 ` Pierre-Louis Bossart
2018-04-03 19:19 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461bbabf-7c36-1361-8f66-5abbe3c7f4d8@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=k.marinushkin@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=xiuli.pan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.