From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Stancek Date: Thu, 27 Apr 2017 04:52:40 -0400 (EDT) Subject: [LTP] LTP release In-Reply-To: References: <20170424162534.GA13616@rei.lan> <20170426090805.GA16024@rei.lan> <1148677109.2856278.1493211577427.JavaMail.zimbra@redhat.com> Message-ID: <462785677.3504954.1493283160489.JavaMail.zimbra@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it ----- Original Message ----- > On Wed, Apr 26, 2017 at 8:59 PM, Jan Stancek wrote: > > > > > > ----- Original Message ----- > >> Hi! > >> > > It's about a time we should prepare for another release, hence as > >> > > usuall, lets start with pointing out any patches that should be part > >> > > of > >> > > it and I would like to start with pre-release testing at the end of > >> > > this > >> > > week. Does that sound OK to everyone? > >> > > >> > ioctl06 always failed on aarch64(others PASS) with upstream > >> > kernel-4.11-rc[1-7]. Not sure if it is a bug or not, since i'm still > >> > on debugging way. Just report here to let you know this. > > > > I'm seeing it fail on ppc as well (64k pages), with older RHEL7 kernels: > > > >> Looks like the value is rounded to be multiple of 128, that may be just > >> intentional limitation, but we should better check with the kernel > >> source or ask kernel devs. > > > > block/ioctl.c: > > case BLKRASET: > > case BLKFRASET: > > if(!capable(CAP_SYS_ADMIN)) > > return -EACCES; > > bdev->bd_bdi->ra_pages = (arg * 512) / PAGE_SIZE; > > return 0; > > > > > how about makes change as: > > --- a/testcases/kernel/syscalls/ioctl/ioctl06.c > +++ b/testcases/kernel/syscalls/ioctl/ioctl06.c > @@ -31,12 +31,13 @@ static int fd; > static void verify_ioctl(void) > { > unsigned long ra, rab, rao; > + unsigned long ra_shift = getpagesize() / 512; This is just "8" for 4k pages. I'd go with increase by 512 bytes - which is also what blockdev(8) allows via --setra. Regards, Jan