From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB27C4332F for ; Fri, 16 Dec 2022 12:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbiLPMR6 (ORCPT ); Fri, 16 Dec 2022 07:17:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiLPMR5 (ORCPT ); Fri, 16 Dec 2022 07:17:57 -0500 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66F1C11A15 for ; Fri, 16 Dec 2022 04:17:55 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 25A008520E; Fri, 16 Dec 2022 13:17:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671193073; bh=CXkNj0PgItDBBzxg8pOOshATJqBaL0siZnYUH5SZU6s=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=uXMB7KtgR9REHP4KYSXzwVS7pkBSlqReJW9WWoolcfpfuswbfv+tsSVi9gUz8GHFl xRpjDXiIUX8LqhYRLgUY+U+hyfNTmrtwOUedLjIg3AvjxM8lO+XSe15GQYUldE8BTc YC8e8G7WbSdJosrluegzfmbnhGT4kprwKe1EShPyxZL1rFOocxOyh+LeS2aqHFmOJz xIb0s2DT5gapAt/PYJSmS6Y/PaZ8MWGii/Tf6PS/ywSfaYXMOzVlh1p/CqNpR1NGAt EOSGLTG85ThhPMojV5z1r0i1sjBwmpwxsM6VFop1p9mW5CrBgUrgoSV12jE5lrdMHb zitSI1sQEEURQ== Message-ID: <462b692b-a5b3-ac58-6ba2-732e27db609e@denx.de> Date: Fri, 16 Dec 2022 13:17:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 From: Marek Vasut Subject: Re: [PATCH 1/4] dt-bindings: arm: Split i.MX8M Mini Toradex Verdin based boards To: Francesco Dolcini Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Francesco Dolcini , Krzysztof Kozlowski , Marcel Ziswiler , Peng Fan , Rob Herring , Shawn Guo , NXP Linux Team , devicetree@vger.kernel.org References: <20221215232137.144256-1-marex@denx.de> <3145f5ee-5e25-c105-5aa9-6c76dc531173@denx.de> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/16/22 12:56, Francesco Dolcini wrote: > On Fri, Dec 16, 2022 at 12:43:35PM +0100, Marek Vasut wrote: >> On 12/16/22 08:18, Francesco Dolcini wrote: >>> Hello Marek >> >> Hi, >> >>> On Fri, Dec 16, 2022 at 12:21:34AM +0100, Marek Vasut wrote: >>>> The Toradex Verdin based boards have compatible string in the form: >>>> "vendor,custom-board", "toradex,som", "fsl,soc" >>>> Split the binding entry so this triplet can be matched on. >>>> >>>> Signed-off-by: Marek Vasut >>>> --- >>>> Cc: Fabio Estevam >>>> Cc: Francesco Dolcini >>>> Cc: Krzysztof Kozlowski >>>> Cc: Marcel Ziswiler >>>> Cc: Peng Fan >>>> Cc: Rob Herring >>>> Cc: Shawn Guo >>>> Cc: NXP Linux Team >>>> Cc: devicetree@vger.kernel.org >>>> To: linux-arm-kernel@lists.infradead.org >>>> --- >>>> Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> index 05b5276a0e14c..8dda0e25b99e4 100644 >>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> @@ -830,7 +830,6 @@ properties: >>>> - innocomm,wb15-evk # i.MX8MM Innocomm EVK board with WB15 SoM >>>> - kontron,imx8mm-sl # i.MX8MM Kontron SL (N801X) SOM >>>> - kontron,imx8mm-osm-s # i.MX8MM Kontron OSM-S (N802X) SOM >>>> - - menlo,mx8menlo # i.MX8MM Menlo board with Verdin SoM >>>> - toradex,verdin-imx8mm # Verdin iMX8M Mini Modules >>>> - toradex,verdin-imx8mm-nonwifi # Verdin iMX8M Mini Modules without Wi-Fi / BT >>>> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules >>>> @@ -838,6 +837,12 @@ properties: >>>> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board >>>> - const: fsl,imx8mm >>>> + - description: Verdin iMX8M Mini Module based Boards >>> I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong? >> >> Partly wrong, look at 4/4 patch in this series for how this would grow once >> more boards based on the Verdin SoM would be added. The first -const: would >> turn into enum, the remaining two -const: would remain (different carrier >> board, same SoM, same SoC). > > Shouldn't you than add it to existing `Toradex Boards with Verdin iMX8M Mini Modules` > one as a new entry to the existing enum? Maybe the current name is not > ideal if we do something like that and should become `Boards using > Toradex Verdin iMX8M Mini Modules` if we add menlo to it ? I should, I missed that, will be fixed in V2, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C818C4332F for ; Fri, 16 Dec 2022 12:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+r2LyAF+CffYdOmB2n7WRQvETpH8D+xUBMa4OOf0YVY=; b=1fETsiGyBQWROp 4yAJfc4M2ihvJjri6FkyJtwtlO23ZZtF4I7lthevDtDQbO0nIdIHILUizoQnBDwYi6Fnez6WVe/Qu 5/xrSzbVyiWKO6/lPqFc2AWHdjsNGGzdEggtw11HHnOeMdMv3kvaY3Id8qsucvgUy4lF7wC7hoSn0 L0jxZtQ1Pm1z4N/fsDZoAXdSCmQdjQDm6U2/ekX5rhlpX3+NI3oUd2/aeWiujsIt3I1J35TVM+1Y4 MOaFH9Gsb7Qut+pe1LzZf/CHj0sCl43fFlPlI4pf2MaWPr1ZPyuTifyH/PzKVqNdTn4kGtW+FjxWR QijN/fJwfJ39hyANXu5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p69f5-00EqmM-1j; Fri, 16 Dec 2022 12:17:59 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p69f2-00Eqkd-9h for linux-arm-kernel@lists.infradead.org; Fri, 16 Dec 2022 12:17:58 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 25A008520E; Fri, 16 Dec 2022 13:17:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671193073; bh=CXkNj0PgItDBBzxg8pOOshATJqBaL0siZnYUH5SZU6s=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=uXMB7KtgR9REHP4KYSXzwVS7pkBSlqReJW9WWoolcfpfuswbfv+tsSVi9gUz8GHFl xRpjDXiIUX8LqhYRLgUY+U+hyfNTmrtwOUedLjIg3AvjxM8lO+XSe15GQYUldE8BTc YC8e8G7WbSdJosrluegzfmbnhGT4kprwKe1EShPyxZL1rFOocxOyh+LeS2aqHFmOJz xIb0s2DT5gapAt/PYJSmS6Y/PaZ8MWGii/Tf6PS/ywSfaYXMOzVlh1p/CqNpR1NGAt EOSGLTG85ThhPMojV5z1r0i1sjBwmpwxsM6VFop1p9mW5CrBgUrgoSV12jE5lrdMHb zitSI1sQEEURQ== Message-ID: <462b692b-a5b3-ac58-6ba2-732e27db609e@denx.de> Date: Fri, 16 Dec 2022 13:17:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 From: Marek Vasut Subject: Re: [PATCH 1/4] dt-bindings: arm: Split i.MX8M Mini Toradex Verdin based boards To: Francesco Dolcini Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Francesco Dolcini , Krzysztof Kozlowski , Marcel Ziswiler , Peng Fan , Rob Herring , Shawn Guo , NXP Linux Team , devicetree@vger.kernel.org References: <20221215232137.144256-1-marex@denx.de> <3145f5ee-5e25-c105-5aa9-6c76dc531173@denx.de> Content-Language: en-US In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221216_041756_757253_FFAF2AD9 X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/16/22 12:56, Francesco Dolcini wrote: > On Fri, Dec 16, 2022 at 12:43:35PM +0100, Marek Vasut wrote: >> On 12/16/22 08:18, Francesco Dolcini wrote: >>> Hello Marek >> >> Hi, >> >>> On Fri, Dec 16, 2022 at 12:21:34AM +0100, Marek Vasut wrote: >>>> The Toradex Verdin based boards have compatible string in the form: >>>> "vendor,custom-board", "toradex,som", "fsl,soc" >>>> Split the binding entry so this triplet can be matched on. >>>> >>>> Signed-off-by: Marek Vasut >>>> --- >>>> Cc: Fabio Estevam >>>> Cc: Francesco Dolcini >>>> Cc: Krzysztof Kozlowski >>>> Cc: Marcel Ziswiler >>>> Cc: Peng Fan >>>> Cc: Rob Herring >>>> Cc: Shawn Guo >>>> Cc: NXP Linux Team >>>> Cc: devicetree@vger.kernel.org >>>> To: linux-arm-kernel@lists.infradead.org >>>> --- >>>> Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> index 05b5276a0e14c..8dda0e25b99e4 100644 >>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> @@ -830,7 +830,6 @@ properties: >>>> - innocomm,wb15-evk # i.MX8MM Innocomm EVK board with WB15 SoM >>>> - kontron,imx8mm-sl # i.MX8MM Kontron SL (N801X) SOM >>>> - kontron,imx8mm-osm-s # i.MX8MM Kontron OSM-S (N802X) SOM >>>> - - menlo,mx8menlo # i.MX8MM Menlo board with Verdin SoM >>>> - toradex,verdin-imx8mm # Verdin iMX8M Mini Modules >>>> - toradex,verdin-imx8mm-nonwifi # Verdin iMX8M Mini Modules without Wi-Fi / BT >>>> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules >>>> @@ -838,6 +837,12 @@ properties: >>>> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board >>>> - const: fsl,imx8mm >>>> + - description: Verdin iMX8M Mini Module based Boards >>> I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong? >> >> Partly wrong, look at 4/4 patch in this series for how this would grow once >> more boards based on the Verdin SoM would be added. The first -const: would >> turn into enum, the remaining two -const: would remain (different carrier >> board, same SoM, same SoC). > > Shouldn't you than add it to existing `Toradex Boards with Verdin iMX8M Mini Modules` > one as a new entry to the existing enum? Maybe the current name is not > ideal if we do something like that and should become `Boards using > Toradex Verdin iMX8M Mini Modules` if we add menlo to it ? I should, I missed that, will be fixed in V2, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel