From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbbJWLqG (ORCPT ); Fri, 23 Oct 2015 07:46:06 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59895 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287AbbJWLqD (ORCPT ); Fri, 23 Oct 2015 07:46:03 -0400 From: Arnd Bergmann To: WEN Pingbo Cc: y2038@lists.linaro.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Date: Fri, 23 Oct 2015 13:45:57 +0200 Message-ID: <4634704.Sh0UHGgRyQ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445599779-11733-1-git-send-email-pingbo.wen@linaro.org> References: <3901659.bcGNtuE6xV@wuerfel> <1445599779-11733-1-git-send-email-pingbo.wen@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:z4zxWBGOcvPbD5b+XTCbwqR/EJ/42kaM6gfz5nPVcdfnndiH2a8 2qQONgtbesUlSFiduxZpSimbKZJ5GOzONx9D3uwgcH8iGN3/uz3+V5NFjJS2FJkWKveKS/C UNGIkVu8YV09ealxvGmksKNRBAO6es+hppNGezy8aiuR4ixz+MaFUVPZJJDoS+rdztu2u9v avb8X/m+j5LtPsuQ1TJnw== X-UI-Out-Filterresults: notjunk:1;V01:K0:I7JVbgyEyck=:qyHvrhg9JGdehnoo+U7K0e OJQikZcEjDd4Mkg6wbpWq8BVr5WkrhJ2vi8KdlwlzXBsYBhGFMR0RRhaysBBwk6rZN2gpClZu 8I7O+nhlLCLgZscH8S71KR5Bu87poifRiR/f7ZwYogtKAeRh4ZvuPcQscnwJtLy3A2WLjVE/T vzdGkOvgH/j6d9un2mxRC9Xr09vcX7hm+9OdApeJ1ChJgU+I8CKperQOTV46BlUXNpjq3PxlM 83FtMDxvc3s5iGAOBAMYkohZPSdN0PomyufYQHlWnlurRge4e+rXcTPMBt9K3BU3HUX//0Eag AAg/edDd3UB8iUFultX4PZ35rUdSLKSwlwVumAMIJ2PrGUaxHVsq86pp2wg1oiF9bJJKdsfG0 IxEsab0Lfdh8PfzN+UHn2Pu7Pxudjy6DNU2SQhbkfwEtI8CE6qPKG9Da4ykQCNeXLmC9/HUo3 ekYzY7NNQjGfGsf7cNofo+psxVAQrYDK6m2jOTNdoWEm286lRN7uAy13qeaVSi+3yI39/0J9q /eTKnnjaMnubVdg6YIJjitHUkjZVB7mEvoHGFpGuGKb6hHQjmxeDzut8sxitfJPczZT8ZW4/7 IAPk0h28Tn6LS69ixRE4Pdy99lRgHxk0Pq49PwS1+FXpuk/GBVf1gV2OnxmImadHoGTcz4PMf 41nAN+Q0NCE6IEaI9XlHY9zbLvtEORIJu6iaPFyCNdqWkDQspbgKAAsASTVFsukCWoXPclg/a VSdu7CQTLNspNCPz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 October 2015 19:29:39 WEN Pingbo wrote: > 1. struct timeval is not y2038 safe, convert it to ktime_t, and there is no need to handle sec and usec separately > > 2. hp_sdc.rtv is only used for time diff, monotonic time is better here > > Signed-off-by: WEN Pingbo > --- > > Version 2: > Using ktime_t instead of struct timespec64 > Version 3: > Commit msg adjustment, and using ktime_to_ns to extract nsecs > The patch looks good now, but the changelog still needs a tiny bit of work. First of all, your line wrapping is off, please start a new line after around 70 characters as you do in an email. Also, we don't normally have enumerated lists in a changelog, just use normal text. The best changelogs typically have three paragraphs: The first paragraph describes what the driver currently does. For really obvious cases, this can be combined with the second paragraph. The second paragraph explains why that is bad. This is where you can mention the monotonic time vs real time issue and say whether we just want the timeval removed to fix the kernel in general or whether this particular driver is broken. The third paragraph explains what the patch does to resolve the issue described in the second one. This is also where you can list other approaches that would have solved the problem, and why you picked on over the others. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Date: Fri, 23 Oct 2015 13:45:57 +0200 Message-ID: <4634704.Sh0UHGgRyQ@wuerfel> References: <3901659.bcGNtuE6xV@wuerfel> <1445599779-11733-1-git-send-email-pingbo.wen@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1445599779-11733-1-git-send-email-pingbo.wen@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: WEN Pingbo Cc: y2038@lists.linaro.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org T24gRnJpZGF5IDIzIE9jdG9iZXIgMjAxNSAxOToyOTozOSBXRU4gUGluZ2JvIHdyb3RlOgo+IDEu IHN0cnVjdCB0aW1ldmFsIGlzIG5vdCB5MjAzOCBzYWZlLCBjb252ZXJ0IGl0IHRvIGt0aW1lX3Qs IGFuZCB0aGVyZSBpcyBubyBuZWVkIHRvIGhhbmRsZSBzZWMgYW5kIHVzZWMgc2VwYXJhdGVseQo+ IAo+IDIuIGhwX3NkYy5ydHYgaXMgb25seSB1c2VkIGZvciB0aW1lIGRpZmYsIG1vbm90b25pYyB0 aW1lIGlzIGJldHRlciBoZXJlCj4gCj4gU2lnbmVkLW9mZi1ieTogV0VOIFBpbmdibyA8cGluZ2Jv LndlbkBsaW5hcm8ub3JnPgo+IC0tLQo+IAo+IFZlcnNpb24gMjoKPiAgICAgICAgIFVzaW5nIGt0 aW1lX3QgaW5zdGVhZCBvZiBzdHJ1Y3QgdGltZXNwZWM2NAo+IFZlcnNpb24gMzoKPiAgICAgICAg IENvbW1pdCBtc2cgYWRqdXN0bWVudCwgYW5kIHVzaW5nIGt0aW1lX3RvX25zIHRvIGV4dHJhY3Qg bnNlY3MgCj4gCgpUaGUgcGF0Y2ggbG9va3MgZ29vZCBub3csIGJ1dCB0aGUgY2hhbmdlbG9nIHN0 aWxsIG5lZWRzIGEgdGlueSBiaXQgb2YKd29yay4gRmlyc3Qgb2YgYWxsLCB5b3VyIGxpbmUgd3Jh cHBpbmcgaXMgb2ZmLCBwbGVhc2Ugc3RhcnQgYSBuZXcgbGluZQphZnRlciBhcm91bmQgNzAgY2hh cmFjdGVycyBhcyB5b3UgZG8gaW4gYW4gZW1haWwuCgpBbHNvLCB3ZSBkb24ndCBub3JtYWxseSBo YXZlIGVudW1lcmF0ZWQgbGlzdHMgaW4gYSBjaGFuZ2Vsb2csIGp1c3QgdXNlCm5vcm1hbCB0ZXh0 LiBUaGUgYmVzdCBjaGFuZ2Vsb2dzIHR5cGljYWxseSBoYXZlIHRocmVlIHBhcmFncmFwaHM6CgpU aGUgZmlyc3QgcGFyYWdyYXBoIGRlc2NyaWJlcyB3aGF0IHRoZSBkcml2ZXIgY3VycmVudGx5IGRv ZXMuIEZvciByZWFsbHkKb2J2aW91cyBjYXNlcywgdGhpcyBjYW4gYmUgY29tYmluZWQgd2l0aCB0 aGUgc2Vjb25kIHBhcmFncmFwaC4KClRoZSBzZWNvbmQgcGFyYWdyYXBoIGV4cGxhaW5zIHdoeSB0 aGF0IGlzIGJhZC4gVGhpcyBpcyB3aGVyZSB5b3UgY2FuCm1lbnRpb24gdGhlIG1vbm90b25pYyB0 aW1lIHZzIHJlYWwgdGltZSBpc3N1ZSBhbmQgc2F5IHdoZXRoZXIgd2UKanVzdCB3YW50IHRoZSB0 aW1ldmFsIHJlbW92ZWQgdG8gZml4IHRoZSBrZXJuZWwgaW4gZ2VuZXJhbCBvciB3aGV0aGVyCnRo aXMgcGFydGljdWxhciBkcml2ZXIgaXMgYnJva2VuLgoKVGhlIHRoaXJkIHBhcmFncmFwaCBleHBs YWlucyB3aGF0IHRoZSBwYXRjaCBkb2VzIHRvIHJlc29sdmUgdGhlIGlzc3VlCmRlc2NyaWJlZCBp biB0aGUgc2Vjb25kIG9uZS4gVGhpcyBpcyBhbHNvIHdoZXJlIHlvdSBjYW4gbGlzdCBvdGhlcgph cHByb2FjaGVzIHRoYXQgd291bGQgaGF2ZSBzb2x2ZWQgdGhlIHByb2JsZW0sIGFuZCB3aHkgeW91 IHBpY2tlZCBvbgpvdmVyIHRoZSBvdGhlcnMuCgoJQXJuZApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpZMjAzOCBtYWlsaW5nIGxpc3QKWTIwMzhAbGlzdHMu bGluYXJvLm9yZwpodHRwczovL2xpc3RzLmxpbmFyby5vcmcvbWFpbG1hbi9saXN0aW5mby95MjAz OAo=