From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tolunay Orkun Date: Wed, 02 May 2007 16:50:48 -0500 Subject: [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info In-Reply-To: <20070424102648.GA18388@michl.2n.cz> References: <20070323115235.GA4857@michl.2n.cz> <20070424102648.GA18388@michl.2n.cz> Message-ID: <463907B8.3060104@orkun.us> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Ladislav Michl wrote: > On Fri, Mar 23, 2007 at 12:52:35PM +0100, Ladislav Michl wrote: >> Hi, >> >> cfi_flash.c is providing functionality already present elsewhere as >> addr2info (in common/flash.c). Lets save few bytes by using it. > > Tolunay, any comments? I am all for removing redundant code. I looked at your patch when you submitted but did not carefully review yet. I feel like the function should reside inside the flash driver where it is most often used and flash driver should export it. Tolunay