From: Qian Cai <cai@lca.pw>
To: Marco Elver <elver@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: [PATCH] mm/swap: annotate data races for lru_rotate_pvecs
Date: Fri, 28 Feb 2020 06:30:26 -0500 [thread overview]
Message-ID: <463BBB2A-8F9A-4CF1-80AE-677ACD21A3C6@lca.pw> (raw)
> On Feb 28, 2020, at 5:49 AM, Marco Elver <elver@google.com> wrote:
>
> Note that, the fact that the writer has local interrupts disabled for
> the write is irrelevant because it's the interrupt that triggered
> while the read was happening that led to the concurrent write.
I was just to explain that concurrent writers are rather unlikely as people may ask.
>
> I assume you ran this with CONFIG_KCSAN_INTERRUPT_WATCHER=y? The
> option is disabled by default (see its help-text). I don't know if we
> want to deal with data races due to interrupts right now, especially
> those that just result in 'data_race' annotations. Thoughts?
Yes, I somehow got quite a bit clean runs lately thanks to the fix/annotations efforts for the last a few weeks (still struggling with the flags things a bit), so I am naturally expanding the testing coverage here.
Right now the bottleneck is rather some subsystem maintainers are not so keen to deal with data races (looking forward to seeing more education opportunities for all), but the MM subsystem is not one of them.
next reply other threads:[~2020-02-28 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 11:30 Qian Cai [this message]
2020-02-28 12:43 ` [PATCH] mm/swap: annotate data races for lru_rotate_pvecs Marco Elver
2020-02-28 12:43 ` Marco Elver
-- strict thread matches above, loose matches on Subject: below --
2020-02-28 4:40 Qian Cai
2020-02-28 10:49 ` Marco Elver
2020-02-28 10:49 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463BBB2A-8F9A-4CF1-80AE-677ACD21A3C6@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.