From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] nvme: Don't suspend admin queue that wasn't created
Date: Wed, 7 Sep 2016 08:53:38 -0600 [thread overview]
Message-ID: <464cc78c-1409-3d88-508e-d47fb0f5cfbe@fb.com> (raw)
In-Reply-To: <1473194353-2472-1-git-send-email-krisman@linux.vnet.ibm.com>
On 09/06/2016 02:39 PM, Gabriel Krisman Bertazi wrote:
> This fixes a regression in my previous commit c21377f8366c ("nvme:
> Suspend all queues before deletion"), which provoked an Oops in the
> removal path when removing a device that became IO incapable very early
> at probe (i.e. after a failed EEH recovery).
>
> Turns out, if the error occurred very early at the probe path, before
> even configuring the admin queue, we might try to suspend the
> uninitialized admin queue, accessing bad memory.
>
> Fixes: c21377f8366c ("nvme: Suspend all queues before deletion")
> Signed-off-by: Gabriel Krisman Bertazi <krisman at linux.vnet.ibm.com>
Applied for 4.8, thanks.
--
Jens Axboe
prev parent reply other threads:[~2016-09-07 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 20:39 [PATCH] nvme: Don't suspend admin queue that wasn't created Gabriel Krisman Bertazi
2016-09-07 0:07 ` J Freyensee
2016-09-07 14:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464cc78c-1409-3d88-508e-d47fb0f5cfbe@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.