From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3F62C433F5 for ; Fri, 20 May 2022 06:28:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2AD7683ED5; Fri, 20 May 2022 08:28:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="NpomR4do"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7389C83ED5; Fri, 20 May 2022 08:28:37 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e89::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4E66383EDC for ; Fri, 20 May 2022 08:28:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iV4tPIEGkz3lw3jsmvYn6IDYCcm3rH03WWV5lurKzdxboaBrYtvS5TynzUHoRBi8XEHU41opMcUwdd60hgDv/jn2LOv0aSLpGbEYr304g66fqA+MWhs1oxTIMCgI4H8PWoxIKkVS3plcxmbnE7w/JPqtTyRtN+L/a149a7HM91QHWHog3S+bY57TP8froNqbdw9WhoEvZ41NzWpaSDLeJkEuw2rIhYWiRRmkIKq0WInkG9It/7tzUseTSHiw4J6U7INxx7uQVF8miIxaWz8FkxewdnKyL00QwV6qQ9/gXor6lrqlApKd186Vb0FFZKmOlaojk+FW/3Be166KUrgq+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UE/tEYuR/xjxMaubhK0DHB79xOEO4wTak/u0o5RB+dk=; b=V2Y3H04wTE7orH2L2uOflDsSO7teHfoNKYWfnG8GGSlAqSlfzhEZHBxt4higt2rVBU4CECmZVWfDFr/8ILFOO9yn79mNL2D+nppCsIjNSKwa90RhUAk4egKFbIrfSwUtbtKT0hJEh/Z2Adg3RlOC3C58k4kJu8icVo/iFk8Q0NeQ9BX6cEi93+JEDQwimGJEQPV8L6Naq711L8rS7Nm5v3S5Yg61yOGvg49bpHM1j0n70jk9Houe38+cmThdp7PtyYzpooBBfI1kD+QqEO21EK0lMHwYbDRjFf0r1ik6Y+eRS5FNXsAmo0SU00sxCNoP8dJXNj/Pk5bnLj3Nt/Zj/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=denx.de smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UE/tEYuR/xjxMaubhK0DHB79xOEO4wTak/u0o5RB+dk=; b=NpomR4doRguszs4jlwwVPks8U45QGGNXQ23cDE11zbbhzbOt2lvopJ5Sz+Wux25IcWZnB/jUFcDYO24OoR8LR9yqOPxhrKlAGZnfRxcphHTA4NUhUNCQZgY2J8r+XbHWfaSfConhNBPKU2R/cCynnlGUWJD/ZdYRa2CusO7H694= Received: from BN9PR03CA0176.namprd03.prod.outlook.com (2603:10b6:408:f4::31) by PH0PR02MB7832.namprd02.prod.outlook.com (2603:10b6:510:57::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 20 May 2022 06:28:29 +0000 Received: from BN1NAM02FT026.eop-nam02.prod.protection.outlook.com (2603:10b6:408:f4:cafe::3f) by BN9PR03CA0176.outlook.office365.com (2603:10b6:408:f4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17 via Frontend Transport; Fri, 20 May 2022 06:28:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT026.mail.protection.outlook.com (10.13.2.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 06:28:28 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 19 May 2022 23:28:24 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 19 May 2022 23:28:24 -0700 Envelope-to: marex@denx.de, u-boot@lists.denx.de Received: from [10.254.241.50] (port=55800) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nrw7c-0006pD-5d; Thu, 19 May 2022 23:28:24 -0700 Message-ID: <465050ff-bb8d-3dac-3010-5d95840a6f32@xilinx.com> Date: Fri, 20 May 2022 08:28:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] usb: dwc3: Fix support for usb3-phy PHY configuration Content-Language: en-US To: Marek Vasut , CC: Michal Simek References: <20220519210319.256526-1-marex@denx.de> From: Michal Simek In-Reply-To: <20220519210319.256526-1-marex@denx.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42a3d4ea-2f82-4f9e-f0e3-08da3a29f39e X-MS-TrafficTypeDiagnostic: PH0PR02MB7832:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7DFoY5VUqp4gpsZPjlJKknU9qgSSnPcFTUtm6qo2oX2nffRmJL1bRS42JinbBx531zGph04jfOWClkjqEbWYb0VnMT8uiN9rhiRg5sacpshdnqRHQHt6grUDRReeHsXWDO0v/9njcUp7hu5GcOfnnSwWxiMc46OU3ewLVNxNYnqunLzlzccgBmNoJsNCevOdi7n/vx70LOjbifoCkL96827cYXAEUVDVYkHcByvBoe21w8ZzBmxnL+Cai0EDkSS6QwA3KytCtTV09ZDKtZHaw3sSw380Q2mKqExtZyx0rRnI3IyVWxOmnkdI+GGLn+PlJurZhnqaC5tifxiniPSpz05Um/CODob87NF2LyPGHQjtZ5h/GjGUkq1PaU64MgqTBjKdq0aIwpEtjEwI8em4jB77Iun8cezm1HeUOcQPGTC00krusdD4BAW0twsMhBj1UoEi1+GlvHDz5gLuESH4ccZhCW1LsyVVR3YI8ALh0/krly1gH2RI70ji09T8lrqRc8FytvoOQ1YmF5n9Qwb4Lzag8Gq8jkRj4DFhBBgbyz8FH1+qoG+2SEtNHvSnwWBRfrUyl2/bbKQBkfVmq1U+DKJW8dr1PPnk65JnbXPnwUiArMq89f/kF60HSgT3gEmlmDz5AvT5Z70PRaZL6z+ivx/1Mteqc6O9HaBqJf2hy7OJQT1s5m/MXwbDDiok8HH1RR+5cg+ycHU6kJlP3q+n5H8azUrzqinfhKEJRKx5mydHuu2+9v0t1lDE5pRQ+vEXBi5mkieZMea8VcXS9PT/9A7xqa/8Zgc01GfJ8CCa+1lpAV2dUTkfCJc/u+qCkwB7UhRP8I+Kaluxi4Ec/35WMRGlNSGoijC9u9pq1vicFNo= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(508600001)(426003)(70206006)(966005)(47076005)(31686004)(9786002)(8936002)(70586007)(44832011)(336012)(7636003)(53546011)(5660300002)(2906002)(8676002)(4326008)(83380400001)(2616005)(82310400005)(40460700003)(186003)(356005)(107886003)(31696002)(316002)(36860700001)(36756003)(110136005)(26005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 06:28:28.0290 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42a3d4ea-2f82-4f9e-f0e3-08da3a29f39e X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT026.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7832 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 5/19/22 23:03, Marek Vasut wrote: > The dev_read_stringlist_search() in generic_phy_get_by_name() > returns -ENODATA in case of missing "phy-names", which is the > case on everything except ZynqMP. Handle this -ENODATA instead > of failing outright, which fixes the glue on everything else. > > Fixes: 142d50fbce7 ("usb: dwc3: Add support for usb3-phy PHY configuration") > Signed-off-by: Marek Vasut > Cc: Michal Simek > --- > drivers/usb/dwc3/dwc3-generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c > index 6e1a1d066b4..9608c5c599a 100644 > --- a/drivers/usb/dwc3/dwc3-generic.c > +++ b/drivers/usb/dwc3/dwc3-generic.c > @@ -468,7 +468,7 @@ static int dwc3_glue_probe(struct udevice *dev) > ret = generic_phy_init(&phy); > if (ret) > return ret; > - } else if (ret != -ENOENT) { > + } else if (ret != -ENOENT && ret != -ENODATA) { > debug("could not get phy (err %d)\n", ret); > return ret; > } Is already handle by one of these in queue. https://lore.kernel.org/all/c5a71c30-e55d-c8ab-d372-e5aaa859cf2a@siemens.com/ https://lore.kernel.org/all/360eefb2-b835-840e-8513-6e9e35a002ec@xilinx.com Thanks, Michal