All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
	kyle.meyer@hpe.com
Cc: Kyle Meyer <kyle.meyer@hpe.com>
Subject: Re: [PATCH] acpi-cpufreq: Skip initialization if a cpufreq driver exists
Date: Fri, 21 May 2021 15:01:02 +0200	[thread overview]
Message-ID: <4656572.31r3eYUQgx@kreacher> (raw)
In-Reply-To: <20210518193455.192796-1-kyle.meyer@hpe.com>

On Tuesday, May 18, 2021 9:34:55 PM CEST kyle.meyer@hpe.com wrote:
> From: Kyle Meyer <kyle.meyer@hpe.com>
> 
> Revert part of commit 75c0758137c7a
> ("acpi-cpufreq: Fail initialization if driver cannot be registered").
> 
> acpi-cpufreq is mutually exclusive with intel_pstate, however,
> acpi-cpufreq is loaded multiple times during startup while intel_pstate is
> enabled. On systems using systemd the kernel triggers one uevent for each
> device as a result of systemd-udev-trigger.service. The service exists to
> retrigger all devices as uevents sent by the kernel before systemd-udevd
> is running are missed. The delay caused by systemd-udevd repeatedly loading
> the driver, getting a fail return, and unloading the driver twice per
> logical CPU has a significant impact on the startup time, and can cause
> some devices to be unavailable after reaching the root login prompt.
> 
> Load the driver once but skip initialization if a cpufreq driver exists by
> changing the return value of cpufreq_get_current_driver() from -EEXIST to
> 0.
> 
> Signed-off-by: Kyle Meyer <kyle.meyer@hpe.com>
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 7e7450453714..e79a945369d1 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -1003,7 +1003,7 @@ static int __init acpi_cpufreq_init(void)
>  
>  	/* don't keep reloading if cpufreq_driver exists */
>  	if (cpufreq_get_current_driver())
> -		return -EEXIST;
> +		return 0;
>  
>  	pr_debug("%s\n", __func__);
>  
> 

Please resend this with CCs to linux-pm@vger.kernel.org and linux-acpi@vegr.kernel.org.

Thanks!





  reply	other threads:[~2021-05-21 13:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 19:34 kyle.meyer
2021-05-21 13:01 ` Rafael J. Wysocki [this message]
2021-05-21 22:19 Kyle Meyer
2021-05-21 22:19 ` Kyle Meyer
2021-05-24 14:16 ` Rafael J. Wysocki
2021-06-07  7:25   ` Viresh Kumar
2021-06-07 11:02     ` Rafael J. Wysocki
2021-06-07 11:14       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4656572.31r3eYUQgx@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=kyle.meyer@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    --subject='Re: [PATCH] acpi-cpufreq: Skip initialization if a cpufreq driver exists' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.