From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Alvin" Subject: RE: [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling Date: Fri, 12 Sep 2014 02:27:33 +0000 Message-ID: <4656BEB6164FC34F8171C6538F1A595B2E990CFF@SHSMSX101.ccr.corp.intel.com> References: <1410286081-16653-1-git-send-email-alvin.chen@intel.com> <1410286081-16653-5-git-send-email-alvin.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from mga11.intel.com ([192.55.52.93]:54682 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbaILC21 convert rfc822-to-8bit (ORCPT ); Thu, 11 Sep 2014 22:28:27 -0400 In-Reply-To: Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: atull Cc: Linus Walleij , Alexandre Courbot , Grant Likely , Rob Herring , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "Ong, Boon Leong" , "Kweh, Hock Leong" , Darren Hart , Sebastian Andrzej Siewior , "Westerberg, Mika" , "Shevchenko, Andriy" , Arnd Bergmann > On Tue, 9 Sep 2014, Weike Chen wrote: > > > > > struct dwapb_gpio; > > +struct dwapb_context; > > > > struct dwapb_gpio_port { > > struct bgpio_chip bgc; > > bool is_registered; > > struct dwapb_gpio *gpio; > > + struct dwapb_context *ctx; > > Alvin, > > Will this build if CONFIG_PM_SLEEP is not defined? Actually, PM_SLEEP is always set as 'y' in 'kerne/power/Kconfig'. But I manually change it to 'n', this module can be compiled correctly. You may be concern with 'ctx', and you can see 'ctx' accessing is always in CONFIG_PM_SLEEP. > Alan