All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
To: Samuel Holland <samuel@sholland.org>,
	u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
	Andre Przywara <andre.przywara@arm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Icenowy Zheng <icenowy@aosc.io>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Peng Fan <peng.fan@nxp.com>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 1/4] sunxi: gpio: Return void from setter functions
Date: Fri, 5 Nov 2021 14:53:43 +0100	[thread overview]
Message-ID: <465e51fb-2ab0-c4aa-511c-ab8c8f9099cb@canonical.com> (raw)
In-Reply-To: <20211021045258.30757-2-samuel@sholland.org>

On 10/21/21 06:52, Samuel Holland wrote:
> The return values of these functions are always zero, and they are
> never checked. Since they are not needed, remove them.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>


  reply	other threads:[~2021-11-05 13:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  4:52 [PATCH 0/4] gpio: sunxi: Handle pin configuration flags Samuel Holland
2021-10-21  4:52 ` [PATCH 1/4] sunxi: gpio: Return void from setter functions Samuel Holland
2021-11-05 13:53   ` Heinrich Schuchardt [this message]
2021-10-21  4:52 ` [PATCH 2/4] sunxi: gpio: Add per-bank drive and pull setters Samuel Holland
2021-11-05 14:12   ` Heinrich Schuchardt
2022-01-30  1:11     ` Andre Przywara
2021-10-21  4:52 ` [PATCH 3/4] gpio: sunxi: Implement .set_flags Samuel Holland
2021-10-24 19:53   ` Simon Glass
2021-11-05 14:43   ` Heinrich Schuchardt
2021-11-05 21:46     ` Samuel Holland
2022-01-30  1:18       ` Andre Przywara
2021-10-21  4:52 ` [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up Samuel Holland
2021-10-21 21:58   ` Jaehoon Chung
2021-10-22  9:00     ` Andre Przywara
2021-10-22 10:10       ` Jaehoon Chung
2021-10-22 10:36         ` Andre Przywara
2021-11-05 15:52   ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465e51fb-2ab0-c4aa-511c-ab8c8f9099cb@canonical.com \
    --to=heinrich.schuchardt@canonical.com \
    --cc=andre.przywara@arm.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=icenowy@aosc.io \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=samuel@sholland.org \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.