From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: add Bus log type
Date: Mon, 19 Jun 2017 22:54:57 +0200
Message-ID: <4669455.PggrvpOhcS@xps>
References: <1495604325-15743-1-git-send-email-shreyansh.jain@nxp.com>
 <943050b9-9e57-970e-cbef-01afcdb9e3ff@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E84B8374
 for <dev@dpdk.org>; Mon, 19 Jun 2017 22:54:58 +0200 (CEST)
In-Reply-To: <943050b9-9e57-970e-cbef-01afcdb9e3ff@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/06/2017 13:03, Shreyansh Jain:
> > --- a/lib/librte_eal/common/include/rte_log.h
> > +++ b/lib/librte_eal/common/include/rte_log.h
> > @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
> >   #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
> >   #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
> >   #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
> > +#define RTE_LOGTYPE_BUS       20 /**< Log related to Bus. */
> 
> Just wanted to ping - is there something wrong/unacceptable about this?

Sorry for not replying before.

The strange thing is that it is not used.
At least, the existing bus logs should be converted.
I've spotted few lines in drivers/bus/fslmc/.

And more importantly, we must switch to the new dynamic types
using rte_log_register().