From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/7] net/qede: refactor filtering code
Date: Mon, 12 Dec 2016 17:53:57 +0000
Message-ID: <466b1cf9-78b0-4449-68a0-f5a0e20dbb5a@intel.com>
References: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com>
 <1480733039-13046-2-git-send-email-harish.patil@qlogic.com>
 <f114b64c-0a63-736a-98a6-b8cae747f21a@intel.com>
 <D4741EDB.C012D%Harish.Patil@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>
To: Harish Patil <harish.patil@qlogic.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id AD5F6370
 for <dev@dpdk.org>; Mon, 12 Dec 2016 18:53:59 +0100 (CET)
In-Reply-To: <D4741EDB.C012D%Harish.Patil@cavium.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/12/2016 5:36 PM, Harish Patil wrote:
> 
>> On 12/3/2016 2:43 AM, Harish Patil wrote:
>>> The filter_config in qed_eth_ops_pass is a wrapper call driving all the
>>> filtering configuration. This requires defining multiple structures and
>>> passing different function arguments for each filter type which is
>>> unnecessary. So as part of this refactoring we remove filter_config from
>>> qed_eth_ops_pass and invoke base apis directly. Another change is to
>>> use a singly list for unicast/multicast macs and thereby prevent
>>> duplicate
>>
>> singly linked list?
> 
> Yes. Two lists to track unicast and multicast mac entries:
> +       SLIST_HEAD(mc_list_head, qede_mcast_entry) mc_list_head;
> 
> +       SLIST_HEAD(uc_list_head, qede_ucast_entry) uc_list_head;
> 
> 
> 
>>
>>> entries.
>>>
>>> This change is primarily intended to support future tunneling support
>>> which makes use of existing L2 filtering/classifications.
>>>
>>> Fixes: 2ea6f76a ("qede: add core driver")
>>
>> What is fixed in this patch, isn't it a refactor?
> 
> The fix part is to make use of the newly added lists and prevent duplicate
> mac filters.
> Before that there were no checks. Other than that its refactoring to
> mainly invoke direct base APIs.

So this is not fixing any defect in driver, so I believe Fixes tag can
be removed. This tag is mainly useful to pick commits for stable trees.

> 
>>
>> btw, all Fixes formats are wrong in the patchset, can you please use the
>> git alias provided:
>> http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
>>
>>>
>>> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
>>> ---
>> <...>
>>
> 
>