All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>
Subject: [PATCH net-next v2 12/18] net: stmmac: dwmac1000: Fix Hash Filter
Date: Fri, 24 May 2019 10:20:20 +0200	[thread overview]
Message-ID: <468493e3b5e7ea96a0bfa14b36d3c9bd7a47b65d.1558685828.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1558685827.git.joabreu@synopsys.com>
In-Reply-To: <cover.1558685827.git.joabreu@synopsys.com>

In order for hash filter to work we need to set the HPF bit.

Found out while running stmmac selftests.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
index 8ca73bd15e07..bc91af6c01b6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
@@ -198,6 +198,7 @@ static void dwmac1000_set_filter(struct mac_device_info *hw,
 		}
 	}
 
+	value |= GMAC_FRAME_FILTER_HPF;
 	dwmac1000_set_mchash(ioaddr, mc_filter, mcbitslog2);
 
 	/* Handle multiple unicast addresses (perfect filtering) */
-- 
2.7.4


  parent reply	other threads:[~2019-05-24  8:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  8:20 [PATCH net-next v2 00/18] net: stmmac: Improvements and Selftests Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 01/18] net: stmmac: Add MAC loopback callback to HWIF Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 02/18] net: stmmac: dwmac100: Add MAC loopback support Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 03/18] net: stmmac: dwmac1000: " Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 04/18] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 05/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 06/18] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 07/18] net: stmmac: Switch MMC functions to HWIF callbacks Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 08/18] net: stmmac: dwmac1000: Also pass control frames while in promisc mode Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 09/18] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 10/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 11/18] net: stmmac: Introduce selftests support Jose Abreu
2019-05-24  8:20 ` Jose Abreu [this message]
2019-05-24  8:20 ` [PATCH net-next v2 13/18] net: stmmac: dwmac1000: Clear unused address entries Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 14/18] net: stmmac: dwmac4/5: Fix Hash Filter Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 15/18] net: stmmac: dwmac4/5: Do not disable whole RX in dma_stop_rx() Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 16/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 17/18] net: stmmac: dwmac4/5: Clear unused address entries Jose Abreu
2019-05-24  8:20 ` [PATCH net-next v2 18/18] net: stmmac: Prevent missing interrupts when running NAPI Jose Abreu
2019-05-24 20:46 ` [PATCH net-next v2 00/18] net: stmmac: Improvements and Selftests David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468493e3b5e7ea96a0bfa14b36d3c9bd7a47b65d.1558685828.git.joabreu@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=alexandre.torgue@st.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --subject='Re: [PATCH net-next v2 12/18] net: stmmac: dwmac1000: Fix Hash Filter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.