From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61003C6FD19 for ; Thu, 16 Mar 2023 13:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjCPNLy (ORCPT ); Thu, 16 Mar 2023 09:11:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbjCPNLx (ORCPT ); Thu, 16 Mar 2023 09:11:53 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE9E3BDD3B; Thu, 16 Mar 2023 06:11:51 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32GDBfXB043907; Thu, 16 Mar 2023 08:11:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678972301; bh=+3qlT5xo8C2XEL+3dkb2MvncEbC5C6q29OK6u6zofJY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=xZv+1T3B+3/1SpX0ZAiGSXI0X+D2paGdJgzCqhBP5v1jibyD4T33/E5UHoV4IVM4d dPKhqVjImkStCfKH0BHq1zBHYILC+T5NBZcXs3HhPsCIaUw3tVqpf8Xm7lRl90gZC+ 3OzShHrgL7l/8cKnDx0V5boik68cid7pRGvSLUMA= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32GDBfrq127943 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Mar 2023 08:11:41 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 16 Mar 2023 08:11:41 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 16 Mar 2023 08:11:41 -0500 Received: from [10.24.69.114] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32GDBaEG024511; Thu, 16 Mar 2023 08:11:37 -0500 Message-ID: <468f85ad-e4b0-54e1-a5b9-4692ae8a1445@ti.com> Date: Thu, 16 Mar 2023 18:41:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR To: Roger Quadros , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-5-danishanwar@ti.com> <60e73395-f670-6eaa-0eb7-389553320a71@kernel.org> <20718115-7606-a77b-7e4d-511ca9c1d798@ti.com> Content-Language: en-US From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 16/03/23 17:49, Roger Quadros wrote: > > > On 16/03/2023 13:44, Md Danish Anwar wrote: >> >> On 16/03/23 17:06, Roger Quadros wrote: >>> Hi, >>> >>> On 16/03/2023 13:05, Md Danish Anwar wrote: >>>> Hi Roger, >>>> >>>> On 15/03/23 17:52, Roger Quadros wrote: >>>>> >>>>> >>>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>>> From: Suman Anna >>>>>> >>>>>> The PRUSS CFG module is represented as a syscon node and is currently >>>>>> managed by the PRUSS platform driver. Add easy accessor functions to set >>>>>> GPI mode, MII_RT event enable/disable and XFR (XIN XOUT) enable/disable >>>>>> to enable the PRUSS Ethernet usecase. These functions reuse the generic >>>>>> pruss_cfg_update() API function. >>>>>> >>>>>> Signed-off-by: Suman Anna >>>>>> Co-developed-by: Grzegorz Jaszczyk >>>>>> Signed-off-by: Grzegorz Jaszczyk >>>>>> Signed-off-by: Puranjay Mohan >>>>>> Signed-off-by: MD Danish Anwar >>>>>> --- >>>>>> drivers/soc/ti/pruss.c | 60 ++++++++++++++++++++++++++++++++ >>>>>> include/linux/remoteproc/pruss.h | 22 ++++++++++++ >>>>>> 2 files changed, 82 insertions(+) >>>>>> >>>>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>>>>> index 26d8129b515c..2f04b7922ddb 100644 >>>>>> --- a/drivers/soc/ti/pruss.c >>>>>> +++ b/drivers/soc/ti/pruss.c >>>>>> @@ -203,6 +203,66 @@ static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, >>>>>> return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); >>>>>> } >>>>>> >>>>>> +/** >>>>>> + * pruss_cfg_gpimode() - set the GPI mode of the PRU >>>>>> + * @pruss: the pruss instance handle >>>>>> + * @pru_id: id of the PRU core within the PRUSS >>>>>> + * @mode: GPI mode to set >>>>>> + * >>>>>> + * Sets the GPI mode for a given PRU by programming the >>>>>> + * corresponding PRUSS_CFG_GPCFGx register >>>>>> + * >>>>>> + * Return: 0 on success, or an error code otherwise >>>>>> + */ >>>>>> +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, >>>>>> + enum pruss_gpi_mode mode) >>>>>> +{ >>>>>> + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) >>>>>> + return -EINVAL; >>>>>> + >>>>>> + if (mode < 0 || mode > PRUSS_GPI_MODE_MAX) >>>>>> + return -EINVAL; >>>>>> + >>>>>> + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), >>>>>> + PRUSS_GPCFG_PRU_GPI_MODE_MASK, >>>>>> + mode << PRUSS_GPCFG_PRU_GPI_MODE_SHIFT); >>>>>> +} >>>>>> +EXPORT_SYMBOL_GPL(pruss_cfg_gpimode); >>>>>> + >>>>>> +/** >>>>>> + * pruss_cfg_miirt_enable() - Enable/disable MII RT Events >>>>>> + * @pruss: the pruss instance >>>>>> + * @enable: enable/disable >>>>>> + * >>>>>> + * Enable/disable the MII RT Events for the PRUSS. >>>>>> + * >>>>>> + * Return: 0 on success, or an error code otherwise >>>>>> + */ >>>>>> +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) >>>>>> +{ >>>>>> + u32 set = enable ? PRUSS_MII_RT_EVENT_EN : 0; >>>>>> + >>>>>> + return pruss_cfg_update(pruss, PRUSS_CFG_MII_RT, >>>>>> + PRUSS_MII_RT_EVENT_EN, set); >>>>>> +} >>>>>> +EXPORT_SYMBOL_GPL(pruss_cfg_miirt_enable); >>>>>> + >>>>>> +/** >>>>>> + * pruss_cfg_xfr_enable() - Enable/disable XIN XOUT shift functionality >>>>>> + * @pruss: the pruss instance >>>>>> + * @enable: enable/disable >>>>>> + * @mask: Mask for PRU / RTU >>>>> >>>>> You should not expect the user to provide the mask but only >>>>> the core type e.g. >>>>> >>>>> enum pru_type { >>>>> PRU_TYPE_PRU = 0, >>>>> PRU_TYPE_RTU, >>>>> PRU_TYPE_TX_PRU, >>>>> PRU_TYPE_MAX, >>>>> }; >>>>> >>>>> Then you figure out the mask in the function. >>>>> Also check for invalid pru_type and return error if so. >>>>> >>>> >>>> Sure Roger, I will create a enum and take it as parameter in API. Based on >>>> these enum I will calculate mask and do XFR shifting inside the API >>>> pruss_cfg_xfr_enable(). >>>> >>>> There are two registers for XFR shift. >>>> >>>> #define PRUSS_SPP_XFER_SHIFT_EN BIT(1) >>>> #define PRUSS_SPP_RTU_XFR_SHIFT_EN BIT(3) >>>> >>>> For PRU XFR shifting, the mask should be PRUSS_SPP_XFER_SHIFT_EN, >>>> for RTU shifting mask should be PRUSS_SPP_RTU_XFR_SHIFT_EN and for PRU and RTU >>>> shifting mask should be (PRUSS_SPP_XFER_SHIFT_EN | PRUSS_SPP_RTU_XFR_SHIFT_EN) >>>> >>>> So the enum would be something like this. >>>> >>>> /** >>>> * enum xfr_shift_type - XFR shift type >>>> * @XFR_SHIFT_PRU: Enables XFR shift for PRU >>>> * @XFR_SHIFT_RTU: Enables XFR shift for RTU >>>> * @XFR_SHIFT_PRU_RTU: Enables XFR shift for both PRU and RTU >>> >>> This is not required. User can call the API twice. once for PRU and once for RTU. >>> >>>> * @XFR_SHIFT_MAX: Total number of XFR shift types available. >>>> * >>>> */ >>>> >>>> enum xfr_shift_type { >>>> XFR_SHIFT_PRU = 0, >>>> XFR_SHIFT_RTU, >>>> XFR_SHIFT_PRU_RTU, >>>> XFR_SHIFT_MAX, >>>> }; >>> >>> Why do you need this new enum definition? >>> We already have pru_type defined somewhere. You can move it to a public header >>> if not there yet. >>> >>> enum pru_type { >>> PRU_TYPE_PRU = 0, >>> PRU_TYPE_RTU, >>> PRU_TYPE_TX_PRU, >>> PRU_TYPE_MAX, >>> }; >>> >> >> This enum is present in drivers/remoteproc/pru_rproc.c file. But the problem >> with this enum is that in [1] we need to enable XFR shift for both PRU and RTU >> for which the mask will be OR of PRUSS_SPP_XFER_SHIFT_EN (mask for PRU) and >> PRUSS_SPP_RTU_XFR_SHIFT_EN (mask of RTU). > > Is there any limitation that you have to enable both simultaneously? > The driver can first do enable for PRU and then later for RTU. > > As you will do a read modify write, the previous enable state of register > shouldn't be affected. > >> >> Now this enum doesn't have a field for both PRU and RTU. Also we don't need >> need the XFR shift for PRU_TYPE_TX_PRU as only two XFR shift register bits are >> defined. > > That is OK. You can return error if not RTU or PRU. > >> >> That is why I thought of introducing new enum. >> >> [1] drivers/net/ethernet/ti/icssg_config.c >> >> /* enable XFR shift for PRU and RTU */ >> mask = PRUSS_SPP_XFER_SHIFT_EN | PRUSS_SPP_RTU_XFR_SHIFT_EN; > > Driver can do like so > > pruss_cfg_xfr_enable(pruss, PRU_TYPE_PRU, true); > pruss_cfg_xfr_enable(pruss, PRU_TYPE_RTU, true); > > The second call should not disable the PRU XFR as you will do a > read-modify-write only affecting the RTU bit. Sure, then I will use the existing enum pru_type. The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this enum definition from there to include/linux/remoteproc/pruss.h > > cheers, > -roger -- Thanks and Regards, Danish. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74DD1C6FD1F for ; Thu, 16 Mar 2023 13:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zFL87OV97bbxE5fNqfi5R7Z5v8JlODqGIYhIADfCbdE=; b=cSlhfpU2neSLXE AG4nXRDTLvp8Phsf3Q/CSgCsNYjR0D+AGgwuOcZIaxQgPzUB17gnr9cixUeaSzTUtW/Wldo+KwOYO JhGFzRxT3yfsWYwwiaF748pJJJ8fGqeVXs+oA75P0KPEx+/P1TVzdZ0R9QClLolZJptu8mXUW2OPP ALoLXIQ4HV+H1l5bTj6jIUpDXti3vvHfIh4V0Z/1fpYvptio+nKsl8b/ndwjaK5EFgeK2fyAeN6QZ HEWFYoB4zcsXNnN3LhR7wtJZLFujvoT0WlojJX1jtnOFUlxK3noxi++U0CKLsaH68xvreUg17AgDq tuV2+RxUQaLsirmoq2dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcnOa-00GTrz-27; Thu, 16 Mar 2023 13:11:52 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcnOX-00GTr5-1L for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 13:11:51 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32GDBfXB043907; Thu, 16 Mar 2023 08:11:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678972301; bh=+3qlT5xo8C2XEL+3dkb2MvncEbC5C6q29OK6u6zofJY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=xZv+1T3B+3/1SpX0ZAiGSXI0X+D2paGdJgzCqhBP5v1jibyD4T33/E5UHoV4IVM4d dPKhqVjImkStCfKH0BHq1zBHYILC+T5NBZcXs3HhPsCIaUw3tVqpf8Xm7lRl90gZC+ 3OzShHrgL7l/8cKnDx0V5boik68cid7pRGvSLUMA= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32GDBfrq127943 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Mar 2023 08:11:41 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 16 Mar 2023 08:11:41 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 16 Mar 2023 08:11:41 -0500 Received: from [10.24.69.114] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32GDBaEG024511; Thu, 16 Mar 2023 08:11:37 -0500 Message-ID: <468f85ad-e4b0-54e1-a5b9-4692ae8a1445@ti.com> Date: Thu, 16 Mar 2023 18:41:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR To: Roger Quadros , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-5-danishanwar@ti.com> <60e73395-f670-6eaa-0eb7-389553320a71@kernel.org> <20718115-7606-a77b-7e4d-511ca9c1d798@ti.com> Content-Language: en-US From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_061149_627602_4D419734 X-CRM114-Status: GOOD ( 29.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/23 17:49, Roger Quadros wrote: > > > On 16/03/2023 13:44, Md Danish Anwar wrote: >> >> On 16/03/23 17:06, Roger Quadros wrote: >>> Hi, >>> >>> On 16/03/2023 13:05, Md Danish Anwar wrote: >>>> Hi Roger, >>>> >>>> On 15/03/23 17:52, Roger Quadros wrote: >>>>> >>>>> >>>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>>> From: Suman Anna >>>>>> >>>>>> The PRUSS CFG module is represented as a syscon node and is currently >>>>>> managed by the PRUSS platform driver. Add easy accessor functions to set >>>>>> GPI mode, MII_RT event enable/disable and XFR (XIN XOUT) enable/disable >>>>>> to enable the PRUSS Ethernet usecase. These functions reuse the generic >>>>>> pruss_cfg_update() API function. >>>>>> >>>>>> Signed-off-by: Suman Anna >>>>>> Co-developed-by: Grzegorz Jaszczyk >>>>>> Signed-off-by: Grzegorz Jaszczyk >>>>>> Signed-off-by: Puranjay Mohan >>>>>> Signed-off-by: MD Danish Anwar >>>>>> --- >>>>>> drivers/soc/ti/pruss.c | 60 ++++++++++++++++++++++++++++++++ >>>>>> include/linux/remoteproc/pruss.h | 22 ++++++++++++ >>>>>> 2 files changed, 82 insertions(+) >>>>>> >>>>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>>>>> index 26d8129b515c..2f04b7922ddb 100644 >>>>>> --- a/drivers/soc/ti/pruss.c >>>>>> +++ b/drivers/soc/ti/pruss.c >>>>>> @@ -203,6 +203,66 @@ static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, >>>>>> return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); >>>>>> } >>>>>> >>>>>> +/** >>>>>> + * pruss_cfg_gpimode() - set the GPI mode of the PRU >>>>>> + * @pruss: the pruss instance handle >>>>>> + * @pru_id: id of the PRU core within the PRUSS >>>>>> + * @mode: GPI mode to set >>>>>> + * >>>>>> + * Sets the GPI mode for a given PRU by programming the >>>>>> + * corresponding PRUSS_CFG_GPCFGx register >>>>>> + * >>>>>> + * Return: 0 on success, or an error code otherwise >>>>>> + */ >>>>>> +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, >>>>>> + enum pruss_gpi_mode mode) >>>>>> +{ >>>>>> + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) >>>>>> + return -EINVAL; >>>>>> + >>>>>> + if (mode < 0 || mode > PRUSS_GPI_MODE_MAX) >>>>>> + return -EINVAL; >>>>>> + >>>>>> + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), >>>>>> + PRUSS_GPCFG_PRU_GPI_MODE_MASK, >>>>>> + mode << PRUSS_GPCFG_PRU_GPI_MODE_SHIFT); >>>>>> +} >>>>>> +EXPORT_SYMBOL_GPL(pruss_cfg_gpimode); >>>>>> + >>>>>> +/** >>>>>> + * pruss_cfg_miirt_enable() - Enable/disable MII RT Events >>>>>> + * @pruss: the pruss instance >>>>>> + * @enable: enable/disable >>>>>> + * >>>>>> + * Enable/disable the MII RT Events for the PRUSS. >>>>>> + * >>>>>> + * Return: 0 on success, or an error code otherwise >>>>>> + */ >>>>>> +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) >>>>>> +{ >>>>>> + u32 set = enable ? PRUSS_MII_RT_EVENT_EN : 0; >>>>>> + >>>>>> + return pruss_cfg_update(pruss, PRUSS_CFG_MII_RT, >>>>>> + PRUSS_MII_RT_EVENT_EN, set); >>>>>> +} >>>>>> +EXPORT_SYMBOL_GPL(pruss_cfg_miirt_enable); >>>>>> + >>>>>> +/** >>>>>> + * pruss_cfg_xfr_enable() - Enable/disable XIN XOUT shift functionality >>>>>> + * @pruss: the pruss instance >>>>>> + * @enable: enable/disable >>>>>> + * @mask: Mask for PRU / RTU >>>>> >>>>> You should not expect the user to provide the mask but only >>>>> the core type e.g. >>>>> >>>>> enum pru_type { >>>>> PRU_TYPE_PRU = 0, >>>>> PRU_TYPE_RTU, >>>>> PRU_TYPE_TX_PRU, >>>>> PRU_TYPE_MAX, >>>>> }; >>>>> >>>>> Then you figure out the mask in the function. >>>>> Also check for invalid pru_type and return error if so. >>>>> >>>> >>>> Sure Roger, I will create a enum and take it as parameter in API. Based on >>>> these enum I will calculate mask and do XFR shifting inside the API >>>> pruss_cfg_xfr_enable(). >>>> >>>> There are two registers for XFR shift. >>>> >>>> #define PRUSS_SPP_XFER_SHIFT_EN BIT(1) >>>> #define PRUSS_SPP_RTU_XFR_SHIFT_EN BIT(3) >>>> >>>> For PRU XFR shifting, the mask should be PRUSS_SPP_XFER_SHIFT_EN, >>>> for RTU shifting mask should be PRUSS_SPP_RTU_XFR_SHIFT_EN and for PRU and RTU >>>> shifting mask should be (PRUSS_SPP_XFER_SHIFT_EN | PRUSS_SPP_RTU_XFR_SHIFT_EN) >>>> >>>> So the enum would be something like this. >>>> >>>> /** >>>> * enum xfr_shift_type - XFR shift type >>>> * @XFR_SHIFT_PRU: Enables XFR shift for PRU >>>> * @XFR_SHIFT_RTU: Enables XFR shift for RTU >>>> * @XFR_SHIFT_PRU_RTU: Enables XFR shift for both PRU and RTU >>> >>> This is not required. User can call the API twice. once for PRU and once for RTU. >>> >>>> * @XFR_SHIFT_MAX: Total number of XFR shift types available. >>>> * >>>> */ >>>> >>>> enum xfr_shift_type { >>>> XFR_SHIFT_PRU = 0, >>>> XFR_SHIFT_RTU, >>>> XFR_SHIFT_PRU_RTU, >>>> XFR_SHIFT_MAX, >>>> }; >>> >>> Why do you need this new enum definition? >>> We already have pru_type defined somewhere. You can move it to a public header >>> if not there yet. >>> >>> enum pru_type { >>> PRU_TYPE_PRU = 0, >>> PRU_TYPE_RTU, >>> PRU_TYPE_TX_PRU, >>> PRU_TYPE_MAX, >>> }; >>> >> >> This enum is present in drivers/remoteproc/pru_rproc.c file. But the problem >> with this enum is that in [1] we need to enable XFR shift for both PRU and RTU >> for which the mask will be OR of PRUSS_SPP_XFER_SHIFT_EN (mask for PRU) and >> PRUSS_SPP_RTU_XFR_SHIFT_EN (mask of RTU). > > Is there any limitation that you have to enable both simultaneously? > The driver can first do enable for PRU and then later for RTU. > > As you will do a read modify write, the previous enable state of register > shouldn't be affected. > >> >> Now this enum doesn't have a field for both PRU and RTU. Also we don't need >> need the XFR shift for PRU_TYPE_TX_PRU as only two XFR shift register bits are >> defined. > > That is OK. You can return error if not RTU or PRU. > >> >> That is why I thought of introducing new enum. >> >> [1] drivers/net/ethernet/ti/icssg_config.c >> >> /* enable XFR shift for PRU and RTU */ >> mask = PRUSS_SPP_XFER_SHIFT_EN | PRUSS_SPP_RTU_XFR_SHIFT_EN; > > Driver can do like so > > pruss_cfg_xfr_enable(pruss, PRU_TYPE_PRU, true); > pruss_cfg_xfr_enable(pruss, PRU_TYPE_RTU, true); > > The second call should not disable the PRU XFR as you will do a > read-modify-write only affecting the RTU bit. Sure, then I will use the existing enum pru_type. The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this enum definition from there to include/linux/remoteproc/pruss.h > > cheers, > -roger -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel