From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: xt_connlimit 20070707 kernel Date: Wed, 11 Jul 2007 20:25:53 +0200 Message-ID: <469520B1.1060109@trash.net> References: <468E3E06.3080305@trash.net> <200707100630.l6A6UB8Q000847@toshiba.co.jp> <46951BA9.4010809@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List , Yasuyuki KOZAKAI To: Jan Engelhardt Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Jan Engelhardt wrote: > On Jul 11 2007 20:04, Patrick McHardy wrote: > >>>[...] >>> >>>But, nf_ct_get_tuplepr() returns with 1, and I am not sure why. >> >>Thats expected I guess, 1 is usually "success" for the tuple parsing >>functions. >> > > Such functions should at best return bool :( > Anyway, please take this patch (to be folded onto xt_connlimit) - > runtime-'tested' this time. Looks good. I've folded it into the original patch, thanks Jan.