From: xieziyao <xieziyao@huawei.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/sendfile: Convert sendfile07 to the new API
Date: Tue, 27 Apr 2021 02:07:43 +0000 [thread overview]
Message-ID: <469bfcb3d03f4380859b8bb3b0dfcc64@huawei.com> (raw)
In-Reply-To: <YIbAtwDn4YGukFGE@yuki>
Hi, Cyril,
Nice modification, thank you. I'll look at this type of interface function and pay attention next time.
Best Regards,
Ziyao
-----Original Message-----
From: Cyril Hrubis [mailto:chrubis@suse.cz]
Sent: Monday, April 26, 2021 9:32 PM
To: xieziyao <xieziyao@huawei.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP][PATCH 2/2] syscalls/sendfile: Convert sendfile07 to the new API
Hi!
I've simplified the code a bit and pushed, thanks.
* The socketpair() can be opened with SOCKET_NONBLOCK
* Made use of tst_fill_file()
* Moved tst_brk() out of the for() loop
* Fixed some typos and simplified the doc comment
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2021-04-27 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 8:42 [LTP] [PATCH 0/2] Convert sendfile{03, 07} to the new API Xie Ziyao
2021-04-26 8:42 ` [LTP] [PATCH 1/2] syscalls/sendfile: Convert sendfile03 " Xie Ziyao
2021-04-26 12:23 ` Cyril Hrubis
2021-04-26 8:42 ` [LTP] [PATCH 2/2] syscalls/sendfile: Convert sendfile07 " Xie Ziyao
2021-04-26 13:31 ` Cyril Hrubis
2021-04-27 2:07 ` xieziyao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469bfcb3d03f4380859b8bb3b0dfcc64@huawei.com \
--to=xieziyao@huawei.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.