From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Wei-r63237 Date: Mon, 8 Jan 2007 10:41:32 +0800 Subject: [U-Boot-Users] [PATCH] Fixed cfi flash read uchar bug. In-Reply-To: <200701051428.21262.sr@denx.de> Message-ID: <46B96294322F7D458F9648B60E15112C03F04E@zch01exm26.fsl.freescale.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Stefan, Thanks! But it's a pity they are no useful. > > What I noticed after looking at the flash access functions like > flash_read_uchar() is that no access macros and even no > volatile pointer > access is used to read from the flash. This looks like a > potential problem, > that can show when using different compiler versions. > > Please find attached a small patch that adds fixes this > potential problem for > the 3 functions flash_read_uchar/ushort/long. Please give it > a try and let me > know if this changed the behavior somehow. Agree with you! It's a potential problem. Is my patch fit for it? :D Best Regards, Zhang Wei