From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753351AbcDATO6 (ORCPT ); Fri, 1 Apr 2016 15:14:58 -0400 Received: from mga09.intel.com ([134.134.136.24]:52702 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbcDATOr convert rfc822-to-8bit (ORCPT ); Fri, 1 Apr 2016 15:14:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,428,1455004800"; d="scan'208";a="949833698" From: "Drokin, Oleg" To: Joe Perches CC: James Simmons , "" , Greg Kroah-Hartman , "" , "" Subject: Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Thread-Topic: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Thread-Index: AQHRjBbL2vZTcbvxyUywEzYHu7vSXp91oSuAgABI+ICAAAiIgA== Date: Fri, 1 Apr 2016 19:14:45 +0000 Message-ID: <46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com> References: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> <1459536253.1744.26.camel@perches.com> In-Reply-To: <1459536253.1744.26.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.204.230] Content-Type: text/plain; charset=US-ASCII Content-ID: <48579DC89BC1F044824A14F5D277FE29@intel.com> Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Apr 1, 2016, at 2:44 PM, Joe Perches wrote: > On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote: >> On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: >>> >>> Question about removing lustre typedefs. >>> >>> Various bits of lustre code use a mix of struct foo and foo_t. >>> >>> When would be an appropriate time to submit patches similar to >>> below that individually remove various typedefs from lustre code? >> I think now is as good time as any. >> the only small correction is those are LNet typedefs. >> While LNet is technically part of Lustre, it's a bit of a separate >> thing useful without Lustre too. >> >> I know James is working on cleaning up LNet, but I don't know if he has >> anything this would be conflicting at this moment or not. >> >> Thanks for the patches. I wonder if you are generating them automatically? >> Because it would be great if it also fixes the alignment issues > > It's pretty automatic. > > It's a trivial variant of the detypedef perl script I wrote awhile ago: > http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603 > > > I think changing the alignment issues is better done in a > separate patch. but then it's two patches per change in a way. fixing one thing breaking the other warning-wise, that's why I typically try to make such cleanup patches not to introduce any new warnings. > > James isn't cc'd on these patches as he's not a listed > maintainer. Maybe he should be added for all of it or > some part of it? > for drivers/staging/lustre/lnet for the drivers/staging/lustre/lustre - the only remaining few typedefs I am going to address, it's just some of the code using them will go away or change the users significantly - that's why they were left out in the first round of lustre detypedefisation. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Drokin, Oleg Date: Fri, 1 Apr 2016 19:14:45 +0000 Subject: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef In-Reply-To: <1459536253.1744.26.camel@perches.com> References: <0586F4EF-3E2B-419A-8343-3A4A7E34628D@intel.com> <1459536253.1744.26.camel@perches.com> Message-ID: <46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: James Simmons , "" , Greg Kroah-Hartman , "" , "" On Apr 1, 2016, at 2:44 PM, Joe Perches wrote: > On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote: >> On Apr 1, 2016, at 9:02 AM, Joe Perches wrote: >>> >>> Question about removing lustre typedefs. >>> >>> Various bits of lustre code use a mix of struct foo and foo_t. >>> >>> When would be an appropriate time to submit patches similar to >>> below that individually remove various typedefs from lustre code? >> I think now is as good time as any. >> the only small correction is those are LNet typedefs. >> While LNet is technically part of Lustre, it's a bit of a separate >> thing useful without Lustre too. >> >> I know James is working on cleaning up LNet, but I don't know if he has >> anything this would be conflicting at this moment or not. >> >> Thanks for the patches. I wonder if you are generating them automatically? >> Because it would be great if it also fixes the alignment issues > > It's pretty automatic. > > It's a trivial variant of the detypedef perl script I wrote awhile ago: > http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603 > > > I think changing the alignment issues is better done in a > separate patch. but then it's two patches per change in a way. fixing one thing breaking the other warning-wise, that's why I typically try to make such cleanup patches not to introduce any new warnings. > > James isn't cc'd on these patches as he's not a listed > maintainer. Maybe he should be added for all of it or > some part of it? > for drivers/staging/lustre/lnet for the drivers/staging/lustre/lustre - the only remaining few typedefs I am going to address, it's just some of the code using them will go away or change the users significantly - that's why they were left out in the first round of lustre detypedefisation. Thanks.