From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCA8C4332B for ; Fri, 20 Mar 2020 14:41:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA8BD20777 for ; Fri, 20 Mar 2020 14:41:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727362AbgCTOle (ORCPT ); Fri, 20 Mar 2020 10:41:34 -0400 Received: from foss.arm.com ([217.140.110.172]:49790 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbgCTOld (ORCPT ); Fri, 20 Mar 2020 10:41:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C7D161FB; Fri, 20 Mar 2020 07:41:32 -0700 (PDT) Received: from [10.37.12.155] (unknown [10.37.12.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D2EFB3F792; Fri, 20 Mar 2020 07:41:27 -0700 (PDT) Subject: Re: [PATCH v4 18/26] arm64: vdso32: Replace TASK_SIZE_32 check in vgettimeofday To: Catalin Marinas Cc: Mark Rutland , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Will Deacon , linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton References: <20200317143834.GC632169@arrakis.emea.arm.com> <20200317155031.GD632169@arrakis.emea.arm.com> <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> <20200317174806.GE632169@arrakis.emea.arm.com> <93cfe94a-c2a3-1025-bc9c-e7c3fd891100@arm.com> <20200318183603.GF94111@arrakis.emea.arm.com> <1bc25a53-7a59-0f60-ecf2-a3cace46b823@arm.com> <20200319181004.GA29214@mbp> <20200320142208.GC29214@mbp> From: Vincenzo Frascino Message-ID: <46add8e3-dd04-9194-4196-4d8e5cd4c70f@arm.com> Date: Fri, 20 Mar 2020 14:41:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200320142208.GC29214@mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Catalin, On 3/20/20 2:22 PM, Catalin Marinas wrote: > On Fri, Mar 20, 2020 at 01:05:14PM +0000, Vincenzo Frascino wrote: >> On 3/19/20 6:10 PM, Catalin Marinas wrote: >>> On Thu, Mar 19, 2020 at 12:38:42PM +0000, Vincenzo Frascino wrote: >>>> On 3/18/20 6:36 PM, Catalin Marinas wrote: >>>>> On Wed, Mar 18, 2020 at 04:14:26PM +0000, Vincenzo Frascino wrote: >>>>>> On 3/17/20 5:48 PM, Catalin Marinas wrote: [...] >> >> Thank you for the long chat this morning. As we agreed I am going to repost the >> patches removing the checks discussed in this thread > > Great, thanks. > >> and we will address the syscall ABI difference subsequently with a >> different series. > > Now I'm even less convinced we need any additional patches. The arm64 > compat syscall would still return -EFAULT for res >= TASK_SIZE_32 > because copy_to_user() will fail. So it would be entirely consistent > with the arm32 syscall. In the vdso-only case, both arm32 and arm64 > compat would generate a signal. > > As Will said, arguably, the syscall semantics may not be applicable to > the vdso implementation. But if you do want to get down this route (tp = > UINTPTR_MAX - sizeof(*tp) returning -EFAULT), please do it for all > architectures, not just arm64 compat. However, I'm not sure anyone > relies on this functionality, other than the vdsotest, so no real > application broken. > It is ok, we will discuss the topic once we cross that bridge. I am already happy that I managed to explain finally my reasons ;) Anyway, I think that if there is an application that relies on this behavior (or similar) and uses compat we will discover it as soon as these patches will be out in the wild. For this reason I am putting a link to this discussion in the commit message of the relevant patch so that we can take it from there. -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincenzo Frascino Subject: Re: [PATCH v4 18/26] arm64: vdso32: Replace TASK_SIZE_32 check in vgettimeofday Date: Fri, 20 Mar 2020 14:41:57 +0000 Message-ID: <46add8e3-dd04-9194-4196-4d8e5cd4c70f@arm.com> References: <20200317143834.GC632169@arrakis.emea.arm.com> <20200317155031.GD632169@arrakis.emea.arm.com> <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> <20200317174806.GE632169@arrakis.emea.arm.com> <93cfe94a-c2a3-1025-bc9c-e7c3fd891100@arm.com> <20200318183603.GF94111@arrakis.emea.arm.com> <1bc25a53-7a59-0f60-ecf2-a3cace46b823@arm.com> <20200319181004.GA29214@mbp> <20200320142208.GC29214@mbp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.110.172]:49790 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbgCTOld (ORCPT ); Fri, 20 Mar 2020 10:41:33 -0400 In-Reply-To: <20200320142208.GC29214@mbp> Content-Language: en-US Sender: linux-arch-owner@vger.kernel.org List-ID: To: Catalin Marinas Cc: Mark Rutland , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Will Deacon , linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn Hi Catalin, On 3/20/20 2:22 PM, Catalin Marinas wrote: > On Fri, Mar 20, 2020 at 01:05:14PM +0000, Vincenzo Frascino wrote: >> On 3/19/20 6:10 PM, Catalin Marinas wrote: >>> On Thu, Mar 19, 2020 at 12:38:42PM +0000, Vincenzo Frascino wrote: >>>> On 3/18/20 6:36 PM, Catalin Marinas wrote: >>>>> On Wed, Mar 18, 2020 at 04:14:26PM +0000, Vincenzo Frascino wrote: >>>>>> On 3/17/20 5:48 PM, Catalin Marinas wrote: [...] >> >> Thank you for the long chat this morning. As we agreed I am going to repost the >> patches removing the checks discussed in this thread > > Great, thanks. > >> and we will address the syscall ABI difference subsequently with a >> different series. > > Now I'm even less convinced we need any additional patches. The arm64 > compat syscall would still return -EFAULT for res >= TASK_SIZE_32 > because copy_to_user() will fail. So it would be entirely consistent > with the arm32 syscall. In the vdso-only case, both arm32 and arm64 > compat would generate a signal. > > As Will said, arguably, the syscall semantics may not be applicable to > the vdso implementation. But if you do want to get down this route (tp = > UINTPTR_MAX - sizeof(*tp) returning -EFAULT), please do it for all > architectures, not just arm64 compat. However, I'm not sure anyone > relies on this functionality, other than the vdsotest, so no real > application broken. > It is ok, we will discuss the topic once we cross that bridge. I am already happy that I managed to explain finally my reasons ;) Anyway, I think that if there is an application that relies on this behavior (or similar) and uses compat we will discover it as soon as these patches will be out in the wild. For this reason I am putting a link to this discussion in the commit message of the relevant patch so that we can take it from there. -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B2C5C4332E for ; Fri, 20 Mar 2020 14:41:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 154FA20732 for ; Fri, 20 Mar 2020 14:41:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SXiD6+xu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 154FA20732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=45y2+FaY5xWnXXT8lJNehgVyFzwbNjl3vKfcchlMOQQ=; b=SXiD6+xuQHukTD vbmo4iLCu50UqIxWoiVsyQxHoDW/Tg28uRZxVZqDEh1mUWw4az7aRYX0/lKKqX4azA04n7Y5E4YLW tqAOukWBtZFgp0mJcMIEr9qxkezTmd8iQKJkfON4kauDNPljC8TeAGlM/voqnTRIh0/Jqj3502rEU wJ5ofGlnsAmeHrBAaO4moXiAcVIXagH9TU344vpcOGHepyv9ldCJ+Wy3yff0jIRlyW/elkvudQbJy BU4kpB1JzumTatZUW8ny/bbftV2cIRgM2IFeWErQwhIu/4CXW4IAXluzESQrOeqf4OY8e6e/Qw6YD oOVdlFycRqksKamB5RvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFIq8-0001IE-5U; Fri, 20 Mar 2020 14:41:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFIq5-0001Hn-R1 for linux-arm-kernel@lists.infradead.org; Fri, 20 Mar 2020 14:41:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C7D161FB; Fri, 20 Mar 2020 07:41:32 -0700 (PDT) Received: from [10.37.12.155] (unknown [10.37.12.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D2EFB3F792; Fri, 20 Mar 2020 07:41:27 -0700 (PDT) Subject: Re: [PATCH v4 18/26] arm64: vdso32: Replace TASK_SIZE_32 check in vgettimeofday To: Catalin Marinas References: <20200317143834.GC632169@arrakis.emea.arm.com> <20200317155031.GD632169@arrakis.emea.arm.com> <83aaf9e1-0a8f-4908-577a-23766541b2ba@arm.com> <20200317174806.GE632169@arrakis.emea.arm.com> <93cfe94a-c2a3-1025-bc9c-e7c3fd891100@arm.com> <20200318183603.GF94111@arrakis.emea.arm.com> <1bc25a53-7a59-0f60-ecf2-a3cace46b823@arm.com> <20200319181004.GA29214@mbp> <20200320142208.GC29214@mbp> From: Vincenzo Frascino Message-ID: <46add8e3-dd04-9194-4196-4d8e5cd4c70f@arm.com> Date: Fri, 20 Mar 2020 14:41:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200320142208.GC29214@mbp> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200320_074133_963066_ADCF1897 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Will Deacon , linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, On 3/20/20 2:22 PM, Catalin Marinas wrote: > On Fri, Mar 20, 2020 at 01:05:14PM +0000, Vincenzo Frascino wrote: >> On 3/19/20 6:10 PM, Catalin Marinas wrote: >>> On Thu, Mar 19, 2020 at 12:38:42PM +0000, Vincenzo Frascino wrote: >>>> On 3/18/20 6:36 PM, Catalin Marinas wrote: >>>>> On Wed, Mar 18, 2020 at 04:14:26PM +0000, Vincenzo Frascino wrote: >>>>>> On 3/17/20 5:48 PM, Catalin Marinas wrote: [...] >> >> Thank you for the long chat this morning. As we agreed I am going to repost the >> patches removing the checks discussed in this thread > > Great, thanks. > >> and we will address the syscall ABI difference subsequently with a >> different series. > > Now I'm even less convinced we need any additional patches. The arm64 > compat syscall would still return -EFAULT for res >= TASK_SIZE_32 > because copy_to_user() will fail. So it would be entirely consistent > with the arm32 syscall. In the vdso-only case, both arm32 and arm64 > compat would generate a signal. > > As Will said, arguably, the syscall semantics may not be applicable to > the vdso implementation. But if you do want to get down this route (tp = > UINTPTR_MAX - sizeof(*tp) returning -EFAULT), please do it for all > architectures, not just arm64 compat. However, I'm not sure anyone > relies on this functionality, other than the vdsotest, so no real > application broken. > It is ok, we will discuss the topic once we cross that bridge. I am already happy that I managed to explain finally my reasons ;) Anyway, I think that if there is an application that relies on this behavior (or similar) and uses compat we will discover it as soon as these patches will be out in the wild. For this reason I am putting a link to this discussion in the commit message of the relevant patch so that we can take it from there. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel