All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Mehta, Piyush" <piyush.mehta@amd.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"balbi@kernel.org" <balbi@kernel.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Paladugu,
	Siva Durga Prasad" <siva.durga.prasad.paladugu@amd.com>,
	Manish Narani <manish.narani@xilinx.com>
Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt
Date: Thu, 15 Sep 2022 11:04:56 +0200	[thread overview]
Message-ID: <46b9bb31-efb5-1e1f-9d01-3841661293dc@amd.com> (raw)
In-Reply-To: <05ce5c7c-c7e2-cac1-341a-5461804f96ea@linaro.org>



On 9/15/22 10:44, Krzysztof Kozlowski wrote:
> On 14/09/2022 14:15, Mehta, Piyush wrote:
>>   
>>> Where is the user (DTS) and implementation of this change? If this is specific
>>> to Xilinx, why you do not have device specific compatible?
>> [Piyush]:
>> We have dedicated irq line for hibernation feature,  "hiber" irq line triggers hibernation interrupt.
>> DWC3 core supports the hibernation feature, we have a dedicated code which is yet to be upstreamed.
>> As the hibernation feature provided by dwc3-core, so this will be supported by other SOC/vendors.
> 
> But is hiber irq line present in other vendors? What confuses me is
> adding not only "hiber" irq but also otg in completely new enum.

I will let Piyush to comment hiber IRQ. But I expect we don't have visibility 
what others are doing but this is line is not Xilinx invention that's why I 
expect IP from Synopsys have it by default but it is up to soc vendor if 
hibernation feature is enabled or not.

otg is already listed in
Documentation/devicetree/bindings/usb/snps,dwc3.yaml

It is only about order.
Driver is already using
platform_get_irq_byname..() functions

I think any combination should be fine. Do we need to record used order or there 
is way in yaml to support any combination with dwc_usb3, host, peripheral, otg 
should be working (ignoring that hiber which should be likely there too).

Thanks,
Michal

  reply	other threads:[~2022-09-15  9:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12  8:57 [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt Piyush Mehta
2022-09-13  9:21 ` Krzysztof Kozlowski
2022-09-14 13:15   ` Mehta, Piyush
2022-09-15  8:44     ` Krzysztof Kozlowski
2022-09-15  9:04       ` Michal Simek [this message]
2022-09-16 10:10         ` Krzysztof Kozlowski
2022-09-22 11:34           ` Michal Simek
2022-09-23  4:28             ` Mehta, Piyush
2022-09-23  4:38             ` Mehta, Piyush
2022-09-23  9:22               ` Krzysztof Kozlowski
2022-09-23  9:34                 ` Michal Simek
2022-09-23 12:43 ` Felipe Balbi
2022-09-23 13:25   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46b9bb31-efb5-1e1f-9d01-3841661293dc@amd.com \
    --to=michal.simek@amd.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=manish.narani@xilinx.com \
    --cc=piyush.mehta@amd.com \
    --cc=robh+dt@kernel.org \
    --cc=siva.durga.prasad.paladugu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.