From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81460C433F5 for ; Mon, 3 Jan 2022 05:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbiACFwH (ORCPT ); Mon, 3 Jan 2022 00:52:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbiACFwG (ORCPT ); Mon, 3 Jan 2022 00:52:06 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 395F2C061761; Sun, 2 Jan 2022 21:52:06 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id B400342528; Mon, 3 Jan 2022 05:51:55 +0000 (UTC) Message-ID: <46c09b62-d50f-fd2e-3eb4-ed4b643eef4a@marcan.st> Date: Mon, 3 Jan 2022 14:51:53 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 07/34] brcmfmac: pcie: Read Apple OTP information Content-Language: en-US To: Linus Walleij Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-8-marcan@marcan.st> From: Hector Martin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2022/01/02 14:38, Linus Walleij wrote: > On Sun, Dec 26, 2021 at 4:37 PM Hector Martin wrote: > >> On Apple platforms, the One Time Programmable ROM in the Broadcom chips >> contains information about the specific board design (module, vendor, >> version) that is required to select the correct NVRAM file. Parse this >> OTP ROM and extract the required strings. >> >> Note that the user OTP offset/size is per-chip. This patch does not add >> any chips yet. >> >> Signed-off-by: Hector Martin > > Overall looks fine! > >> + const char *chip_params; >> + const char *module_params; > > This variable name "module_params" is a bit confusing since loadable > kernel modules have params... > > Can we think of another name and just put a comment that this > refers to the WiFi module building block? > > Sometimes people talk about SoM:s (system-on-modules), so > maybe som_params or brcm_som_params? > > Yours, > Linus Walleij > How about board_params, since we're already calling those things boards elsewhere in the driver? That could refer to the board of a standalone module, or an integrated board, which should cover all cases. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub