From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 007A0C433E0 for ; Mon, 28 Dec 2020 22:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA55422225 for ; Mon, 28 Dec 2020 22:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729378AbgL1Wzd (ORCPT ); Mon, 28 Dec 2020 17:55:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729540AbgL1ViG (ORCPT ); Mon, 28 Dec 2020 16:38:06 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40C3EC0613D6; Mon, 28 Dec 2020 13:37:26 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id g185so580623wmf.3; Mon, 28 Dec 2020 13:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tjuMWqX61cGzZmrb8GDkFEtjw2wV3E0sLXdDVgdaJmk=; b=TnSrLGWZjyaP3rgw3j4fiQoBIh8cvOL0+WDZ0EbvpQHJZTJhOTHX48H8wGz05VjGBX tbfgknkczgZejJewupBEZu4ut4R6zdrgmrmFDVc5xeJwG1EoDP6Mo73AaSJ+N9KkpxYg HtZTCOOAWLTDh1XKEb5KcSg9SJz0bUO941aAebv/VWFSelMnHv0wV9HbdOYwtwVJIkLZ C9eiQhyAlRqJ6T7xOaXUB84DV/cOaW4hvQejvwuH5bKh3qS8aq123biI31i8FlpYtx6m s8OLWYbF9IKGYQbZmRvkUAp8BXL+qSFVLp2Oe8BvH2BMaLaWsY2C6wNJH5oUoWfQI84G /s7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tjuMWqX61cGzZmrb8GDkFEtjw2wV3E0sLXdDVgdaJmk=; b=msrRLGjLlJGK+0B4bPHg6oQ7f4SWDAEc43PUuXHuyGDiXAuZXHAo1wC2XHIEAU+ABX hPyvE28Zl6sQJQGjRC8H5a46I/aD1405UuK5bYZf28FO7f+GGCup1u/3EO6frurQodhs BvCYJqi6BTuDlrmbdC/aPp0eg8aF4/wVIbjgbF04WpUFPHNbvigLThJqxlFFvPJQa1+W d3I5RP13ttREUpdTqA8zb7wMYciWYcMK1WaJ8S+MMkrcXE4xk5aQGtSWtNJ7fPeRxcH8 rix6GFBMXXsLgNYlFvzYsGyIjs7C58KsU6YCTX8XmzSJ/3WqLUZuXar/I0dzxXLkmdKj 45CQ== X-Gm-Message-State: AOAM5327WldCdl66D+usY3FQKn4uPTkfM9wlTm9JSgX/H/KVhaeOtlT+ JuWQ7zTo3rYV6MnQLfjnM9I= X-Google-Smtp-Source: ABdhPJxYAGP9CKttVXbiBA2bxywgtHY78VspJDUQexBoFrhwBMaUGe2gStN33DaKS/q/8Uwf6GKLUQ== X-Received: by 2002:a1c:a9cc:: with SMTP id s195mr675559wme.97.1609191444945; Mon, 28 Dec 2020 13:37:24 -0800 (PST) Received: from [192.168.1.158] ([2.31.224.116]) by smtp.gmail.com with ESMTPSA id b83sm674105wmd.48.2020.12.28.13.37.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Dec 2020 13:37:24 -0800 (PST) Subject: Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions To: Sakari Ailus Cc: Andy Shevchenko , Laurent Pinchart , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-8-djrscally@gmail.com> <20201228164101.GY26370@paasikivi.fi.intel.com> From: Daniel Scally Message-ID: <46c23435-e32e-9de1-5055-efebc001ebad@gmail.com> Date: Mon, 28 Dec 2020 21:37:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201228164101.GY26370@paasikivi.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Sakari On 28/12/2020 16:41, Sakari Ailus wrote: > Hi Daniel, > > On Thu, Dec 24, 2020 at 02:21:15PM +0000, Daniel Scally wrote: >> Hi Andy, Laurent >> >>> On Thu, Dec 24, 2020 at 2:55 PM Laurent Pinchart >>> wrote: >>>> On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: >>>>> On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: >>> >>> ... >>> >>>>>> + if (!strncmp(to_swnode(port)->node->name, "port@", >>>>> >>>>> You may use here corresponding _FMT macro. >>>>> >>>>>> + FWNODE_GRAPH_PORT_NAME_PREFIX_LEN)) >>>>>> + return port; >>> >>> ... >>> >>>>>> + /* Ports have naming style "port@n", we need to select the n */ >>>>> >>>>>> + ret = kstrtou32(swnode->parent->node->name + FWNODE_GRAPH_PORT_NAME_PREFIX_LEN, >>>>> >>>>> Maybe a temporary variable? >>>>> >>>>> unsigned int prefix_len = FWNODE_GRAPH_PORT_NAME_PREFIX_LEN; >>>>> ... >>>>> ret = kstrtou32(swnode->parent->node->name + prefix_len, >>>> >>>> Honestly I'm wondering if those macros don't hinder readability. I'd >>>> rather write >>>> >>>> + strlen("port@") >>> >>> Works for me, since the compiler optimizes this away to be a plain constant. >> >> Well, how about instead of the LEN macro, we have: >> >> #define FWNODE_GRAPH_PORT_NAME_PREFIX "port@" >> #define FWNODE_GRAPH_PORT_NAME_FMT FWNODE_GRAPH_PORT_NAME_PREFIX "%u" >> >> And then it's still maintainable in one place but (I think) slightly >> less clunky, since we can do strlen(FWNODE_GRAPH_PORT_NAME_PREFIX) >> >> Or we can do strlen("port@"), I'm good either way :) > > I'd be in favour of using strlen("port@") here. > > At least for now. I think refactoring the use of such strings could be a > separate set at another time, if that's seen as the way to go. Alright - thanks. In that case I'll switch to strlen("port@0"), and FWNODE_GRAPH_PORT_NAME_LEN can be dropped then I think.