All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>, Wanpeng Li <kernellwp@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH] KVM: X86: Allow userspace to define the microcode version
Date: Mon, 26 Feb 2018 12:54:52 +0100	[thread overview]
Message-ID: <46cecef2-b0fb-b0c2-bbf3-983328d52763@redhat.com> (raw)
In-Reply-To: <20180226114409.GD4377@pd.tnic>

On 26/02/2018 12:44, Borislav Petkov wrote:
>> The guest write is ignored as the original kvm implementation before the patch.
>
> That will never work because there's no virtualized microcode loader.
> Which will be a dumb idea anyway.
> 
> Goes to show that dealing with microcode revisions for a guest is the
> wrong approach.

I don't understand how one thing follows from the other.  How are writes
to 0x8B related to having a virtualized microcode loaded (which is a
concept that actually makes no sense at all)?

> So that's basically what I'm saying - fix apic_check_deadline_errata()
> to check whether the kernel runs as a guest.

It has already been fixed for a few months, and fixing it is indeed the
right thing to do independent of this patch.

Paolo

  parent reply	other threads:[~2018-02-26 11:54 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  7:23 [PATCH] KVM: X86: Allow userspace to define the microcode version Wanpeng Li
2018-02-26  9:41 ` Borislav Petkov
2018-02-26 10:06   ` Wanpeng Li
2018-02-26 10:49     ` Borislav Petkov
2018-02-26 11:02       ` Wanpeng Li
2018-02-26 11:16         ` Borislav Petkov
2018-02-26 11:25           ` Wanpeng Li
2018-02-26 11:30             ` Borislav Petkov
2018-02-26 11:37               ` Wanpeng Li
2018-02-26 11:44                 ` Borislav Petkov
2018-02-26 11:52                   ` Wanpeng Li
2018-02-26 11:54                   ` Paolo Bonzini [this message]
2018-02-26 12:15                     ` Borislav Petkov
2018-02-26 12:16                       ` Paolo Bonzini
2018-02-26 12:18                         ` Paolo Bonzini
2018-02-26 12:22                           ` Borislav Petkov
2018-02-26 12:41                             ` Paolo Bonzini
2018-02-26 13:05                               ` Borislav Petkov
2018-02-26 14:39                               ` Konrad Rzeszutek Wilk
2018-02-26 14:46                                 ` Paolo Bonzini
2018-02-26 19:37                                 ` Borislav Petkov
2018-02-26 20:51                                   ` Konrad Rzeszutek Wilk
2018-02-26 21:30                                     ` Konrad Rzeszutek Wilk
2018-02-27  8:33                                       ` Paolo Bonzini
2018-03-08  9:24                                       ` [tip:x86/pti] x86/spectre_v2: Don't check microcode versions when running under hypervisors tip-bot for Konrad Rzeszutek Wilk
2018-04-17 10:40                               ` [PATCH] KVM: X86: Allow userspace to define the microcode version Wanpeng Li
2018-04-17 20:24                                 ` Eduardo Habkost
2018-04-18  3:24                                   ` Wanpeng Li
2018-04-18  9:03                                     ` Eduardo Habkost
2018-04-18 10:36                                       ` Paolo Bonzini
2018-04-23 12:58                                         ` Borislav Petkov
2018-04-23 13:08                                           ` Eduardo Habkost
2018-04-23 13:23                                             ` Borislav Petkov
2018-04-23 16:03                                           ` Paolo Bonzini
2018-04-24  2:59                                         ` Wanpeng Li
2018-04-24  3:14                                           ` Konrad Rzeszutek Wilk
2018-04-24  5:09                                             ` Paolo Bonzini
2018-04-24 13:44                                               ` Konrad Rzeszutek Wilk
2018-04-24  2:56                               ` Wanpeng Li
2018-02-26 11:47       ` Paolo Bonzini
2018-02-26 12:20         ` Borislav Petkov
2018-02-26  9:26 Liran Alon
2018-02-26 10:08 ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46cecef2-b0fb-b0c2-bbf3-983328d52763@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bp@alien8.de \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.