From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Paolo Abeni <pabeni@redhat.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH v3 mptcp-net 1/3] mptcp: always parse mptcp options for MPC reqsk
Date: Tue, 25 May 2021 12:57:56 +0200 [thread overview]
Message-ID: <46d6ced3-5c45-e503-b799-368b97ab1571@tessares.net> (raw)
In-Reply-To: <7e97e8e3c7d9265dcbf098b57f12da11d0b383b1.1621521884.git.pabeni@redhat.com>
Hi Paolo, Mat,
On 20/05/2021 16:46, Paolo Abeni wrote:
> In subflow_syn_recv_sock() we currently skip options parsing
> for OoO packet, given that such packets may not carry the relevant
> MPC option.
>
> If the peer generates an MPC+data TSO packet and some of the early
> segments are lost or get reorder, we server will ignore the peer key,
> causing transient, unexpected fallback to TCP.
>
> The solution is always parsing the incoming MPTCP options, and
> do the fallback only for in-order packets. This actually cleans
> the existing code a bit.
>
> Reported-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> Fixes: d22f4988ffec ("mptcp: process MP_CAPABLE data option")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Thank you for the patches and the reviews!
- f407a7aa834a: mptcp: always parse mptcp options for MPC reqsk
- 68379f4d6133: mptcp: do not reset MP_CAPABLE subflow on mapping errors
- In this commit has been squashed "mptcp: cleanup error path in
subflow_check_data_avail()" commit
- cedf8c99c004: mptcp: update selftest for fallback due to OoO
- f76f266a991f: conflict in t/mptcp-add-sk-parameter-for-mptcp_parse_option
- b10d71891518: conflict in
t/mptcp-cleanup-error-path-in-subflow_check_data_avail
- Results: 9d8cf0870447..3ebd090a8fbc
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210525T105728
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210525T105728
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2021-05-25 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 14:46 [PATCH v3 mptcp-net 1/3] mptcp: always parse mptcp options for MPC reqsk Paolo Abeni
2021-05-20 14:46 ` [PATCH v3 mptcp-net 2/3] mptcp: do not reset MP_CAPABLE subflow on mapping errors Paolo Abeni
2021-05-21 0:22 ` Mat Martineau
2021-05-20 14:46 ` [PATCH v3 mptcp-net 3/3] mptcp: update selftest for fallback due to OoO Paolo Abeni
2021-05-25 10:57 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46d6ced3-5c45-e503-b799-368b97ab1571@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.