From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB5820E7 for ; Sat, 20 Aug 2022 06:43:27 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id fy5so12436111ejc.3 for ; Fri, 19 Aug 2022 23:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=jmGCfK1PpP8C14WpA4xMyU1skN/b8h3qkvgiLCfaJxg=; b=TnBejUt3mv99xj9NCm/2aMZ61TZLahK62aKH9XgCIt8STTI6imfqFkf5QR+DeLs7Nz CUhQySJTa396di1l425A7SEpn+fENqCXYXSt3LEbN9PAIin7ZFk9cMyXp2f2cxkT4PyD pBDaUhrBznjESOiF4reqUM5zmh5gf+POI+MzEHXr+Nzr7xt2ptWaCG7LUYABjBroyvpg kGsVvtVbtEzKkfIdWZifAU0kWC0OmnaKlZZyjmDyFLNhjkvCr76rvy9ER+QzQIrjekKV /7Fr3cH3IGxUWzpM3Hf/MkELPSv2GOjh4hpT+t62VhjXo4duLGC0whiDh3Amp0BIVcx2 Vp8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=jmGCfK1PpP8C14WpA4xMyU1skN/b8h3qkvgiLCfaJxg=; b=k9JP/bouaMfj+bOZvRcFBVvoZ/y0f7PTZBg8k4CUxv2m4pzSI9HDkg/sypwfGJDCoQ 55jJR4fsQ9Es/oK0qOSO3e6SXf49L1IRJNcCM6lN40w9MQG9iJ4eS+OudJ/kV8bOdSrD PeuhZbSSxgLOA727K4MzfIfDaViwmWAF3tlEj01iRBcIKvhh5yI7DM48G4KIqJdHCbnA snmx8RvTsaPBCD+K3Po+Sg1Ys71VKlOnulQfcpOKhPGfrvtKgEKnigPsUMzth3yHHUv/ svTf/7AloDDPEY8KrqXN/Ju4YU8Ry/sxI3D4fqmW5vpoZopR/duCYQ2cTan5X1Sgyxte rvew== X-Gm-Message-State: ACgBeo1WbYladLZs20QMa/i3GZSGGB4rizhhIqFSSTaTQ413sNgFCRwT 6P1h5N8nDoY3VNeYocFFWNc= X-Google-Smtp-Source: AA6agR5AYoSyQYhdFmno3awwnL/KqdiAY/EWoPslkD1DD0cXO1/u4VDORiF4nCEDyYzYCSFhq6fkfw== X-Received: by 2002:a17:907:6091:b0:731:37fb:bd9 with SMTP id ht17-20020a170907609100b0073137fb0bd9mr6966716ejc.219.1660977806197; Fri, 19 Aug 2022 23:43:26 -0700 (PDT) Received: from nam-dell.vm.stuba.sk ([147.175.88.220]) by smtp.gmail.com with ESMTPSA id 27-20020a170906329b00b0073c0b87ba34sm2935816ejw.198.2022.08.19.23.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 23:43:25 -0700 (PDT) From: Nam Cao To: lkp@intel.com Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, hdegoede@redhat.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, namcaov@gmail.com Subject: [PATCH v2 1/4] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Date: Sat, 20 Aug 2022 08:42:43 +0200 Message-Id: <46d73e331bae2192a328f6691763f39ea6c18b08.1660977536.git.namcaov@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit because this function is not used. Also remove function odm_InbandNoise_Monitor_NSeries because it is a static function which is only called from ODM_InbandNoise_Monitor. Signed-off-by: Nam Cao --- .../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 111 ------------------ .../staging/rtl8723bs/hal/odm_NoiseMonitor.h | 7 -- 2 files changed, 118 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c index 392cc8a398f5..b85b323cf5bd 100644 --- a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c +++ b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c @@ -17,114 +17,3 @@ #define Valid_Min -35 #define Valid_Max 10 #define ValidCnt 5 - -static s16 odm_InbandNoise_Monitor_NSeries( - struct dm_odm_t *pDM_Odm, - u8 bPauseDIG, - u8 IGIValue, - u32 max_time -) -{ - u32 tmp4b; - u8 max_rf_path = 0, rf_path; - u8 reg_c50, reg_c58, valid_done = 0; - struct noise_level noise_data; - u32 start = 0; - - pDM_Odm->noise_level.noise_all = 0; - - max_rf_path = 1; - - memset(&noise_data, 0, sizeof(struct noise_level)); - - /* */ - /* Step 1. Disable DIG && Set initial gain. */ - /* */ - - if (bPauseDIG) - odm_PauseDIG(pDM_Odm, ODM_PAUSE_DIG, IGIValue); - /* */ - /* Step 2. Disable all power save for read registers */ - /* */ - /* dcmd_DebugControlPowerSave(padapter, PSDisable); */ - - /* */ - /* Step 3. Get noise power level */ - /* */ - start = jiffies; - while (1) { - - /* Stop updating idle time pwer report (for driver read) */ - PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_TxGainStage, BIT25, 1); - - /* Read Noise Floor Report */ - tmp4b = PHY_QueryBBReg(pDM_Odm->Adapter, 0x8f8, bMaskDWord); - - /* PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XAAGCCore1, bMaskByte0, TestInitialGain); */ - /* if (max_rf_path == 2) */ - /* PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMaskByte0, TestInitialGain); */ - - /* update idle time pwer report per 5us */ - PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_TxGainStage, BIT25, 0); - - noise_data.value[RF_PATH_A] = (u8)(tmp4b&0xff); - noise_data.value[RF_PATH_B] = (u8)((tmp4b&0xff00)>>8); - - for (rf_path = RF_PATH_A; rf_path < max_rf_path; rf_path++) { - noise_data.sval[rf_path] = (s8)noise_data.value[rf_path]; - noise_data.sval[rf_path] /= 2; - } - /* mdelay(10); */ - /* msleep(10); */ - - for (rf_path = RF_PATH_A; rf_path < max_rf_path; rf_path++) { - if ((noise_data.valid_cnt[rf_path] < ValidCnt) && (noise_data.sval[rf_path] < Valid_Max && noise_data.sval[rf_path] >= Valid_Min)) { - noise_data.valid_cnt[rf_path]++; - noise_data.sum[rf_path] += noise_data.sval[rf_path]; - if (noise_data.valid_cnt[rf_path] == ValidCnt) { - valid_done++; - } - - } - - } - - /* printk("####### valid_done:%d #############\n", valid_done); */ - if ((valid_done == max_rf_path) || (jiffies_to_msecs(jiffies - start) > max_time)) { - for (rf_path = RF_PATH_A; rf_path < max_rf_path; rf_path++) { - /* printk("%s PATH_%d - sum = %d, valid_cnt = %d\n", __func__, rf_path, noise_data.sum[rf_path], noise_data.valid_cnt[rf_path]); */ - if (noise_data.valid_cnt[rf_path]) - noise_data.sum[rf_path] /= noise_data.valid_cnt[rf_path]; - else - noise_data.sum[rf_path] = 0; - } - break; - } - } - reg_c50 = (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XAAGCCore1, bMaskByte0); - reg_c50 &= ~BIT7; - pDM_Odm->noise_level.noise[RF_PATH_A] = -110 + reg_c50 + noise_data.sum[RF_PATH_A]; - pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_A]; - - if (max_rf_path == 2) { - reg_c58 = (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMaskByte0); - reg_c58 &= ~BIT7; - pDM_Odm->noise_level.noise[RF_PATH_B] = -110 + reg_c58 + noise_data.sum[RF_PATH_B]; - pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_B]; - } - pDM_Odm->noise_level.noise_all /= max_rf_path; - - /* */ - /* Step 4. Recover the Dig */ - /* */ - if (bPauseDIG) - odm_PauseDIG(pDM_Odm, ODM_RESUME_DIG, IGIValue); - - return pDM_Odm->noise_level.noise_all; - -} - -s16 ODM_InbandNoise_Monitor(void *pDM_VOID, u8 bPauseDIG, u8 IGIValue, u32 max_time) -{ - return odm_InbandNoise_Monitor_NSeries(pDM_VOID, bPauseDIG, IGIValue, max_time); -} diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h index ab114543f39c..01c5c524d4e0 100644 --- a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h +++ b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h @@ -29,11 +29,4 @@ struct odm_noise_monitor { s16 noise_all; }; -s16 ODM_InbandNoise_Monitor( - void *pDM_VOID, - u8 bPauseDIG, - u8 IGIValue, - u32 max_time -); - #endif -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4749984390027041912==" MIME-Version: 1.0 From: Nam Cao To: kbuild-all@lists.01.org Subject: [PATCH v2 1/4] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Date: Sat, 20 Aug 2022 08:42:43 +0200 Message-ID: <46d73e331bae2192a328f6691763f39ea6c18b08.1660977536.git.namcaov@gmail.com> In-Reply-To: List-Id: --===============4749984390027041912== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable because this function is not used. Also remove function odm_InbandNoise_Monitor_NSeries because it is a static function which is only called from ODM_InbandNoise_Monitor. Signed-off-by: Nam Cao --- .../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 111 ------------------ .../staging/rtl8723bs/hal/odm_NoiseMonitor.h | 7 -- 2 files changed, 118 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c b/drivers/sta= ging/rtl8723bs/hal/odm_NoiseMonitor.c index 392cc8a398f5..b85b323cf5bd 100644 --- a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c +++ b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c @@ -17,114 +17,3 @@ #define Valid_Min -35 #define Valid_Max 10 #define ValidCnt 5 - -static s16 odm_InbandNoise_Monitor_NSeries( - struct dm_odm_t *pDM_Odm, - u8 bPauseDIG, - u8 IGIValue, - u32 max_time -) -{ - u32 tmp4b; - u8 max_rf_path =3D 0, rf_path; - u8 reg_c50, reg_c58, valid_done =3D 0; - struct noise_level noise_data; - u32 start =3D 0; - - pDM_Odm->noise_level.noise_all =3D 0; - - max_rf_path =3D 1; - - memset(&noise_data, 0, sizeof(struct noise_level)); - - /* */ - /* Step 1. Disable DIG && Set initial gain. */ - /* */ - - if (bPauseDIG) - odm_PauseDIG(pDM_Odm, ODM_PAUSE_DIG, IGIValue); - /* */ - /* Step 2. Disable all power save for read registers */ - /* */ - /* dcmd_DebugControlPowerSave(padapter, PSDisable); */ - - /* */ - /* Step 3. Get noise power level */ - /* */ - start =3D jiffies; - while (1) { - - /* Stop updating idle time pwer report (for driver read) */ - PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_TxGainStage, BIT25, 1); - - /* Read Noise Floor Report */ - tmp4b =3D PHY_QueryBBReg(pDM_Odm->Adapter, 0x8f8, bMaskDWord); - - /* PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XAAGCCore1, bMaskByte0, TestIni= tialGain); */ - /* if (max_rf_path =3D=3D 2) */ - /* PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMaskByte0, TestIni= tialGain); */ - - /* update idle time pwer report per 5us */ - PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_TxGainStage, BIT25, 0); - - noise_data.value[RF_PATH_A] =3D (u8)(tmp4b&0xff); - noise_data.value[RF_PATH_B] =3D (u8)((tmp4b&0xff00)>>8); - - for (rf_path =3D RF_PATH_A; rf_path < max_rf_path; rf_path++) { - noise_data.sval[rf_path] =3D (s8)noise_data.value[rf_path]; - noise_data.sval[rf_path] /=3D 2; - } - /* mdelay(10); */ - /* msleep(10); */ - - for (rf_path =3D RF_PATH_A; rf_path < max_rf_path; rf_path++) { - if ((noise_data.valid_cnt[rf_path] < ValidCnt) && (noise_data.sval[rf_p= ath] < Valid_Max && noise_data.sval[rf_path] >=3D Valid_Min)) { - noise_data.valid_cnt[rf_path]++; - noise_data.sum[rf_path] +=3D noise_data.sval[rf_path]; - if (noise_data.valid_cnt[rf_path] =3D=3D ValidCnt) { - valid_done++; - } - - } - - } - - /* printk("####### valid_done:%d #############\n", valid_done); */ - if ((valid_done =3D=3D max_rf_path) || (jiffies_to_msecs(jiffies - start= ) > max_time)) { - for (rf_path =3D RF_PATH_A; rf_path < max_rf_path; rf_path++) { - /* printk("%s PATH_%d - sum =3D %d, valid_cnt =3D %d\n", __func__, rf_= path, noise_data.sum[rf_path], noise_data.valid_cnt[rf_path]); */ - if (noise_data.valid_cnt[rf_path]) - noise_data.sum[rf_path] /=3D noise_data.valid_cnt[rf_path]; - else - noise_data.sum[rf_path] =3D 0; - } - break; - } - } - reg_c50 =3D (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XAAGCCore1, bMas= kByte0); - reg_c50 &=3D ~BIT7; - pDM_Odm->noise_level.noise[RF_PATH_A] =3D -110 + reg_c50 + noise_data.sum= [RF_PATH_A]; - pDM_Odm->noise_level.noise_all +=3D pDM_Odm->noise_level.noise[RF_PATH_A]; - - if (max_rf_path =3D=3D 2) { - reg_c58 =3D (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMa= skByte0); - reg_c58 &=3D ~BIT7; - pDM_Odm->noise_level.noise[RF_PATH_B] =3D -110 + reg_c58 + noise_data.su= m[RF_PATH_B]; - pDM_Odm->noise_level.noise_all +=3D pDM_Odm->noise_level.noise[RF_PATH_B= ]; - } - pDM_Odm->noise_level.noise_all /=3D max_rf_path; - - /* */ - /* Step 4. Recover the Dig */ - /* */ - if (bPauseDIG) - odm_PauseDIG(pDM_Odm, ODM_RESUME_DIG, IGIValue); - - return pDM_Odm->noise_level.noise_all; - -} - -s16 ODM_InbandNoise_Monitor(void *pDM_VOID, u8 bPauseDIG, u8 IGIValue, u32= max_time) -{ - return odm_InbandNoise_Monitor_NSeries(pDM_VOID, bPauseDIG, IGIValue, max= _time); -} diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h b/drivers/sta= ging/rtl8723bs/hal/odm_NoiseMonitor.h index ab114543f39c..01c5c524d4e0 100644 --- a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h +++ b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h @@ -29,11 +29,4 @@ struct odm_noise_monitor { s16 noise_all; }; = -s16 ODM_InbandNoise_Monitor( - void *pDM_VOID, - u8 bPauseDIG, - u8 IGIValue, - u32 max_time -); - #endif -- = 2.25.1 --===============4749984390027041912==--