From: "Huichao Cai" <chcchc88@163.com>
To: "Dariusz Sosnowski" <dsosnowski@nvidia.com>
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data
Date: Thu, 2 Dec 2021 10:24:40 +0800 (CST) [thread overview]
Message-ID: <46dcf2ec.ecd.17d78f54937.Coremail.chcchc88@163.com> (raw)
In-Reply-To: <BY5PR12MB42274B45937610EFABA3431CA4689@BY5PR12MB4227.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
Hi Dariusz
Substituting options with NOOP might cause rte_ipv4_fragment_packet to produce more fragments than necessary, since options with copied flag unset will still occupy space in IPv4 header.
--The "ip_options_fragment" just make a replacement and doesn't change the length of the IPv4 header.So I don't quite understand why it leads to produce more fragments.
but maybe a better solution would be to prepare a separate IPv4 header for fragments without unnecessary options.
--Yes, we can do this, but it adds some extra work, such as generating a new IPv4 header and reassembling the data,which has some performance implications.
Huichao Cai
[-- Attachment #2: Type: text/html, Size: 2297 bytes --]
next prev parent reply other threads:[~2021-12-02 2:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 8:47 [PATCH] ip_frag: add IPv4 options fragment and unit test data Huichao Cai
2021-12-01 11:49 ` Dariusz Sosnowski
2021-12-02 2:24 ` Huichao Cai [this message]
2022-02-15 8:50 ` [PATCH v2] ip_frag: add IPv4 options fragment and " Huichao Cai
2022-02-18 19:04 ` Ananyev, Konstantin
2022-02-21 2:34 ` Huichao Cai
2022-02-21 3:17 ` [PATCH v3] " Huichao Cai
2022-02-25 14:33 ` Ananyev, Konstantin
2022-02-28 12:39 ` Huichao Cai
2022-03-15 7:22 ` [PATCH v4] " Huichao Cai
2022-03-21 14:24 ` Ananyev, Konstantin
2022-03-22 1:25 ` Huichao Cai
2022-03-22 3:09 ` [PATCH v5] " Huichao Cai
2022-03-23 12:52 ` Ananyev, Konstantin
2022-04-06 1:22 ` Huichao Cai
2022-04-06 16:47 ` Ananyev, Konstantin
2022-04-07 14:08 ` Aaron Conole
2022-04-13 2:49 ` Huichao Cai
2022-04-11 3:55 ` [PATCH v6] " Huichao Cai
2022-04-14 13:14 ` Thomas Monjalon
2022-04-14 13:26 ` Thomas Monjalon
2022-04-15 1:52 ` Huichao Cai
2022-04-15 3:26 ` [PATCH v7] " Huichao Cai
2022-04-15 8:29 ` Ananyev, Konstantin
2022-05-29 8:50 ` Huichao Cai
2022-05-29 8:57 ` Huichao Cai
2022-05-29 10:38 ` Konstantin Ananyev
2022-05-31 21:23 ` Thomas Monjalon
2022-06-16 15:10 ` David Marchand
2022-06-16 16:31 ` Stephen Hemminger
2022-06-17 3:52 ` Huichao Cai
2022-06-17 16:31 ` Stephen Hemminger
2022-06-18 11:01 ` Huichao Cai
2021-12-02 9:35 [PATCH] ip_frag: add IPv4 options fragment and unit " Dariusz Sosnowski
2021-12-02 11:38 ` Huichao Cai
2021-12-02 12:03 ` Ananyev, Konstantin
2022-02-10 12:21 Ananyev, Konstantin
2022-02-11 2:12 ` Huichao Cai
2022-02-11 9:41 ` Ananyev, Konstantin
2022-02-11 2:20 ` Huichao Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dcf2ec.ecd.17d78f54937.Coremail.chcchc88@163.com \
--to=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.