From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:57263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHOdh-0007sl-GJ for qemu-devel@nongnu.org; Fri, 19 Apr 2019 04:12:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHOdg-0008TR-Jk for qemu-devel@nongnu.org; Fri, 19 Apr 2019 04:12:53 -0400 Received: from 10.mo173.mail-out.ovh.net ([46.105.74.148]:57223) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHOdg-0008SU-CK for qemu-devel@nongnu.org; Fri, 19 Apr 2019 04:12:52 -0400 Received: from player699.ha.ovh.net (unknown [10.109.160.253]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id 2890BFAAE7 for ; Fri, 19 Apr 2019 10:12:49 +0200 (CEST) References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-16-thuth@redhat.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <46e2a455-45ef-a5b2-7bdb-f0d67ab270ba@kaod.org> Date: Fri, 19 Apr 2019 10:12:20 +0200 MIME-Version: 1.0 In-Reply-To: <20190418180057.3593-16-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 15/29] hw/arm: Express dependencies of the aspeed boards with Kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com Cc: Beniamino Galvani , Jan Kiszka , Antony Pavlov , Peter Chubb , qemu-block@nongnu.org, "Michael S. Tsirkin" , Andrew Jeffery , Igor Mitsyanko , Andrey Smirnov , Rob Herring , qemu-arm@nongnu.org, Andrzej Zaborowski , John Snow , Joel Stanley , "Edgar E . Iglesias" , Jean-Christophe Dubois , Marcel Apfelbaum , Philippe Mathieu-Daude , Alistair Francis , Subbaraya Sundeep , Gerd Hoffmann On 4/18/19 8:00 PM, Thomas Huth wrote: > Dependencies have been determined by looking at hw/arm/aspeed.c Looks correct to me.=20 Reviewed-by: C=C3=A9dric Le Goater Thanks Thomas, C. >=20 > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 7 +------ > hw/arm/Kconfig | 10 ++++++++++ > 2 files changed, 11 insertions(+), 6 deletions(-) >=20 > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-soft= mmu.mak > index 25e8f717ac..2580584281 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -26,15 +26,12 @@ CONFIG_SPITZ=3Dy > CONFIG_TOSA=3Dy > CONFIG_Z2=3Dy > CONFIG_COLLIE=3Dy > +CONFIG_ASPEED_SOC=3Dy > =20 > CONFIG_VGA=3Dy > -CONFIG_TMP421=3Dy > -CONFIG_PCA9552=3Dy > CONFIG_SSI_M25P80=3Dy > CONFIG_ALLWINNER_EMAC=3Dy > CONFIG_IMX_FEC=3Dy > -CONFIG_FTGMAC100=3Dy > -CONFIG_DS1338=3Dy > CONFIG_PLATFORM_BUS=3Dy > CONFIG_VIRTIO_MMIO=3Dy > =20 > @@ -92,8 +89,6 @@ CONFIG_I82801B11=3Dy > CONFIG_ACPI=3Dy > CONFIG_ARM_VIRT=3Dy > CONFIG_SMBIOS=3Dy > -CONFIG_ASPEED_SOC=3Dy > -CONFIG_SMBUS_EEPROM=3Dy > CONFIG_GPIO_KEY=3Dy > CONFIG_MSF2=3Dy > CONFIG_FW_CFG_DMA=3Dy > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 325133c129..abeaa54d88 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -254,6 +254,16 @@ config FSL_IMX6 > =20 > config ASPEED_SOC > bool > + select DS1338 > + select FTGMAC100 > + select I2C > + select PCA9552 > + select SERIAL > + select SMBUS_EEPROM > + select SSI > + select SSI_M25P80 > + select TMP105 > + select TMP421 > =20 > config MPS2 > bool >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8EDC282DA for ; Fri, 19 Apr 2019 08:13:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DA53217D7 for ; Fri, 19 Apr 2019 08:13:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DA53217D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:53150 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHOeV-0008JR-VL for qemu-devel@archiver.kernel.org; Fri, 19 Apr 2019 04:13:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHOdh-0007sl-GJ for qemu-devel@nongnu.org; Fri, 19 Apr 2019 04:12:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHOdg-0008TR-Jk for qemu-devel@nongnu.org; Fri, 19 Apr 2019 04:12:53 -0400 Received: from 10.mo173.mail-out.ovh.net ([46.105.74.148]:57223) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHOdg-0008SU-CK for qemu-devel@nongnu.org; Fri, 19 Apr 2019 04:12:52 -0400 Received: from player699.ha.ovh.net (unknown [10.109.160.253]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id 2890BFAAE7 for ; Fri, 19 Apr 2019 10:12:49 +0200 (CEST) Received: from kaod.org (lfbn-1-10649-41.w90-89.abo.wanadoo.fr [90.89.235.41]) (Authenticated sender: clg@kaod.org) by player699.ha.ovh.net (Postfix) with ESMTPSA id A92214ECE35F; Fri, 19 Apr 2019 08:12:20 +0000 (UTC) To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-16-thuth@redhat.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <46e2a455-45ef-a5b2-7bdb-f0d67ab270ba@kaod.org> Date: Fri, 19 Apr 2019 10:12:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418180057.3593-16-thuth@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Ovh-Tracer-Id: 9439544821477903212 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgddtudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.74.148 Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 15/29] hw/arm: Express dependencies of the aspeed boards with Kconfig X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Subbaraya Sundeep , Gerd Hoffmann , qemu-block@nongnu.org, "Michael S. Tsirkin" , Andrew Jeffery , John Snow , Alistair Francis , Philippe Mathieu-Daude , Jean-Christophe Dubois , Beniamino Galvani , Igor Mitsyanko , qemu-arm@nongnu.org, Peter Chubb , Antony Pavlov , "Edgar E . Iglesias" , Jan Kiszka , Andrey Smirnov , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190419081220.ACHio3kLEMLbjy1FkR5_kqHcH30DIgaFWzEY1MTeItk@z> On 4/18/19 8:00 PM, Thomas Huth wrote: > Dependencies have been determined by looking at hw/arm/aspeed.c Looks correct to me.=20 Reviewed-by: C=C3=A9dric Le Goater Thanks Thomas, C. >=20 > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 7 +------ > hw/arm/Kconfig | 10 ++++++++++ > 2 files changed, 11 insertions(+), 6 deletions(-) >=20 > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-soft= mmu.mak > index 25e8f717ac..2580584281 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -26,15 +26,12 @@ CONFIG_SPITZ=3Dy > CONFIG_TOSA=3Dy > CONFIG_Z2=3Dy > CONFIG_COLLIE=3Dy > +CONFIG_ASPEED_SOC=3Dy > =20 > CONFIG_VGA=3Dy > -CONFIG_TMP421=3Dy > -CONFIG_PCA9552=3Dy > CONFIG_SSI_M25P80=3Dy > CONFIG_ALLWINNER_EMAC=3Dy > CONFIG_IMX_FEC=3Dy > -CONFIG_FTGMAC100=3Dy > -CONFIG_DS1338=3Dy > CONFIG_PLATFORM_BUS=3Dy > CONFIG_VIRTIO_MMIO=3Dy > =20 > @@ -92,8 +89,6 @@ CONFIG_I82801B11=3Dy > CONFIG_ACPI=3Dy > CONFIG_ARM_VIRT=3Dy > CONFIG_SMBIOS=3Dy > -CONFIG_ASPEED_SOC=3Dy > -CONFIG_SMBUS_EEPROM=3Dy > CONFIG_GPIO_KEY=3Dy > CONFIG_MSF2=3Dy > CONFIG_FW_CFG_DMA=3Dy > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 325133c129..abeaa54d88 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -254,6 +254,16 @@ config FSL_IMX6 > =20 > config ASPEED_SOC > bool > + select DS1338 > + select FTGMAC100 > + select I2C > + select PCA9552 > + select SERIAL > + select SMBUS_EEPROM > + select SSI > + select SSI_M25P80 > + select TMP105 > + select TMP421 > =20 > config MPS2 > bool >=20