All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/8] lib/psr: Increase the buffer lenght that stores the output of i915_edp_psr_status
Date: Tue, 11 Dec 2018 14:53:52 -0800	[thread overview]
Message-ID: <46e45015e8a405fc93994481d78f2a98a13f178d.camel@intel.com> (raw)
In-Reply-To: <20181204230944.7753-1-jose.souza@intel.com>

On Tue, 2018-12-04 at 15:09 -0800, José Roberto de Souza wrote:
> Sometimes 512 bytes is not enoght to store the whole
                             ^enough
Not enough because of SU block counts?

> i915_edp_psr_status potentially causing fail in tests that depends
> in the content that is out of this 512 bytes.
> 
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  lib/igt_psr.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 0ddfb64f..c7bc523c 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -25,10 +25,12 @@
>  #include "igt_sysfs.h"
>  #include <errno.h>
>  
> +#define PSR_STATUS_MAX_LEN 1024
Move this to igt_psr.h so that we can use the same size in kms_psr.c.

> +
>  static bool psr_active(int debugfs_fd, bool check_active)
>  {
>  	bool active;
> -	char buf[512];
> +	char buf[PSR_STATUS_MAX_LEN];
>  
>  	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
>  				sizeof(buf));

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2018-12-11 22:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 23:09 [igt-dev] [PATCH i-g-t 1/8] lib/psr: Increase the buffer lenght that stores the output of i915_edp_psr_status José Roberto de Souza
2018-12-04 23:09 ` [igt-dev] [PATCH i-g-t 2/8] tests: Share the code handling PSR debugfs parsing José Roberto de Souza
2018-12-11 23:06   ` Dhinakaran Pandiyan
2018-12-13 19:53     ` Souza, Jose
2018-12-04 23:09 ` [igt-dev] [PATCH i-g-t 3/8] lib/psr: Add support to new modified i915_edp_psr_status output José Roberto de Souza
2018-12-04 23:11   ` Souza, Jose
2018-12-12  0:12     ` Dhinakaran Pandiyan
2018-12-04 23:09 ` [igt-dev] [PATCH i-g-t 4/8] lib/psr: Make psr_active() only cares about PSR1 José Roberto de Souza
2018-12-12  0:16   ` Dhinakaran Pandiyan
2018-12-13 19:47     ` Souza, Jose
2018-12-13 20:57       ` Dhinakaran Pandiyan
2018-12-04 23:09 ` [igt-dev] [PATCH i-g-t 5/8] lib/psr: Add PSR2 functions José Roberto de Souza
2018-12-04 23:09 ` [igt-dev] [PATCH i-g-t 6/8] tests/psr: Add the same test coverage that we have for PSR1 to PSR2 José Roberto de Souza
2018-12-12  1:20   ` Dhinakaran Pandiyan
2018-12-13 19:55     ` Souza, Jose
2018-12-04 23:09 ` [igt-dev] [PATCH i-g-t 7/8] tests/intel-ci: Add basic PSR2 tests to fast feedback test list José Roberto de Souza
2018-12-04 23:09 ` [igt-dev] [PATCH i-g-t 8/8] test: Add PSR2 selective update tests José Roberto de Souza
2018-12-05  0:24 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] lib/psr: Increase the buffer lenght that stores the output of i915_edp_psr_status Patchwork
2018-12-05 11:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-11 22:53 ` Dhinakaran Pandiyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46e45015e8a405fc93994481d78f2a98a13f178d.camel@intel.com \
    --to=dhinakaran.pandiyan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.