From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CECD6C433DB for ; Thu, 4 Feb 2021 03:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 948CF64E35 for ; Thu, 4 Feb 2021 03:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233928AbhBDD0U (ORCPT ); Wed, 3 Feb 2021 22:26:20 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12019 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231553AbhBDD0Q (ORCPT ); Wed, 3 Feb 2021 22:26:16 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DWP6N0m9rzjHm9; Thu, 4 Feb 2021 11:24:12 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.498.0; Thu, 4 Feb 2021 11:25:26 +0800 Subject: Re: [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst To: CC: , , References: <20210202080056.51658-1-yuchao0@huawei.com> From: Chao Yu Message-ID: <46e9924c-0086-cd2a-2e93-7149b92ba27e@huawei.com> Date: Thu, 4 Feb 2021 11:25:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210202080056.51658-1-yuchao0@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jaegeuk, On 2021/2/2 16:00, Chao Yu wrote: > - for (i = 0; i < dic->nr_cpages; i++) { > + for (i = 0; i < cc->nr_cpages; i++) { > struct page *page = dic->cpages[i]; por_fsstress still hang in this line? Thanks, > block_t blkaddr; > struct bio_post_read_ctx *ctx; > @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, > blkaddr = data_blkaddr(dn.inode, dn.node_page, > dn.ofs_in_node + i + 1); > > + f2fs_wait_on_block_writeback(inode, blkaddr); > + > + if (f2fs_load_compressed_page(sbi, page, blkaddr)) { > + if (atomic_dec_and_test(&dic->remaining_pages)) > + f2fs_decompress_cluster(dic); > + continue; > + } > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B10C433DB for ; Thu, 4 Feb 2021 03:25:54 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3FE964F43 for ; Thu, 4 Feb 2021 03:25:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3FE964F43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1l7VHC-0002wZ-EF; Thu, 04 Feb 2021 03:25:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7VHB-0002wT-Lg for linux-f2fs-devel@lists.sourceforge.net; Thu, 04 Feb 2021 03:25:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pEOox5HZN2l5WDAkGBd2JA2yTkTfWVrDQEBSw2ZI1wM=; b=MwXu0ALYCAsv7K/MzKupKIys5o x/1/RSLNQP/guMnFOwOBdp/+H2qrSQUfw/6/Ok/DA+3EJCL/oyMwQCrHLqz45p/WJauDEz76suXuJ dVcoITwWxdD/v/ah62fHeO32mnCyr2qrL9hwCkkCZmmdW3zIJILe2YogVcup+Dp4m1aQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pEOox5HZN2l5WDAkGBd2JA2yTkTfWVrDQEBSw2ZI1wM=; b=OU6rkTvr8hA7yf1U0ea2ruG5gH ecvM39h7LFuGFYxOJiubk9bmRAL+d97aQIIyibFyky+0JSxM1Dgq/qPAX11nbmZ1d2uF6lVEDrjOr DseidYzX6iTMch7rmdk5RDXWp6y6zv0PFA/J7EqRWI0J/Y7O2cH9X43PAHWKZZjtiVoI=; Received: from szxga05-in.huawei.com ([45.249.212.191]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1l7VH4-003XEo-Aq for linux-f2fs-devel@lists.sourceforge.net; Thu, 04 Feb 2021 03:25:49 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DWP6N0m9rzjHm9; Thu, 4 Feb 2021 11:24:12 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.498.0; Thu, 4 Feb 2021 11:25:26 +0800 To: References: <20210202080056.51658-1-yuchao0@huawei.com> From: Chao Yu Message-ID: <46e9924c-0086-cd2a-2e93-7149b92ba27e@huawei.com> Date: Thu, 4 Feb 2021 11:25:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210202080056.51658-1-yuchao0@huawei.com> Content-Language: en-US X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected X-Headers-End: 1l7VH4-003XEo-Aq Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Jaegeuk, On 2021/2/2 16:00, Chao Yu wrote: > - for (i = 0; i < dic->nr_cpages; i++) { > + for (i = 0; i < cc->nr_cpages; i++) { > struct page *page = dic->cpages[i]; por_fsstress still hang in this line? Thanks, > block_t blkaddr; > struct bio_post_read_ctx *ctx; > @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, > blkaddr = data_blkaddr(dn.inode, dn.node_page, > dn.ofs_in_node + i + 1); > > + f2fs_wait_on_block_writeback(inode, blkaddr); > + > + if (f2fs_load_compressed_page(sbi, page, blkaddr)) { > + if (atomic_dec_and_test(&dic->remaining_pages)) > + f2fs_decompress_cluster(dic); > + continue; > + } > + _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel