All of lore.kernel.org
 help / color / mirror / Atom feed
From: m95d@psihoexpert.ro
To: devicetree@vger.kernel.org
Subject: devicetree for Turris Omnia is missing i2c frequency for atsha204a
Date: Sat, 11 May 2024 20:09:30 +0000	[thread overview]
Message-ID: <46ea55652f8bcdef51d5c552902fd0cc@psihoexpert.ro> (raw)

Hello.

Booting kernel v6.6 I get these errors in dmesg:

atmel-sha204a 6-0064: failed to read clock-frequency property
atmel-sha204a: probe of 6-0064 failed with error -22

I'm attaching a patch to fix it.
It adds 1MHz clock frequency to the i2c devicetree node where atsha204a is connected. This is the max. supported frequency according to the atmel sha204a specs sheet.
Tested. Works.

Thank you.

diff --git a/arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts b/arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts
index 7b755bb4e4e7..64caabc81585 100644
--- a/arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts
@@ -378,6 +378,7 @@ i2c@5 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 			reg = <5>;
+			clock-frequency = <1000000>;
 
 			/* ATSHA204A-MAHDA-T crypto module */
 			crypto@64 {

Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>


             reply	other threads:[~2024-05-11 20:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-11 20:09 m95d [this message]
2024-05-15  8:41 ` atmel sha: i2c bus speed under multiplexer (WAS: devicetree for Turris Omnia is missing i2c frequency for atsha204a) Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46ea55652f8bcdef51d5c552902fd0cc@psihoexpert.ro \
    --to=m95d@psihoexpert.ro \
    --cc=devicetree@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.