All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pauli Virtanen <pav@iki.fi>
To: linux-bluetooth@vger.kernel.org
Cc: Pauli Virtanen <pav@iki.fi>
Subject: [PATCH 1/6] Bluetooth: ISO: fix maximum number of CIS in Set CIG Parameters
Date: Sun, 28 May 2023 17:44:09 +0000	[thread overview]
Message-ID: <46eefccceb45556120a0d1fa95cf27c576e9649a.1685294131.git.pav@iki.fi> (raw)
In-Reply-To: <cover.1685294131.git.pav@iki.fi>

The maximum CIS_Count is 0x1f (Core v5.3 Vol 4 Part E Sec 7.8.97).

Fixes: 26afbd826ee3 ("Bluetooth: Add initial implementation of CIS connections")
Signed-off-by: Pauli Virtanen <pav@iki.fi>
---
 net/bluetooth/hci_conn.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 1f906f8508bc..7b1a83ec50ae 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -788,7 +788,7 @@ struct iso_list_data {
 	int count;
 	struct {
 		struct hci_cp_le_set_cig_params cp;
-		struct hci_cis_params cis[0x11];
+		struct hci_cis_params cis[0x1f];
 	} pdu;
 };
 
@@ -1815,7 +1815,8 @@ static bool hci_le_set_cig_params(struct hci_conn *conn, struct bt_iso_qos *qos)
 	}
 
 	/* Reprogram all CIS(s) with the same CIG */
-	for (data.cig = qos->ucast.cig, data.cis = 0x00; data.cis < 0x11;
+	for (data.cig = qos->ucast.cig, data.cis = 0x00;
+	     data.cis < ARRAY_SIZE(data.pdu.cis);
 	     data.cis++) {
 		data.count = 0;
 
-- 
2.40.1


  reply	other threads:[~2023-05-28 17:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-28 17:44 [PATCH 0/6] LE Set CIG Parameters / Create CIS fixes Pauli Virtanen
2023-05-28 17:44 ` Pauli Virtanen [this message]
2023-05-28 18:37   ` bluez.test.bot
2023-05-28 23:23   ` [PATCH 1/6] Bluetooth: ISO: fix maximum number of CIS in Set CIG Parameters Pauli Virtanen
2023-05-28 17:44 ` [PATCH 2/6] Bluetooth: ISO: use hci_sync for setting CIG parameters Pauli Virtanen
2023-05-28 17:44 ` [PATCH 3/6] Bluetooth: ISO: don't try to do Set CIG Parameters if CIG known busy Pauli Virtanen
2023-05-28 17:44 ` [PATCH 4/6] Bluetooth: ISO: don't try to remove CIG if there are bound CIS left Pauli Virtanen
2023-05-28 17:44 ` [PATCH 5/6] Bluetooth: ISO: use correct CIS order in Set CIG Parameters event Pauli Virtanen
2023-05-30 17:46   ` Luiz Augusto von Dentz
2023-05-28 17:44 ` [PATCH 6/6] Bluetooth: ISO: do not emit new LE Create CIS if previous is pending Pauli Virtanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46eefccceb45556120a0d1fa95cf27c576e9649a.1685294131.git.pav@iki.fi \
    --to=pav@iki.fi \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.