From: Stefan Strogin <sstrogin@cisco.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: xe-linux-external@cisco.com,
OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] slang: add ptest
Date: Thu, 9 Mar 2017 18:45:51 +0200 [thread overview]
Message-ID: <46f4cc8d-e1eb-e8d1-d1e2-ed17cf0172fa@cisco.com> (raw)
In-Reply-To: <CAJTo0La=cCuaP8mvpg3K-J31VcSnxdEJJof+Jc_nWG1rjQimmw@mail.gmail.com>
On 06/03/17 14:58, Burton, Ross wrote:
>
> On 2 March 2017 at 17:29, Stefan Strogin <sstrogin@cisco.com <mailto:sstrogin@cisco.com>> wrote:
>
> + cp -r ${S}/src/test ${D}${PTEST_PATH}/
> + mkdir ${D}${PTEST_PATH}/objs
> + cp ${S}/src/objs/libslang.a ${D}${PTEST_PATH}/objs/
>
>
> Why?
>
> If this is because the tests need sltest, that's already been built and is in the package: just patch the Makefile instead. It's also huge, so I'd be tempted to say we should strip sltest as enabling ptest for slang causes slang-dbg to increase by 2MB.
>
> Ross
Sorry, my mistake. sltest doesn't need libslang.a for running, of course. I'll change the Makefile and resend the patch.
--
Thank you,
Stefan
prev parent reply other threads:[~2017-03-09 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 17:29 [PATCH] slang: add ptest Stefan Strogin
2017-03-06 12:58 ` Burton, Ross
2017-03-09 16:45 ` Stefan Strogin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46f4cc8d-e1eb-e8d1-d1e2-ed17cf0172fa@cisco.com \
--to=sstrogin@cisco.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.