All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Tao Zhou <tao.zhou@linux.dev>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>, Tom Zanussi <zanussi@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Clark Williams <williams@redhat.com>,
	John Kacur <jkacur@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-rt-users@vger.kernel.org,
	linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode
Date: Tue, 26 Oct 2021 21:50:57 +0200	[thread overview]
Message-ID: <46ffc66d-26da-7ac5-0f3f-e86594d2b60c@kernel.org> (raw)
In-Reply-To: <YXgtnEPcT8vay1wI@geo.homenetwork>

On 10/26/21 18:32, Tao Zhou wrote:
>> +	if (params->stop_us)
>> +		osnoise_set_stop_us(tool->context, params->stop_us);
> osnoise_set_stop_us() also need to check return value feels by me.
> 
>> +
>> +	if (params->stop_total_us)
>> +		osnoise_set_stop_total_us(tool->context, params->stop_total_us);
> The same here. Also need to check the return value.
> 
> PATCH 10 also has these two places(call the two functions) that not check
> the return value.
> 
> Or I am wrong.


You are right, reviewing that.

Thanks!
-- Daniel

> 
> 
> Thanks,
> Tao
> 


  reply	other threads:[~2021-10-26 20:14 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 17:40 [PATCH V5 00/20] RTLA: An interface for osnoise/timerlat tracers Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 01/20] trace/osnoise: Do not follow tracing_cpumask Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 02/20] trace/osnoise: Improve comments about barrier need for NMI callbacks Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 03/20] trace/osnoise: Split workload start from the tracer start Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 04/20] trace/osnoise: Use start/stop_per_cpu_kthreads() on osnoise_cpus_write() Daniel Bristot de Oliveira
2021-10-26  1:08   ` Steven Rostedt
2021-10-26  8:23     ` Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 05/20] trace/osnoise: Support a list of trace_array *tr Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 06/20] trace/osnoise: Allow multiple instances of the same tracer Daniel Bristot de Oliveira
2021-10-26  2:08   ` Steven Rostedt
2021-10-26  8:38     ` Daniel Bristot de Oliveira
2021-10-26 13:02       ` Steven Rostedt
2021-10-25 17:40 ` [PATCH V5 07/20] rtla: Real-Time Linux Analysis tool Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 08/20] rtla: Helper functions for rtla Daniel Bristot de Oliveira
2021-10-26 16:22   ` Tao Zhou
2021-10-26 16:26     ` Steven Rostedt
2021-10-26 19:45       ` Daniel Bristot de Oliveira
2021-10-26 19:43     ` Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 09/20] rtla: Add osnoise tool Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode Daniel Bristot de Oliveira
2021-10-26 16:32   ` Tao Zhou
2021-10-26 19:50     ` Daniel Bristot de Oliveira [this message]
2021-10-25 17:40 ` [PATCH V5 11/20] rtla/osnoise: Add the hist mode Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 12/20] rtla: Add timerlat tool and timelart top mode Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 13/20] rtla/timerlat: Add timerlat hist mode Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 14/20] rtla: Add Documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 15/20] rtla: Add rtla osnoise man page Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 16/20] rtla: Add rtla osnoise top documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 17/20] rtla: Add rtla osnoise hist documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 18/20] rtla: Add rtla timerlat documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 19/20] rtla: Add rtla timerlat top documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 20/20] rtla: Add rtla timerlat hist documentation Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46ffc66d-26da-7ac5-0f3f-e86594d2b60c@kernel.org \
    --to=bristot@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tao.zhou@linux.dev \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.