From: Felix Kuehling <felix.kuehling@amd.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
amd-gfx@lists.freedesktop.org, Alex.Sierra@amd.com,
Philip.Yang@amd.com
Subject: Re: [PATCH 1/8] drm/amdgpu: drop amdgpu_job.owner
Date: Mon, 13 Jan 2020 13:56:28 -0500 [thread overview]
Message-ID: <4706848a-1ade-1138-95cd-a7bd741414ec@amd.com> (raw)
In-Reply-To: <20200113144055.3416-1-christian.koenig@amd.com>
I replied with one question about patch 4. Other than that the series is
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
On 2020-01-13 9:40 a.m., Christian König wrote:
> Entirely unused.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 1 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 614919f265b9..c4a8148b9b6f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -1233,7 +1233,6 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
> goto error_abort;
> }
>
> - job->owner = p->filp;
> p->fence = dma_fence_get(&job->base.s_fence->finished);
>
> amdgpu_ctx_add_fence(p->ctx, entity, p->fence, &seq);
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 73328d0c741d..d42be880a236 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -153,7 +153,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
> if (r)
> return r;
>
> - job->owner = owner;
> *f = dma_fence_get(&job->base.s_fence->finished);
> amdgpu_job_free_resources(job);
> priority = job->base.s_priority;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h
> index aa0e375062f2..31c4444b0203 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h
> @@ -49,7 +49,6 @@ struct amdgpu_job {
> uint32_t preamble_status;
> uint32_t preemption_status;
> uint32_t num_ibs;
> - void *owner;
> bool vm_needs_flush;
> uint64_t vm_pd_addr;
> unsigned vmid;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-01-13 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 14:40 [PATCH 1/8] drm/amdgpu: drop amdgpu_job.owner Christian König
2020-01-13 14:40 ` [PATCH 2/8] drm/amdgpu: explicitly sync VM update to PDs/PTs Christian König
2020-01-13 14:40 ` [PATCH 3/8] drm/amdgpu: use the VM as job owner Christian König
2020-01-13 14:40 ` [PATCH 4/8] drm/amdgpu: rework job synchronization Christian König
2020-01-13 17:16 ` Felix Kuehling
2020-01-13 14:40 ` [PATCH 5/8] drm/amdgpu: rework synchronization of VM updates v2 Christian König
2020-01-13 14:40 ` [PATCH 6/8] drm/amdgpu: stop using amdgpu_bo_gpu_offset in the VM backend Christian König
2020-01-13 14:40 ` [PATCH 7/8] drm/amdgpu: drop unnecessary restriction for huge root PDEs Christian König
2020-01-13 14:40 ` [PATCH 8/8] drm/amdgpu: make sure to never allocate PDs/PTs for invalidations Christian König
2020-01-13 18:56 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4706848a-1ade-1138-95cd-a7bd741414ec@amd.com \
--to=felix.kuehling@amd.com \
--cc=Alex.Sierra@amd.com \
--cc=Philip.Yang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ckoenig.leichtzumerken@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.