From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn
Date: Thu, 1 Mar 2018 16:56:17 -0600 [thread overview]
Message-ID: <4709a16d-d8cd-08de-f160-cf246c1c1bfe@redhat.com> (raw)
In-Reply-To: <20180301163619.21072-3-pbonzini@redhat.com>
On 03/01/2018 10:36 AM, Paolo Bonzini wrote:
> From: Stefan Hajnoczi <stefanha@redhat.com>
>
> qcow2_create2() calls qemu_co_mutex_lock(). Only a coroutine_fn may
> call another coroutine_fn. In fact, qcow2_create2 is always called from
> coroutine context.
>
> Rename the function to add the "co" moniker and add coroutine_fn.
>
> Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Message-Id: <20170705102231.20711-3-stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Message-Id: <1516279431-30424-3-git-send-email-pbonzini@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
More of the funny double-Message-Id/S-o-b.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-01 22:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 16:36 [Qemu-devel] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context Paolo Bonzini
2018-03-01 16:36 ` [Qemu-devel] [PATCH 1/8] block: rename .bdrv_create() to .bdrv_co_create_opts() Paolo Bonzini
2018-03-01 19:23 ` Eric Blake
2018-03-01 16:36 ` [Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn Paolo Bonzini
2018-03-01 22:56 ` Eric Blake [this message]
2018-03-01 16:36 ` [Qemu-devel] [PATCH 3/8] qcow2: introduce qcow2_write_caches and qcow2_flush_caches Paolo Bonzini
2018-03-02 1:33 ` Eric Blake
2018-03-01 16:36 ` [Qemu-devel] [PATCH 4/8] qcow2: fix flushing after dirty bitmap metadata writes Paolo Bonzini
2018-03-01 16:36 ` [Qemu-devel] [PATCH 5/8] qcow2: make qcow2_do_open a coroutine_fn Paolo Bonzini
2018-03-01 16:36 ` [Qemu-devel] [PATCH 6/8] qed: make bdrv_qed_do_open " Paolo Bonzini
2018-03-01 16:36 ` [Qemu-devel] [PATCH 7/8] block: convert bdrv_invalidate_cache callback to coroutine_fn Paolo Bonzini
2018-03-01 16:36 ` [Qemu-devel] [PATCH 8/8] block: convert bdrv_check " Paolo Bonzini
2018-03-06 13:59 ` [Qemu-devel] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context Kevin Wolf
2018-03-06 14:28 ` Paolo Bonzini
2018-03-06 16:37 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4709a16d-d8cd-08de-f160-cf246c1c1bfe@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.