All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jain Priyanka-B32167 <B32167@freescale.com>
To: Wolfram Sang <w.sang@pengutronix.de>,
	"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"p_gortmaker@yahoo.com" <p_gortmaker@yahoo.com>
Subject: RE: [rtc-linux] [PATCH] RTC driver(Linux) for PT7C4338 chip.
Date: Thu, 10 Mar 2011 03:23:57 +0000	[thread overview]
Message-ID: <470DB7CE2CD0944E9436E7ADEFC02FE313B1C2@039-SN1MPN1-003.039d.mgd.msft.net> (raw)
In-Reply-To: <20110303092239.GB3649@pengutronix.de>

Dear Wolfram,

Though register-set looks identical but features were different. And also m=
anufacturer is different.
But still it might be possible that we can reuse ds1307.c with some modific=
ation.
But if I look at the drivers present in drivers/rtc folder. Most of them lo=
oks similar but still there are different drivers for different chips.

Please suggest which way is more preferred: modifying existing drivers(of d=
ifferent manufacturer) or writing new driver.=20

Thanks
Priyanka

> -----Original Message-----
> From: Wolfram Sang [mailto:w.sang@pengutronix.de]
> Sent: Thursday, March 03, 2011 2:53 PM
> To: rtc-linux@googlegroups.com
> Cc: linuxppc-dev@lists.ozlabs.org; a.zummo@towertech.it;
> p_gortmaker@yahoo.com; akpm@linux-foundation.org; Jain Priyanka-B32167
> Subject: Re: [rtc-linux] [PATCH] RTC driver(Linux) for PT7C4338 chip.
>=20
> Hi,
>=20
> > +/*
> > + * This file provides Date & Time support (no alarms) for PT7C4338
> chip.
> > + *
> > + * This file is based on drivers/rtc/rtc-ds1307.c
>=20
> Please explain why you can't use rtc-ds1307 directly (or with slight
> modifications). I might have missed something but the register-set looks
> identical to me?
>=20
> Regards,
>=20
>    Wolfram
>=20
> --
> Pengutronix e.K.                           | Wolfram Sang
> |
> Industrial Linux Solutions                 | http://www.pengutronix.de/
> |

  parent reply	other threads:[~2011-03-10  3:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03  3:51 [PATCH] RTC driver(Linux) for PT7C4338 chip Priyanka Jain
2011-03-03  9:22 ` [rtc-linux] " Wolfram Sang
2011-03-09  0:55   ` Andrew Morton
2011-03-09  6:46     ` Wolfram Sang
2011-03-10  3:23   ` Jain Priyanka-B32167 [this message]
2011-03-10  8:54     ` Wolfram Sang
2011-03-10 11:06       ` Jain Priyanka-B32167
2011-05-25 23:56         ` Andrew Morton
2011-05-26  7:11           ` Jain Priyanka-B32167

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470DB7CE2CD0944E9436E7ADEFC02FE313B1C2@039-SN1MPN1-003.039d.mgd.msft.net \
    --to=b32167@freescale.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=p_gortmaker@yahoo.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.