All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: "Pan, Miaoqing" <miaoqing@qti.qualcomm.com>,
	herbert@gondor.apana.org.au, Matt Mackall <mpm@selenic.com>
Cc: "miaoqing@codeaurora.org" <miaoqing@codeaurora.org>,
	"Valo, Kalle" <kvalo@qca.qualcomm.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	ath9k-devel <ath9k-devel@qca.qualcomm.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"jason@lakedaemon.net" <jason@lakedaemon.net>,
	"Sepehrdad, Pouyan" <pouyans@qti.qualcomm.com>
Subject: Re: [PATCH 2/2] ath9k: disable RNG by default
Date: Tue, 09 Aug 2016 10:07:29 +0200	[thread overview]
Message-ID: <4731753.YZZKimtrHM@tauon.atsec.com> (raw)
In-Reply-To: <69af156ac93a4fe6ab1844dfcc35c266@aptaiexm02f.ap.qualcomm.com>

Am Dienstag, 9. August 2016, 07:35:33 CEST schrieb Pan, Miaoqing:

Hi Miaoqing, Herbert, Matt,

> Hi Stephan,
> 
> So your suggestion is to use HW Random framework ?   Actually, which was
> done by the commit 6301566e0b2d ("ath9k: export HW random number
> generator"), but it was reverted, you can refer to
> https://www.mail-archive.com/linux-crypto%40vger.kernel.org/msg15483.html
> for more information.

I see, it is the same RNG we talked about earlier. The issue is that the 
suggested rngd per default assumes one bit of entropy with every data bit. 
This is not given with this noise source. This is the basis of my reply last 
time.

Herbert, Matt, should such noise sources be added to the HW random framework? 
The thing is that the in-kernel HW random to input_pool link per default uses 
a more conservative entropy estimate than the user space rngd. I would think 
that the in-kernel link would appropriate for that rng. But the user space 
rngd tool with its default behavior is not really suited here.

Thanks
Stephan

  reply	other threads:[~2016-08-09  8:07 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09  7:02 [PATCH 1/2] ath9k: change entropy formula for easier understanding miaoqing
2016-08-09  7:02 ` [PATCH 2/2] ath9k: disable RNG by default miaoqing
2016-08-09  7:14   ` Stephan Mueller
2016-08-09  7:14     ` Stephan Mueller
2016-08-09  7:35     ` Pan, Miaoqing
2016-08-09  8:07       ` Stephan Mueller [this message]
2016-08-09  8:58         ` Herbert Xu
2016-08-09  9:02           ` Stephan Mueller
2016-08-09  9:17             ` Herbert Xu
2016-08-09  9:17               ` Herbert Xu
2016-08-09  9:37               ` Stephan Mueller
2016-08-09  9:37                 ` Stephan Mueller
2016-08-09  9:46                 ` Herbert Xu
2016-08-09  9:56                   ` Stephan Mueller
2016-08-09  9:56                     ` Herbert Xu
2016-08-09 10:06                       ` Stephan Mueller
2016-08-09 10:24                         ` Henrique de Moraes Holschuh
2016-08-09 10:24                           ` Henrique de Moraes Holschuh
2016-08-09 17:51                           ` Jason Cooper
2016-08-10  2:35                 ` Pan, Miaoqing
2016-08-10  2:35                   ` Pan, Miaoqing
2016-08-10  5:29                   ` Stephan Mueller
2016-08-10  5:29                     ` Stephan Mueller
2016-08-10  6:04                     ` Pan, Miaoqing
2016-08-10  6:04                       ` Pan, Miaoqing
2016-08-10  6:25                       ` Stephan Mueller
2016-08-10  6:46                         ` Pan, Miaoqing
2016-08-10  6:46                           ` Pan, Miaoqing
2016-08-10  6:51                           ` Stephan Mueller
2016-08-10  7:15                             ` Pan, Miaoqing
2016-08-10  7:27                               ` Stephan Mueller
2016-08-10  7:27                                 ` Stephan Mueller
2016-08-10  7:40                                 ` Pan, Miaoqing
2016-08-10  7:40                                   ` Pan, Miaoqing
2016-08-10  7:43                                   ` Pan, Miaoqing
2016-08-10  7:43                                     ` Pan, Miaoqing
2016-08-10 13:24                                     ` Jason Cooper
2016-08-10 13:24                                       ` Jason Cooper
2016-08-11  2:54                                       ` miaoqing
2016-08-11 13:14                                         ` Jason Cooper
2016-08-11 13:14                                           ` Jason Cooper
2016-08-09 17:48   ` Jason Cooper
2016-08-09 17:48     ` Jason Cooper
2016-09-28 10:00   ` [2/2] " Kalle Valo
2016-09-27 14:53 ` [1/2] ath9k: change entropy formula for easier understanding Kalle Valo
2016-09-27 14:53   ` Kalle Valo
2016-10-13 14:23 ` Kalle Valo
2016-10-13 14:23   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4731753.YZZKimtrHM@tauon.atsec.com \
    --to=smueller@chronox.de \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jason@lakedaemon.net \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miaoqing@codeaurora.org \
    --cc=miaoqing@qti.qualcomm.com \
    --cc=mpm@selenic.com \
    --cc=pouyans@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.