From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC53C63793 for ; Thu, 22 Jul 2021 08:53:28 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 781CC60238 for ; Thu, 22 Jul 2021 08:53:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 781CC60238 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C4A6982C4C; Thu, 22 Jul 2021 10:53:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626944006; bh=++CgBmRPIHL880LLFbBkCxDMCScOnbRwM5hCV8SoIhU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ccytj69GdvzbAEgdcXEu8FHyCjQWiatlvjokdvHVKC4xqq+1vAANgZJO9SjM5KJiZ eMtSXLgpN9WVy/+l7/tNec4SlZH81nM5Q0GduQxBDW6DejajCQYdV6o3zdHnLgd5ZQ QNFo/+IgMHwr3DXuwCXK91KD0buPo8DMCTtX6A23A+YPzpU0XsrHKIEKIV5Xp/LqgR eJ6QkJPF7rpdYsnkIDaH6+qUi4+sTZtgzKOOKrgLc6v5kgTGIsk5A7qG1hRSeP7nyh W2G7v1rzphVh6o167bRulP/GB8l3tHvQUrsSOZZISCx0xVK+UTTcSWy4rT38USu6dA 4aMEI32Fr6lrw== Received: by phobos.denx.de (Postfix, from userid 109) id C208A82C4D; Thu, 22 Jul 2021 10:53:24 +0200 (CEST) Received: from mout-u-205.mailbox.org (mout-u-205.mailbox.org [IPv6:2001:67c:2050:1::465:205]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 96BF482C4C for ; Thu, 22 Jul 2021 10:53:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-205.mailbox.org (Postfix) with ESMTPS id 4GVmSd2q6FzQkGR; Thu, 22 Jul 2021 10:53:21 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id MxjUkYRYgiEq; Thu, 22 Jul 2021 10:53:18 +0200 (CEST) Subject: Re: [PATCH u-boot-mvebu v2 38/41] arm: mvebu: Remove unused macro CONFIG_SYS_U_BOOT_OFFS To: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, Chris Packham , Baruch Siach , Dirk Eibach , Chris Packham Cc: Dennis Gilmore , Mario Six , Jon Nettleton , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20210719122104.29698-1-marek.behun@nic.cz> <20210719122104.29698-39-marek.behun@nic.cz> From: Stefan Roese Message-ID: <4738807d-edfb-acd4-643e-72aa177dc3fc@denx.de> Date: Thu, 22 Jul 2021 10:53:17 +0200 MIME-Version: 1.0 In-Reply-To: <20210719122104.29698-39-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 66A9A1819 X-Rspamd-UID: d33af8 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 19.07.21 14:21, Marek Behún wrote: > From: Pali Rohár > > Macro CONFIG_SYS_U_BOOT_OFFS is set but not used anymore. Remove it. > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún > Reviewed-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan > --- > include/configs/clearfog.h | 6 +----- > include/configs/controlcenterdc.h | 6 ------ > include/configs/db-88f6720.h | 3 --- > include/configs/db-88f6820-amc.h | 5 ----- > include/configs/db-88f6820-gp.h | 6 ------ > include/configs/db-mv784mp-gp.h | 3 --- > include/configs/ds414.h | 5 ----- > include/configs/helios4.h | 6 +----- > include/configs/theadorable.h | 3 --- > include/configs/turris_omnia.h | 6 ------ > include/configs/x530.h | 3 --- > scripts/config_whitelist.txt | 1 - > 12 files changed, 2 insertions(+), 51 deletions(-) > > diff --git a/include/configs/clearfog.h b/include/configs/clearfog.h > index 255b147945..fbdd2f0a24 100644 > --- a/include/configs/clearfog.h > +++ b/include/configs/clearfog.h > @@ -69,12 +69,8 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -#if defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI) > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x20000 > -#elif defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC) || defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SATA) > +#if defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC) || defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SATA) > /* SPL related MMC defines */ > -#define CONFIG_SYS_U_BOOT_OFFS (160 << 10) > #ifdef CONFIG_SPL_BUILD > #define CONFIG_FIXED_SDHCI_ALIGNED_BUFFER 0x00180000 /* in SDRAM */ > #endif > diff --git a/include/configs/controlcenterdc.h b/include/configs/controlcenterdc.h > index fffc372872..e81d05aa2e 100644 > --- a/include/configs/controlcenterdc.h > +++ b/include/configs/controlcenterdc.h > @@ -85,15 +85,9 @@ > #define CONFIG_SPL_LIBGENERIC_SUPPORT > #define CONFIG_SPL_I2C_SUPPORT > > -#if CONFIG_SPL_BOOT_DEVICE == SPL_BOOT_SPI_NOR_FLASH > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x30000 > -#endif > - > #if CONFIG_SPL_BOOT_DEVICE == SPL_BOOT_SDIO_MMC_CARD > /* SPL related MMC defines */ > #define CONFIG_SPL_MMC_SUPPORT > -#define CONFIG_SYS_U_BOOT_OFFS (168 << 10) > #ifdef CONFIG_SPL_BUILD > #define CONFIG_FIXED_SDHCI_ALIGNED_BUFFER 0x00180000 /* in SDRAM */ > #endif > diff --git a/include/configs/db-88f6720.h b/include/configs/db-88f6720.h > index 14c0190375..cbb9270f93 100644 > --- a/include/configs/db-88f6720.h > +++ b/include/configs/db-88f6720.h > @@ -65,7 +65,4 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x20000 > - > #endif /* _CONFIG_DB_88F6720_H */ > diff --git a/include/configs/db-88f6820-amc.h b/include/configs/db-88f6820-amc.h > index 3cd1ff899a..757fbc0b9b 100644 > --- a/include/configs/db-88f6820-amc.h > +++ b/include/configs/db-88f6820-amc.h > @@ -59,11 +59,6 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -#if CONFIG_SPL_BOOT_DEVICE == SPL_BOOT_SPI_NOR_FLASH > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x24000 > -#endif > - > /* > * mv-common.h should be defined after CMD configs since it used them > * to enable certain macros > diff --git a/include/configs/db-88f6820-gp.h b/include/configs/db-88f6820-gp.h > index 5e43191e8e..d50eb2c120 100644 > --- a/include/configs/db-88f6820-gp.h > +++ b/include/configs/db-88f6820-gp.h > @@ -71,14 +71,8 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -#if CONFIG_SPL_BOOT_DEVICE == SPL_BOOT_SPI_NOR_FLASH > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x24000 > -#endif > - > #if CONFIG_SPL_BOOT_DEVICE == SPL_BOOT_SDIO_MMC_CARD > /* SPL related MMC defines */ > -#define CONFIG_SYS_U_BOOT_OFFS (160 << 10) > #ifdef CONFIG_SPL_BUILD > #define CONFIG_FIXED_SDHCI_ALIGNED_BUFFER 0x00180000 /* in SDRAM */ > #endif > diff --git a/include/configs/db-mv784mp-gp.h b/include/configs/db-mv784mp-gp.h > index 990fcec129..ef7eebd081 100644 > --- a/include/configs/db-mv784mp-gp.h > +++ b/include/configs/db-mv784mp-gp.h > @@ -78,9 +78,6 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x20000 > - > /* Enable DDR support in SPL (DDR3 training from Marvell bin_hdr) */ > #define CONFIG_SPD_EEPROM 0x4e > #define CONFIG_BOARD_ECC_SUPPORT /* this board supports ECC */ > diff --git a/include/configs/ds414.h b/include/configs/ds414.h > index b34da334e2..4bbb244fa2 100644 > --- a/include/configs/ds414.h > +++ b/include/configs/ds414.h > @@ -68,11 +68,6 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -#if defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI) > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x24000 > -#endif > - > /* DS414 bus width is 32bits */ > #define CONFIG_DDR_32BIT > > diff --git a/include/configs/helios4.h b/include/configs/helios4.h > index 3875377971..1368080f03 100644 > --- a/include/configs/helios4.h > +++ b/include/configs/helios4.h > @@ -69,12 +69,8 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -#if defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI) > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x20000 > -#elif defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC) || defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SATA) > +#if defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC) || defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SATA) > /* SPL related MMC defines */ > -#define CONFIG_SYS_U_BOOT_OFFS (160 << 10) > #ifdef CONFIG_SPL_BUILD > #define CONFIG_FIXED_SDHCI_ALIGNED_BUFFER 0x00180000 /* in SDRAM */ > #endif > diff --git a/include/configs/theadorable.h b/include/configs/theadorable.h > index bfe135da6b..31852fb248 100644 > --- a/include/configs/theadorable.h > +++ b/include/configs/theadorable.h > @@ -93,9 +93,6 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x1a000 > - > /* Enable DDR support in SPL (DDR3 training from Marvell bin_hdr) */ > #define CONFIG_DDR_FIXED_SIZE (2 << 20) /* 2GiB */ > > diff --git a/include/configs/turris_omnia.h b/include/configs/turris_omnia.h > index 49ee7a7af5..0a824b7939 100644 > --- a/include/configs/turris_omnia.h > +++ b/include/configs/turris_omnia.h > @@ -45,14 +45,8 @@ > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > #define CONFIG_SPL_DRIVERS_MISC_SUPPORT > > -#ifdef CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI > -/* SPL related SPI defines */ > -# define CONFIG_SYS_U_BOOT_OFFS 0x24000 > -#endif > - > #ifdef CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC > /* SPL related MMC defines */ > -# define CONFIG_SYS_U_BOOT_OFFS (160 << 10) > # ifdef CONFIG_SPL_BUILD > # define CONFIG_FIXED_SDHCI_ALIGNED_BUFFER 0x00180000 /* in SDRAM */ > # endif > diff --git a/include/configs/x530.h b/include/configs/x530.h > index 25b259832a..515c6e7ff4 100644 > --- a/include/configs/x530.h > +++ b/include/configs/x530.h > @@ -97,7 +97,4 @@ > #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) > #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) > > -/* SPL related SPI defines */ > -#define CONFIG_SYS_U_BOOT_OFFS 0x24000 > - > #endif /* _CONFIG_X530_H */ > diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt > index 042ca116e9..1f88212625 100644 > --- a/scripts/config_whitelist.txt > +++ b/scripts/config_whitelist.txt > @@ -3301,7 +3301,6 @@ CONFIG_SYS_USE_NAND > CONFIG_SYS_USE_NANDFLASH > CONFIG_SYS_USE_NORFLASH > CONFIG_SYS_USR_EXCEP > -CONFIG_SYS_U_BOOT_OFFS > CONFIG_SYS_VCXK_ACKNOWLEDGE_DDR > CONFIG_SYS_VCXK_ACKNOWLEDGE_PIN > CONFIG_SYS_VCXK_ACKNOWLEDGE_PORT > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de