From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: sirf: add atlas7 machine support
Date: Tue, 30 Dec 2014 23:34:32 +0100 [thread overview]
Message-ID: <4739415.xM06V8YCmL@wuerfel> (raw)
In-Reply-To: <1419496460-4929-3-git-send-email-21cnbao@gmail.com>
On Thursday 25 December 2014 16:34:18 Barry Song wrote:
> +DT_MACHINE_START(ATLAS7_DT, "Generic ATLAS7 (Flattened Device Tree)")
> + /* Maintainer: Barry Song <baohua.song@csr.com> */
> + .smp = smp_ops(sirfsoc_smp_ops),
> + .map_io = sirfsoc_map_io,
> + .init_late = sirfsoc_init_late,
> + .dt_compat = atlas7_dt_match,
> +MACHINE_END
Can you check if the sirfsoc_map_io function is still required?
My guess is that you can just replace sirfsoc_map_scu() with a
call of ioremap in sirfsoc_smp_prepare_cpus, and drop sirfsoc_map_lluart()
entirely in favor of the default debug_ll_io_init() function that
is called when map_io is NULL.
Also, how about merging the entries for atlas6 and atlas7, and just
having multiple compatible strings in atlas_dt_match?
Arnd
next prev parent reply other threads:[~2014-12-30 22:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 8:34 [PATCH 0/4] ARM: add basic CSR atlas7 Auto SoC support Barry Song
2014-12-25 8:34 ` [PATCH 1/4] ARM: sirf: add two debug ports for CSRatlas7 SoC Barry Song
2014-12-30 22:35 ` Arnd Bergmann
2014-12-31 15:05 ` Barry Song
2014-12-31 15:31 ` Arnd Bergmann
2015-01-02 7:51 ` Barry Song
2015-01-02 8:59 ` Arnd Bergmann
2014-12-25 8:34 ` [PATCH 2/4] ARM: sirf: add atlas7 machine support Barry Song
2014-12-30 22:34 ` Arnd Bergmann [this message]
2014-12-31 14:50 ` Barry Song
2015-01-02 9:00 ` Arnd Bergmann
2015-01-04 7:23 ` Barry Song
2014-12-25 8:34 ` [PATCH 3/4] ARM: dts: add init dts file for CSR atlas7 SoC Barry Song
2014-12-25 8:34 ` [PATCH 4/4] ARM: sirf: bring up SMP in " Barry Song
2014-12-30 22:38 ` Arnd Bergmann
2014-12-31 14:52 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4739415.xM06V8YCmL@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.