All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] pstore fix for v4.10-rc8
@ 2017-02-09 19:56 Kees Cook
  2017-02-09 20:52   ` Brian Norris
  0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2017-02-09 19:56 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Brian Norris, Kees Cook

Hi,

This pstore regression was just noticed. If I'm too late, this can land
in v4.11 and -stable, but if the fix window is still open for v4.10, I'd
love to see this fix pulled for v4.10.

Thanks!

-Kees

The following changes since commit d966564fcdc19e13eb6ba1fbe6b8101070339c3d:

  Revert "x86/ioapic: Restore IO-APIC irq_chip retrigger callback" (2017-02-08 18:08:29 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git tags/pstore-v4.10-rc8

for you to fetch changes up to 8672aed7bd865774257efd40929702759a869329:

  pstore: don't OOPS when there are no ftrace zones (2017-02-09 11:49:49 -0800)

----------------------------------------------------------------
Fix pstore regression (boot Oops) when ftrace disabled, from Brian Norris.

----------------------------------------------------------------
Brian Norris (1):
      pstore: don't OOPS when there are no ftrace zones

 fs/pstore/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Kees Cook
Pixel Security

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: multi_v7_defconfig: enable pstore configs
  2017-02-09 19:56 [GIT PULL] pstore fix for v4.10-rc8 Kees Cook
@ 2017-02-09 20:52   ` Brian Norris
  0 siblings, 0 replies; 5+ messages in thread
From: Brian Norris @ 2017-02-09 20:52 UTC (permalink / raw)
  To: Russell King
  Cc: linux-kernel, linux-arm-kernel, Kees Cook, Arnd Bergmann, Kevin Hilman

It's useful to get testing on these features on various boards (e.g., on
KernelCI), and (when they're working) the ramoops feature is extremely
helpful for debugging live systems.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
+ ARM folks
- Linus

>From Kees's recent pull request:

On Thu, Feb 09, 2017 at 11:56:46AM -0800, Kees Cook wrote:
> Hi,
> 
> This pstore regression was just noticed. If I'm too late, this can land
> in v4.11 and -stable, but if the fix window is still open for v4.10, I'd
> love to see this fix pulled for v4.10.
> 
> Thanks!
> 
> -Kees
[...]
> ----------------------------------------------------------------
> Fix pstore regression (boot Oops) when ftrace disabled, from Brian Norris.
> 
> ----------------------------------------------------------------

I expect we aren't getting regular testing coverage (e.g., from
KernelCI, which has a few ARM-based Chromebooks in the lab [1], which
would have trivially caught the bug) because pstore is not enabled on
the multiplatform config that gets used there. Seems like a good idea,
so we can catch regressions like this automatically?

[1] https://kernelci.org/boot/rk3288-veyron-jerry/

 arch/arm/configs/multi_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 028d2b70e3b5..74bdb89faff6 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -906,6 +906,10 @@ CONFIG_TMPFS=y
 CONFIG_SQUASHFS=y
 CONFIG_SQUASHFS_LZO=y
 CONFIG_SQUASHFS_XZ=y
+CONFIG_PSTORE=y
+CONFIG_PSTORE_CONSOLE=y
+CONFIG_PSTORE_PMSG=y
+CONFIG_PSTORE_RAM=y
 CONFIG_NFS_FS=y
 CONFIG_NFS_V3_ACL=y
 CONFIG_NFS_V4=y
-- 
2.11.0.483

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: multi_v7_defconfig: enable pstore configs
@ 2017-02-09 20:52   ` Brian Norris
  0 siblings, 0 replies; 5+ messages in thread
From: Brian Norris @ 2017-02-09 20:52 UTC (permalink / raw)
  To: linux-arm-kernel

It's useful to get testing on these features on various boards (e.g., on
KernelCI), and (when they're working) the ramoops feature is extremely
helpful for debugging live systems.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
+ ARM folks
- Linus

>From Kees's recent pull request:

On Thu, Feb 09, 2017 at 11:56:46AM -0800, Kees Cook wrote:
> Hi,
> 
> This pstore regression was just noticed. If I'm too late, this can land
> in v4.11 and -stable, but if the fix window is still open for v4.10, I'd
> love to see this fix pulled for v4.10.
> 
> Thanks!
> 
> -Kees
[...]
> ----------------------------------------------------------------
> Fix pstore regression (boot Oops) when ftrace disabled, from Brian Norris.
> 
> ----------------------------------------------------------------

I expect we aren't getting regular testing coverage (e.g., from
KernelCI, which has a few ARM-based Chromebooks in the lab [1], which
would have trivially caught the bug) because pstore is not enabled on
the multiplatform config that gets used there. Seems like a good idea,
so we can catch regressions like this automatically?

[1] https://kernelci.org/boot/rk3288-veyron-jerry/

 arch/arm/configs/multi_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 028d2b70e3b5..74bdb89faff6 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -906,6 +906,10 @@ CONFIG_TMPFS=y
 CONFIG_SQUASHFS=y
 CONFIG_SQUASHFS_LZO=y
 CONFIG_SQUASHFS_XZ=y
+CONFIG_PSTORE=y
+CONFIG_PSTORE_CONSOLE=y
+CONFIG_PSTORE_PMSG=y
+CONFIG_PSTORE_RAM=y
 CONFIG_NFS_FS=y
 CONFIG_NFS_V3_ACL=y
 CONFIG_NFS_V4=y
-- 
2.11.0.483

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: enable pstore configs
  2017-02-09 20:52   ` Brian Norris
@ 2017-02-16 16:22     ` Arnd Bergmann
  -1 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-02-16 16:22 UTC (permalink / raw)
  To: Brian Norris
  Cc: Russell King, linux-kernel, linux-arm-kernel, Kees Cook, Kevin Hilman

On Thursday, February 9, 2017 12:52:50 PM CET Brian Norris wrote:
> It's useful to get testing on these features on various boards (e.g., on
> KernelCI), and (when they're working) the ramoops feature is extremely
> helpful for debugging live systems.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> + ARM folks
> - Linus

Applied to next/defconfig, thanks!

	Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: multi_v7_defconfig: enable pstore configs
@ 2017-02-16 16:22     ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-02-16 16:22 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday, February 9, 2017 12:52:50 PM CET Brian Norris wrote:
> It's useful to get testing on these features on various boards (e.g., on
> KernelCI), and (when they're working) the ramoops feature is extremely
> helpful for debugging live systems.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> + ARM folks
> - Linus

Applied to next/defconfig, thanks!

	Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-02-16 16:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 19:56 [GIT PULL] pstore fix for v4.10-rc8 Kees Cook
2017-02-09 20:52 ` [PATCH] ARM: multi_v7_defconfig: enable pstore configs Brian Norris
2017-02-09 20:52   ` Brian Norris
2017-02-16 16:22   ` Arnd Bergmann
2017-02-16 16:22     ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.