From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/4] kvargs: support list value Date: Tue, 09 Oct 2018 19:11:25 +0200 Message-ID: <4748941.APsGkUoXuF@xps> References: <20181009021858.19216-1-thomas@monjalon.net> <6562576.89BUxVsNiX@xps> <20181009081140.5c977ad6@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , dev@dpdk.org, ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, olivier.matz@6wind.com, remy.horton@intel.com To: Stephen Hemminger Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B8A551B5C3 for ; Tue, 9 Oct 2018 19:11:29 +0200 (CEST) In-Reply-To: <20181009081140.5c977ad6@xeon-e3> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2018 17:11, Stephen Hemminger: > On Tue, 09 Oct 2018 16:31:24 +0200 > Thomas Monjalon wrote: >=20 > > 09/10/2018 16:14, Ga=EBtan Rivet: > > > Hi Thomas, > > >=20 > > > On Tue, Oct 09, 2018 at 04:18:55AM +0200, Thomas Monjalon wrote: =20 > > > > If a value contains a comma, rte_kvargs_tokenize() will split here. > > > > In order to support list syntax [a,b] as value, an extra parsing of > > > > the square brackets is added. > > > > =20 > > >=20 > > > Nice, I was actually planning to do this. > > >=20 > > > I think it could be useful to also support () and {}, as well as > > > recursive lists, but it is best to have a first version to support > > > representor and go from this. =20 > >=20 > > Yes, we have no usage of () and {} so far. >=20 > This is getting complex enough that doing a real parser maybe necessary. > Why not lex/yacc? I don't know how much it fits with our needs for devargs. > Or better yet go to real syntax like JSON. JSON is not suitable for one-line string as devargs.