From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754631AbcIMNVT (ORCPT ); Tue, 13 Sep 2016 09:21:19 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:35596 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbcIMNVP (ORCPT ); Tue, 13 Sep 2016 09:21:15 -0400 Subject: Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests To: Michael Ellerman , corbet@lwn.net, richardcochran@gmail.com References: <239195aa67e72b7eb971cdacfc9e338de912524e.1473458697.git.shuahkh@osg.samsung.com> <87fup4ovx6.fsf@concordia.ellerman.id.au> Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan From: Shuah Khan Message-ID: <4756400f-e332-a652-f759-6655acdb39cd@osg.samsung.com> Date: Tue, 13 Sep 2016 07:20:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87fup4ovx6.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/13/2016 05:56 AM, Michael Ellerman wrote: > Shuah Khan writes: > >> Update to work under selftests. dnotify_test will not be run as part of >> selftests suite and will not included in install targets. It can be built >> separately for now. >> >> Signed-off-by: Shuah Khan >> --- >> tools/testing/selftests/filesystems/Makefile | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile >> index 883010c..f1dce5c 100644 >> --- a/tools/testing/selftests/filesystems/Makefile >> +++ b/tools/testing/selftests/filesystems/Makefile >> @@ -1,5 +1,7 @@ >> -# List of programs to build >> -hostprogs-y := dnotify_test >> +TEST_PROGS := dnotify_test >> +all: $(TEST_PROGS) >> >> -# Tell kbuild to always build the programs >> -always := $(hostprogs-y) >> +include ../lib.mk >> + >> +clean: >> + rm -fr dnotify_test > > That's a complete rewrite of the Makefile, so I don't think there's any > value in bringing its content across from Documentation. Moving Makefile accomplishes delete at the same time. I can combine the move and updating Makefile into one single patch. > > Better IMHO would be to squash this with the previous patch, so we get a > working test under selftests in a single commit. > > cheers > thanks, -- Shuah