From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965406AbbBCM6I (ORCPT ); Tue, 3 Feb 2015 07:58:08 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:53656 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965081AbbBCM6F (ORCPT ); Tue, 3 Feb 2015 07:58:05 -0500 From: Arnd Bergmann To: Marc Zyngier Cc: "linux-arm-kernel@lists.infradead.org" , Thomas Gleixner , Jiang Liu , Bjorn Helgaas , Andre Przywara , Lorenzo Pieralisi , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Russell King Subject: Re: [PATCH] PCI: Fix pcibios_update_irq misuse of irq number Date: Tue, 03 Feb 2015 13:57:17 +0100 Message-ID: <47577254.MGNlDcIDBf@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <54D0B2FA.9080600@arm.com> References: <1422456683-797-1-git-send-email-marc.zyngier@arm.com> <4324891.mqG6Yyfi6J@wuerfel> <54D0B2FA.9080600@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:JM9gaWtspEj4uqMHPaLZ5y8zr1c8gF60GVKT0AWDnLOxwhjPqgQ a0xnE7fW63dfwwTCx4pLjbQGR+pcqLnfr0VW61FTqNP1NjMagGvUtPhh1KdkvdSgRJLnv02 yjj8xFp22DoppgsNgaECblKCu+zZHx8JUKZGwPS1/eYrqOjBwQTYqx9w6k9sQB5zKhTFMVf wvafbEM4S4xUThJ3agQVQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 February 2015 11:37:30 Marc Zyngier wrote: > Side question: In the probe-only case, should we still allow this write > to happen? No, my understanding is that PCI_PROBE_ONLY precisely means that we do not modify the config space and instead trust what is there to be sensible. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.24]:53656 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965081AbbBCM6F (ORCPT ); Tue, 3 Feb 2015 07:58:05 -0500 From: Arnd Bergmann To: Marc Zyngier Cc: "linux-arm-kernel@lists.infradead.org" , Thomas Gleixner , Jiang Liu , Bjorn Helgaas , Andre Przywara , Lorenzo Pieralisi , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Russell King Subject: Re: [PATCH] PCI: Fix pcibios_update_irq misuse of irq number Date: Tue, 03 Feb 2015 13:57:17 +0100 Message-ID: <47577254.MGNlDcIDBf@wuerfel> In-Reply-To: <54D0B2FA.9080600@arm.com> References: <1422456683-797-1-git-send-email-marc.zyngier@arm.com> <4324891.mqG6Yyfi6J@wuerfel> <54D0B2FA.9080600@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-pci-owner@vger.kernel.org List-ID: On Tuesday 03 February 2015 11:37:30 Marc Zyngier wrote: > Side question: In the probe-only case, should we still allow this write > to happen? No, my understanding is that PCI_PROBE_ONLY precisely means that we do not modify the config space and instead trust what is there to be sensible. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 03 Feb 2015 13:57:17 +0100 Subject: [PATCH] PCI: Fix pcibios_update_irq misuse of irq number In-Reply-To: <54D0B2FA.9080600@arm.com> References: <1422456683-797-1-git-send-email-marc.zyngier@arm.com> <4324891.mqG6Yyfi6J@wuerfel> <54D0B2FA.9080600@arm.com> Message-ID: <47577254.MGNlDcIDBf@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 03 February 2015 11:37:30 Marc Zyngier wrote: > Side question: In the probe-only case, should we still allow this write > to happen? No, my understanding is that PCI_PROBE_ONLY precisely means that we do not modify the config space and instead trust what is there to be sensible. Arnd