All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
@ 2021-05-10 17:13 ` Elia Devito
  0 siblings, 0 replies; 10+ messages in thread
From: Elia Devito @ 2021-05-10 17:13 UTC (permalink / raw)
  Cc: Elia Devito, Jaroslav Kysela, Takashi Iwai, Kailang Yang,
	Jian-Hong Pan, Hui Wang, Chris Chiu, Huacai Chen, alsa-devel,
	linux-kernel

Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
on similar models.

0x14 pin config override is required to enable all speakers and
alc285-speaker2-to-dac1 fixup to enable volume adjustment.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
Signed-off-by: Elia Devito <eliadevito@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4b71609dff1..be2a5cd2875d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6542,6 +6542,7 @@ enum {
 	ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST,
 	ALC295_FIXUP_ASUS_DACS,
 	ALC295_FIXUP_HP_OMEN,
+	ALC285_FIXUP_HP_SPECTRE_X360,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED,
 	},
+	[ALC285_FIXUP_HP_SPECTRE_X360] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x14, 0x90170110 }, /* enable top speaker */
+			{}
+		},
+		.chained = true,
+		.chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1,
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8278,6 +8288,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
+	SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
 	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
@@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 	{.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"},
 	{.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"},
 	{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},
+	{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},
 	{}
 };
 #define ALC225_STANDARD_PINS \
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
@ 2021-05-10 17:13 ` Elia Devito
  0 siblings, 0 replies; 10+ messages in thread
From: Elia Devito @ 2021-05-10 17:13 UTC (permalink / raw)
  Cc: Chris Chiu, alsa-devel, Kailang Yang, linux-kernel, Elia Devito,
	Jian-Hong Pan, Takashi Iwai, Hui Wang, Huacai Chen

Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
on similar models.

0x14 pin config override is required to enable all speakers and
alc285-speaker2-to-dac1 fixup to enable volume adjustment.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
Signed-off-by: Elia Devito <eliadevito@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4b71609dff1..be2a5cd2875d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6542,6 +6542,7 @@ enum {
 	ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST,
 	ALC295_FIXUP_ASUS_DACS,
 	ALC295_FIXUP_HP_OMEN,
+	ALC285_FIXUP_HP_SPECTRE_X360,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED,
 	},
+	[ALC285_FIXUP_HP_SPECTRE_X360] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x14, 0x90170110 }, /* enable top speaker */
+			{}
+		},
+		.chained = true,
+		.chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1,
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8278,6 +8288,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
+	SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
 	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
@@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 	{.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"},
 	{.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"},
 	{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},
+	{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},
 	{}
 };
 #define ALC225_STANDARD_PINS \
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
  2021-05-10 17:13 ` Elia Devito
@ 2021-05-11  9:10   ` Takashi Iwai
  -1 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2021-05-11  9:10 UTC (permalink / raw)
  To: Elia Devito
  Cc: Jaroslav Kysela, Takashi Iwai, Kailang Yang, Jian-Hong Pan,
	Hui Wang, Chris Chiu, Huacai Chen, alsa-devel, linux-kernel

On Mon, 10 May 2021 19:13:33 +0200,
Elia Devito wrote:
> 
> Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
> on similar models.
> 
> 0x14 pin config override is required to enable all speakers and
> alc285-speaker2-to-dac1 fixup to enable volume adjustment.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
> Signed-off-by: Elia Devito <eliadevito@gmail.com>

Could you try to put the quirk entry in the PCI SSID order?


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b4b71609dff1..be2a5cd2875d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6542,6 +6542,7 @@ enum {
>  	ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST,
>  	ALC295_FIXUP_ASUS_DACS,
>  	ALC295_FIXUP_HP_OMEN,
> +	ALC285_FIXUP_HP_SPECTRE_X360,
>  };
>  
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.chained = true,
>  		.chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED,
>  	},
> +	[ALC285_FIXUP_HP_SPECTRE_X360] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x14, 0x90170110 }, /* enable top speaker */
> +			{}
> +		},
> +		.chained = true,
> +		.chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1,
> +	},
>  };
>  
>  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> @@ -8278,6 +8288,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
> +	SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
>  	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> @@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>  	{.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"},
>  	{.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"},
>  	{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},
> +	{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},
>  	{}
>  };
>  #define ALC225_STANDARD_PINS \
> -- 
> 2.31.1
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
@ 2021-05-11  9:10   ` Takashi Iwai
  0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2021-05-11  9:10 UTC (permalink / raw)
  To: Elia Devito
  Cc: Chris Chiu, alsa-devel, Kailang Yang, linux-kernel, Huacai Chen,
	Jian-Hong Pan, Takashi Iwai, Hui Wang

On Mon, 10 May 2021 19:13:33 +0200,
Elia Devito wrote:
> 
> Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
> on similar models.
> 
> 0x14 pin config override is required to enable all speakers and
> alc285-speaker2-to-dac1 fixup to enable volume adjustment.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
> Signed-off-by: Elia Devito <eliadevito@gmail.com>

Could you try to put the quirk entry in the PCI SSID order?


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b4b71609dff1..be2a5cd2875d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6542,6 +6542,7 @@ enum {
>  	ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST,
>  	ALC295_FIXUP_ASUS_DACS,
>  	ALC295_FIXUP_HP_OMEN,
> +	ALC285_FIXUP_HP_SPECTRE_X360,
>  };
>  
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.chained = true,
>  		.chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED,
>  	},
> +	[ALC285_FIXUP_HP_SPECTRE_X360] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x14, 0x90170110 }, /* enable top speaker */
> +			{}
> +		},
> +		.chained = true,
> +		.chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1,
> +	},
>  };
>  
>  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> @@ -8278,6 +8288,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP),
> +	SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
>  	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> @@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>  	{.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"},
>  	{.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"},
>  	{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},
> +	{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},
>  	{}
>  };
>  #define ALC225_STANDARD_PINS \
> -- 
> 2.31.1
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
  2021-05-11  9:10   ` Takashi Iwai
@ 2021-05-11 12:46     ` Elia Devito
  -1 siblings, 0 replies; 10+ messages in thread
From: Elia Devito @ 2021-05-11 12:46 UTC (permalink / raw)
  Cc: Elia Devito, Jaroslav Kysela, Takashi Iwai, Kailang Yang,
	Jian-Hong Pan, Hui Wang, Chris Chiu, Huacai Chen, alsa-devel,
	linux-kernel

Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
on similar models.

0x14 pin config override is required to enable all speakers and
alc285-speaker2-to-dac1 fixup to enable volume adjustment.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
Signed-off-by: Elia Devito <eliadevito@gmail.com>
---
v2: Put the quirk entry in the PCI SSID order

 sound/pci/hda/patch_realtek.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4b71609dff1..3e269de84079 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6542,6 +6542,7 @@ enum {
 	ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST,
 	ALC295_FIXUP_ASUS_DACS,
 	ALC295_FIXUP_HP_OMEN,
+	ALC285_FIXUP_HP_SPECTRE_X360,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED,
 	},
+	[ALC285_FIXUP_HP_SPECTRE_X360] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x14, 0x90170110 }, /* enable top speaker */
+			{}
+		},
+		.chained = true,
+		.chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1,
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8259,6 +8269,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
 	SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_OMEN),
 	SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
+	SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
 	SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
 	SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),
 	SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
@@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 	{.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"},
 	{.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"},
 	{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},
+	{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},
 	{}
 };
 #define ALC225_STANDARD_PINS \
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
@ 2021-05-11 12:46     ` Elia Devito
  0 siblings, 0 replies; 10+ messages in thread
From: Elia Devito @ 2021-05-11 12:46 UTC (permalink / raw)
  Cc: Chris Chiu, alsa-devel, Kailang Yang, linux-kernel, Elia Devito,
	Jian-Hong Pan, Takashi Iwai, Hui Wang, Huacai Chen

Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
on similar models.

0x14 pin config override is required to enable all speakers and
alc285-speaker2-to-dac1 fixup to enable volume adjustment.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
Signed-off-by: Elia Devito <eliadevito@gmail.com>
---
v2: Put the quirk entry in the PCI SSID order

 sound/pci/hda/patch_realtek.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4b71609dff1..3e269de84079 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6542,6 +6542,7 @@ enum {
 	ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST,
 	ALC295_FIXUP_ASUS_DACS,
 	ALC295_FIXUP_HP_OMEN,
+	ALC285_FIXUP_HP_SPECTRE_X360,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED,
 	},
+	[ALC285_FIXUP_HP_SPECTRE_X360] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x14, 0x90170110 }, /* enable top speaker */
+			{}
+		},
+		.chained = true,
+		.chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1,
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8259,6 +8269,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
 	SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_OMEN),
 	SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
+	SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
 	SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
 	SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO),
 	SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
@@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 	{.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"},
 	{.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"},
 	{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},
+	{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},
 	{}
 };
 #define ALC225_STANDARD_PINS \
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
  2021-05-11 12:46     ` Elia Devito
@ 2021-05-11 13:45       ` Takashi Iwai
  -1 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2021-05-11 13:45 UTC (permalink / raw)
  To: Elia Devito
  Cc: Jaroslav Kysela, Takashi Iwai, Kailang Yang, Jian-Hong Pan,
	Hui Wang, Chris Chiu, Huacai Chen, alsa-devel, linux-kernel

On Tue, 11 May 2021 14:46:49 +0200,
Elia Devito wrote:
> 
> Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
> on similar models.
> 
> 0x14 pin config override is required to enable all speakers and
> alc285-speaker2-to-dac1 fixup to enable volume adjustment.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
> Signed-off-by: Elia Devito <eliadevito@gmail.com>
> ---
> v2: Put the quirk entry in the PCI SSID order

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
@ 2021-05-11 13:45       ` Takashi Iwai
  0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2021-05-11 13:45 UTC (permalink / raw)
  To: Elia Devito
  Cc: Chris Chiu, alsa-devel, Kailang Yang, linux-kernel, Huacai Chen,
	Jian-Hong Pan, Takashi Iwai, Hui Wang

On Tue, 11 May 2021 14:46:49 +0200,
Elia Devito wrote:
> 
> Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably
> on similar models.
> 
> 0x14 pin config override is required to enable all speakers and
> alc285-speaker2-to-dac1 fixup to enable volume adjustment.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
> Signed-off-by: Elia Devito <eliadevito@gmail.com>
> ---
> v2: Put the quirk entry in the PCI SSID order

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
  2021-05-11 13:45       ` Takashi Iwai
@ 2021-05-11 14:53         ` Elia Devito
  -1 siblings, 0 replies; 10+ messages in thread
From: Elia Devito @ 2021-05-11 14:53 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Jaroslav Kysela, Takashi Iwai, Kailang Yang, Jian-Hong Pan,
	Hui Wang, Chris Chiu, Huacai Chen, alsa-devel, linux-kernel

Il giorno mar, 11/05/2021 alle 15.45 +0200, Takashi Iwai ha scritto:
> On Tue, 11 May 2021 14:46:49 +0200,
> Elia Devito wrote:
> > 
> > Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and
> > probably
> > on similar models.
> > 
> > 0x14 pin config override is required to enable all speakers and
> > alc285-speaker2-to-dac1 fixup to enable volume adjustment.
> > 
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
> > Signed-off-by: Elia Devito <eliadevito@gmail.com>
> > ---
> > v2: Put the quirk entry in the PCI SSID order
> 
> Thanks, applied now.
> 
> 
> Takashi

Thanks for your time.

Elia


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx
@ 2021-05-11 14:53         ` Elia Devito
  0 siblings, 0 replies; 10+ messages in thread
From: Elia Devito @ 2021-05-11 14:53 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Chris Chiu, alsa-devel, Kailang Yang, linux-kernel, Huacai Chen,
	Jian-Hong Pan, Takashi Iwai, Hui Wang

Il giorno mar, 11/05/2021 alle 15.45 +0200, Takashi Iwai ha scritto:
> On Tue, 11 May 2021 14:46:49 +0200,
> Elia Devito wrote:
> > 
> > Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and
> > probably
> > on similar models.
> > 
> > 0x14 pin config override is required to enable all speakers and
> > alc285-speaker2-to-dac1 fixup to enable volume adjustment.
> > 
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331
> > Signed-off-by: Elia Devito <eliadevito@gmail.com>
> > ---
> > v2: Put the quirk entry in the PCI SSID order
> 
> Thanks, applied now.
> 
> 
> Takashi

Thanks for your time.

Elia


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-05-11 14:54 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 17:13 [PATCH] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx Elia Devito
2021-05-10 17:13 ` Elia Devito
2021-05-11  9:10 ` Takashi Iwai
2021-05-11  9:10   ` Takashi Iwai
2021-05-11 12:46   ` [PATCH v2] " Elia Devito
2021-05-11 12:46     ` Elia Devito
2021-05-11 13:45     ` Takashi Iwai
2021-05-11 13:45       ` Takashi Iwai
2021-05-11 14:53       ` Elia Devito
2021-05-11 14:53         ` Elia Devito

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.