All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: Holger Brunck <holger.brunck@hitachienergy.com>,
	Tom Rini <trini@konsulko.com>
Cc: Aleksandar Gerasimovski
	<aleksandar.gerasimovski@hitachienergy.com>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Marek Behun <marek.behun@nic.cz>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Simon Glass <sjg@chromium.org>, Wolfgang Denk <wd@denx.de>,
	Harald Seiler <hws@denx.de>, Heiko Schocher <hs@denx.de>
Subject: Re: [RFC PATCH v4 28/28] board: keymile: common: Use environment to store IVM_* variables.
Date: Fri, 12 Aug 2022 23:01:18 +0200	[thread overview]
Message-ID: <4760895.31r3eYUQgx@pwmachine> (raw)
In-Reply-To: <20220620173324.GP2484912@bill-the-cat>

Hi.

Le lundi 20 juin 2022, 19:33:24 CEST Tom Rini a écrit :
> On Mon, Jun 20, 2022 at 04:08:32PM +0000, Holger Brunck wrote:
> > > > > On Fri, Jun 17, 2022 at 12:31:58AM +0200, Francis Laniel wrote:
> > > > > > These boards used set_local_var() to store some variables as local
> > > > > > shell.
> > > > > > They then used get_local_var() to retrieve the variables values.
> > > > > > 
> > > > > > Instead of using local shell variables, they should use
> > > > > > environment ones (like a majority of board).
> > > > > > So, this patch converts using local variables to environment ones.
> > > > 
> > > > why do we need to change that? It is intended that we use this hush
> > > > variable infrastructure from u-boot (common/hush.c) for our IVM data
> > > > and not the standard env. We read the IVM at boot time and store these
> > > > values in RAM. It is not intended to store them permanently in the
> > > > flash or wherever the environment is saved. Especially in our case we
> > > > have some boards where the environment is in a i2c EEPROM and we don't
> > > > want to write down to the EEPROM each time when the board is starting.
> > > 
> > > So, the whole series is about updating hush to bring in a new baseline
> > > version of the shell, from busybox.
> > 
> > Ok.
> > 
> > > > > > Signed-off-by: Francis Laniel
> > > > > > <francis.laniel@amarulasolutions.com>
> > > > > > ---
> > > > > > 
> > > > > >  board/keymile/common/common.c | 8 ++++----
> > > > > >  board/keymile/common/ivm.c    | 9 +--------
> > > > > >  2 files changed, 5 insertions(+), 12 deletions(-)
> > > > > > 
> > > > > > diff --git a/board/keymile/common/common.c
> > > > > > b/board/keymile/common/common.c index 3999f48719..72939af36e
> > > > > > 100644
> > > > > > --- a/board/keymile/common/common.c
> > > > > > +++ b/board/keymile/common/common.c
> > > > > > @@ -219,7 +219,7 @@ static int do_setboardid(struct cmd_tbl
> > > > > > *cmdtp, int
> > > > > 
> > > > > flag, int argc,
> > > > > 
> > > > > >  	unsigned char buf[32];
> > > > > >  	char *p;
> > > > > > 
> > > > > > -	p = get_local_var("IVM_BoardId");
> > > > > > +	p = env_get("IVM_BoardId");
> > > > > > 
> > > > > >  	if (!p) {
> > > > > >  	
> > > > > >  		printf("can't get the IVM_Boardid\n");
> > > > > >  		return 1;
> > > > > > 
> > > > > > @@ -228,7 +228,7 @@ static int do_setboardid(struct cmd_tbl
> > > > > > *cmdtp, int
> > > > > 
> > > > > flag, int argc,
> > > > > 
> > > > > >  	env_set("boardid", (char *)buf);
> > > > > >  	printf("set boardid=%s\n", buf);
> > > > > > 
> > > > > > -	p = get_local_var("IVM_HWKey");
> > > > > > +	p = env_get("IVM_HWKey");
> > > > > > 
> > > > > >  	if (!p) {
> > > > > >  	
> > > > > >  		printf("can't get the IVM_HWKey\n");
> > > > > >  		return 1;
> > > > > > 
> > > > > > @@ -272,14 +272,14 @@ static int do_checkboardidhwk(struct cmd_tbl
> > > > > 
> > > > > *cmdtp, int flag, int argc,
> > > > > 
> > > > > >  	 * first read out the real inventory values, these values are
> > > > > >  	 * already stored in the local hush variables
> > > > > >  	 */
> > > > > > 
> > > > > > -	p = get_local_var("IVM_BoardId");
> > > > > > +	p = env_get("IVM_BoardId");
> > > > > > 
> > > > > >  	if (!p) {
> > > > > >  	
> > > > > >  		printf("can't get the IVM_Boardid\n");
> > > > > >  		return 1;
> > > > > >  	
> > > > > >  	}
> > > > > >  	rc = strict_strtoul(p, 16, &ivmbid);
> > > > > > 
> > > > > > -	p = get_local_var("IVM_HWKey");
> > > > > > +	p = env_get("IVM_HWKey");
> > > > > > 
> > > > > >  	if (!p) {
> > > > > >  	
> > > > > >  		printf("can't get the IVM_HWKey\n");
> > > > > >  		return 1;
> > > > > > 
> > > > > > diff --git a/board/keymile/common/ivm.c
> > > > > > b/board/keymile/common/ivm.c index 67db0c50f4..e266d7ce81 100644
> > > > > > --- a/board/keymile/common/ivm.c
> > > > > > +++ b/board/keymile/common/ivm.c
> > > > > > @@ -44,14 +44,7 @@ static int ivm_calc_crc(unsigned char *buf, int
> > > > > > len)
> > > > > > 
> > > > > >  static int ivm_set_value(char *name, char *value)  {
> > > > > > 
> > > > > > -	char tempbuf[256];
> > > > > > -
> > > > > > -	if (value) {
> > > > > > -		sprintf(tempbuf, "%s=%s", name, value);
> > > > > > -		return set_local_var(tempbuf, 0);
> > > > > > -	}
> > > > > > -	unset_local_var(name);
> > > > > > -	return 0;
> > > > > > +	return env_set(name, value);
> > > > 
> > > > this means we are now writing always down to the permanent environment
> > > > or? And this I would really like to avoid in our case.
> > > 
> > > Note that "env_set" does not force a save of the running environment.
> > 
> > Ah yes you are right. But still for the first boot of our board we will
> > call saveenv to store an initial environment and with this change it
> > would also write down the IVM data which is currently only stored
> > temporary in RAM.
> > 
> > > These variables will be exposed to the CLI run-time, which I am not sure
> > > if they are today, so if the user then does "saveenv" they will be
> > > written.  That I think would be a functional difference.
> > 
> > yes exactly and I wonder if this functionality will be also possible after
> > the rework. I mean our use case (even it seems we are the only ones using
> > it) is quite useful I think. We read out inventory data from an EEPROM
> > and they are parsed and temporary stored in RAM and then we are able to
> > use them as any other environment variables without the need to store
> > them permanently. I also would like to avoid this as the data should be
> > permanently in the IVM only and not stored a second time permanently  in
> > flash.
> 
> So, I'll start by noting that the environment variable flag support
> isn't as well documented as I would like.  But my super quick glance
> makes me wonder if ENV_FLAGS_VARACCESS_WRITEABLE does what you're
> thinking about, and if not, if it would be useful to extend the flag
> support to include a "hidden" flag, or otherwise way to indicate that
> variables A/B/C should never be saved.  This could be useful for other
> cases as well.

Again, sorry for the late reply.

To be honest, this board is the only one which presents this behavior.
I will think about a mechanism to handle your use case.
Nonetheless, as you are the exception and this series begins to be a bit big I 
think in a first time I will not address it.
I will just add these patches to make the CI happy, but I will mark them as 
"do not merge".
So, we can merge this series and you can still use the old hush shell, as I do 
not think we plan about making the new version the default right now.

What do you think?
Does it seem acceptable for you?



  reply	other threads:[~2022-08-12 21:01 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 22:31 [RFC PATCH v4 00/28] Modernize U-Boot shell Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 01/28] video: sandbox: Add dummy function for sandbox_sdl_remove_display() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 02/28] test: Add framework to test hush behavior Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 03/28] test: hush: Test hush if/else Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 04/28] test/py: hush_if_test: Remove the test file Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 05/28] test: hush: Test hush variable expansion Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 06/28] test: hush: Test hush commands list Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 07/28] test: hush: Test hush loops Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 08/28] cli: Add Busybox upstream hush.c file Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 09/28] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 10/28] cli: Add menu for hush parser Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 11/28] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 12/28] cmd: Add new parser command Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 13/28] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 14/28] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 15/28] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 16/28] cli: add hush 2021 as parser for run_command*() Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 17/28] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 18/28] test: hush: Fix variable expansion " Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 19/28] cli: hush_2021: Enable using \< and \> as string compare operators Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 20/28] cli: hush_2021: Enable if keyword Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 21/28] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 22/28] cli: hush_2021: Enable loops Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 23/28] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 24/28] Modernize U-Boot shell Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 25/28] cli: hush_2021: Add upstream commits up to 6th February 2022 Francis Laniel
2022-06-20 19:11   ` Tom Rini
2022-08-12 20:56     ` Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 26/28] for test purpose only: Comment out dollar tests which prints error messages Francis Laniel
2022-06-17 14:02   ` Tom Rini
2022-08-12 21:12     ` Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 27/28] for test purpose only: Comment out failed function which fails only in CI Francis Laniel
2022-06-17 14:49   ` Tom Rini
2022-10-10 20:52     ` [PATCH] for debug purpose only: add print to debug odd behavior Francis Laniel
2022-06-16 22:31 ` [RFC PATCH v4 28/28] board: keymile: common: Use environment to store IVM_* variables Francis Laniel
2022-06-17 14:48   ` Tom Rini
2022-06-20 14:46     ` Aleksandar Gerasimovski
2022-06-20 15:27       ` Holger Brunck
2022-06-20 15:35         ` Tom Rini
2022-06-20 16:08           ` Holger Brunck
2022-06-20 17:33             ` Tom Rini
2022-08-12 21:01               ` Francis Laniel [this message]
2022-08-15  8:13                 ` Holger Brunck
2022-06-17 14:50 ` [RFC PATCH v4 00/28] Modernize U-Boot shell Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4760895.31r3eYUQgx@pwmachine \
    --to=francis.laniel@amarulasolutions.com \
    --cc=aleksandar.gerasimovski@hitachienergy.com \
    --cc=holger.brunck@hitachienergy.com \
    --cc=hs@denx.de \
    --cc=hws@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=michael@amarulasolutions.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.