From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 02/10] telemetry: add initial connection
	socket
Date: Wed, 03 Oct 2018 21:36:39 +0200
Message-ID: <4764579.GE1JWGAuKW@xps>
References: <1535026093-101872-1-git-send-email-ciara.power@intel.com>
 <20181003173612.67101-3-kevin.laatz@intel.com>
 <72e3e8d1-fa63-2531-a3c3-2d0c9ee5d151@ericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: Mattias =?ISO-8859-1?Q?R=F6nnblom?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org,
 gaetan.rivet@6wind.com, shreyansh.jain@nxp.com,
 Ciara Power <ciara.power@intel.com>, Brian Archbold <brian.archbold@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5FE801B205
 for <dev@dpdk.org>; Wed,  3 Oct 2018 21:36:43 +0200 (CEST)
In-Reply-To: <72e3e8d1-fa63-2531-a3c3-2d0c9ee5d151@ericsson.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/10/2018 20:40, Mattias R=F6nnblom:
> On 2018-10-03 19:36, Kevin Laatz wrote:
> > +#define DEFAULT_DPDK_PATH "/var/run/.rte_telemetry"
> > +
>=20
> FHS 3.0 recommends "/run" over "/var/run". Maybe a more descriptive=20
> macro name would be in order, too.

Kevin, you should use eal_get_runtime_dir().
You may need to export this function as a public API.

Mattias, thank you for the detailed review.